From: Andrew Zaborowski <andrew.zaborowski@intel.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: ell@lists.linux.dev
Subject: Re: [PATCH 3/3] tls: Add support l_tls_set_alpn_list() and ALPN extension
Date: Mon, 9 Jan 2023 13:21:29 +0100 [thread overview]
Message-ID: <CAOq732KFWmSjq1LWzpQ_V4ZQVjEZ4WUHcyGzZ5UXHc6TH9UvRA@mail.gmail.com> (raw)
In-Reply-To: <1E8A2AE4-86F5-4D0A-A0A0-DC0359466523@holtmann.org>
Hi Marcel,
On Thu, 5 Jan 2023 at 16:15, Marcel Holtmann <marcel@holtmann.org> wrote:
> >> +static bool tls_alpn_server_absent(struct l_tls *tls)
> >> +{
> >> + if (!tls->alpn_list)
> >> + return false;
> >
> > I believe this returning false will break most usages of l_tls.
>
> can you elaborate why? When are you allowed to return false.
false here means that the extension should have been present, i.e. we
signal an error. If the extension code thinks we're fine to proceed
it returns true.
This also makes the unit test fail.
Best regards and happy new year
prev parent reply other threads:[~2023-01-09 12:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 22:02 [PATCH 3/3] tls: Add support l_tls_set_alpn_list() and ALPN extension Marcel Holtmann
2023-01-04 21:08 ` Andrew Zaborowski
2023-01-05 15:15 ` Marcel Holtmann
2023-01-09 12:21 ` Andrew Zaborowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOq732KFWmSjq1LWzpQ_V4ZQVjEZ4WUHcyGzZ5UXHc6TH9UvRA@mail.gmail.com \
--to=andrew.zaborowski@intel.com \
--cc=ell@lists.linux.dev \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).