From: Michael Johnson <mjohnson459 at gmail.com>
To: ell at lists.01.org
Subject: Re: [PATCH] dhcp: Use bound_time for retransmission timers
Date: Fri, 13 May 2022 18:10:52 +0100 [thread overview]
Message-ID: <CACsRnHU8uhpdyZwQXJrWo=EsKK-CmvO4OHoTBt_RnoDaBtRUhg@mail.gmail.com> (raw)
In-Reply-To: 8b5ce99b-55ad-53cf-fe82-4930735b420c@gmail.com
[-- Attachment #1: Type: text/plain, Size: 1254 bytes --]
Great, thank you!
I'll run this patch on master over the weekend and see if I can get
more data for the other issue.
Regards,
Michael
On Fri, 13 May 2022 at 17:23, Denis Kenzior <denkenz(a)gmail.com> wrote:
>
> Hi Michael,
>
> On 5/13/22 10:40, Michael Johnson wrote:
> > Sorry, I put the log for the t2 retry. Putting it in the right place
> > gives us our problem though
> >
> > ```
> > May 13 15:38:34 r2-19006 iwd[39610]: [DHCPv4] dhcp_client_t1_expired:630
> > May 13 15:38:34 r2-19006 iwd[39610]: [DHCPv4]
> > dhcp_client_t1_expired:632 Entering state: DHCP_STATE_RENEWING
> > May 13 15:38:34 r2-19006 iwd[39610]: [DHCPv4] dhcp_client_send_request:397
> > May 13 15:38:34 r2-19006 iwd[39610]: [DHCPv4]
> > dhcp_client_t1_expired:642 next_timeout t2: 225
> > May 13 15:38:34 r2-19006 iwd[39610]: [DHCPv4]
> > dhcp_client_t1_expired:651 next_timeout t1 retry: 896458022
>
> Ugh, looks like commit:
> c78ad1bb6d7e ("dhcp: Set lease expiry based on frame reception times")
>
> broke this. It is mixing up SO_TIMESTAMP which is from CLOCK_REALTIME and our
> bound_time which is supposed to be in CLOCK_BOOTTIME.
>
> No wonder the timeout way too long :)
>
> Let me send another fixup patch.
>
> Regards,
> -Denis
next reply other threads:[~2022-05-13 17:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 17:10 Michael Johnson [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-05-18 16:21 [PATCH] dhcp: Use bound_time for retransmission timers Denis Kenzior
2022-05-13 16:23 Denis Kenzior
2022-05-13 15:40 Michael Johnson
2022-05-13 15:31 Michael Johnson
2022-05-13 14:30 Denis Kenzior
2022-05-13 13:53 Michael Johnson
2022-05-11 17:28 Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACsRnHU8uhpdyZwQXJrWo=EsKK-CmvO4OHoTBt_RnoDaBtRUhg@mail.gmail.com' \
--to=ell@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).