From: Denis Kenzior <denkenz@gmail.com>
To: Brandon Cheo Fusi <fusibrandon13@gmail.com>
Cc: Marcel Holtmann <marcel@holtmann.org>, ell@lists.linux.dev
Subject: Re: [PATCH] ell: Make public headers compilable with C++
Date: Mon, 22 May 2023 09:34:19 -0500 [thread overview]
Message-ID: <2ec7c50c-10e2-396f-9ff2-9b1d3d4b9135@gmail.com> (raw)
In-Reply-To: <CAEVJM+pD_CafRK=B+OXqJZHx-MDz-PsCRDkO43fji1VmZ_cjew@mail.gmail.com>
Hi Brandon,
No top posting on this list please.
>
> Thanks for pointing that out. Wouldn't it be better to not assume an
> array of 6+ bytes and instead
> do NULL and size checking in the implementations?
>
Well, 'better' is in the eyes of the beholder. Since we're primarily a C
library, the guarantees that [static 6] syntax provides are 'better' since we
can avoid unnecessary checking. This checking is trivial in the end, but still...
This particular syntax also helps with code readability since the user is
automatically provided an explicit meaning of the function arguments.
I'd like to preserve the latter if there's another suitable alternative. My
main point though is that your patch that just changes the signature is not
enough. You have to address the implementation and ideally submit patches to
iwd since you're breaking the API.
Regards,
-Denis
prev parent reply other threads:[~2023-05-22 14:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 12:20 [PATCH] ell: Make public headers compilable with C++ Brandon Cheo Fusi
2023-04-28 16:08 ` James Prestwood
2023-04-30 18:13 ` Denis Kenzior
2023-05-10 15:43 ` Brandon Cheo Fusi
2023-05-22 14:34 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ec7c50c-10e2-396f-9ff2-9b1d3d4b9135@gmail.com \
--to=denkenz@gmail.com \
--cc=ell@lists.linux.dev \
--cc=fusibrandon13@gmail.com \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).