From: James Prestwood <prestwoj@gmail.com>
To: ell@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH 1/5] cert: remove usused elem_data variable
Date: Tue, 5 Mar 2024 05:28:03 -0800 [thread overview]
Message-ID: <20240305132807.85724-1-prestwoj@gmail.com> (raw)
This was being set in the if block, but never used after that.
Instead just check the return value directly.
---
ell/cert.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/ell/cert.c b/ell/cert.c
index ead9cfd..38bb01a 100644
--- a/ell/cert.c
+++ b/ell/cert.c
@@ -1658,7 +1658,6 @@ static int cert_try_load_der_format(const uint8_t *content, size_t content_len,
{
const uint8_t *seq;
size_t seq_len;
- const uint8_t *elem_data;
size_t elem_len;
uint8_t tag;
@@ -1674,8 +1673,7 @@ static int cert_try_load_der_format(const uint8_t *content, size_t content_len,
* to add any more formats we'll probably need to start guessing
* from the filename suffix.
*/
- if (!(elem_data = asn1_der_find_elem(seq, seq_len,
- 0, &tag, &elem_len)))
+ if (!asn1_der_find_elem(seq, seq_len,0, &tag, &elem_len))
return -ENOMSG;
if (tag == ASN1_ID_SEQUENCE) {
--
2.34.1
next reply other threads:[~2024-03-05 13:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 13:28 James Prestwood [this message]
2024-03-05 13:28 ` [PATCH 2/5] dbus: remove unused 'type' variable James Prestwood
2024-03-05 13:28 ` [PATCH 3/5] gvariant-util: remove unneeded initializer James Prestwood
2024-03-05 13:28 ` [PATCH 4/5] queue: remove unneeded entry advancement James Prestwood
2024-03-05 13:28 ` [PATCH 5/5] unit: assert return of several gvariant-util calls James Prestwood
2024-03-12 3:12 ` [PATCH 1/5] cert: remove usused elem_data variable Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240305132807.85724-1-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=ell@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).