($INBOX_DIR/description missing)
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: ell@lists.linux.dev
Cc: andrew.zaborowski@intel.com
Subject: [PATCH 2/3] tls: Replace tls->ready_handle with tls->ready_handler
Date: Tue,  3 Jan 2023 15:39:59 +0100	[thread overview]
Message-ID: <20230103144000.641471-2-marcel@holtmann.org> (raw)

In general the naming should be "handler" instead of "handle" if it is a
callback function.
---
 ell/tls-private.h | 2 +-
 ell/tls.c         | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/ell/tls-private.h b/ell/tls-private.h
index 46889ad86769..bfd20b10cf88 100644
--- a/ell/tls-private.h
+++ b/ell/tls-private.h
@@ -200,7 +200,7 @@ struct l_tls {
 	bool server;
 
 	l_tls_write_cb_t tx, rx;
-	l_tls_ready_cb_t ready_handle;
+	l_tls_ready_cb_t ready_handler;
 	l_tls_disconnect_cb_t disconnected;
 	void *user_data;
 	l_tls_debug_cb_t debug_handler;
diff --git a/ell/tls.c b/ell/tls.c
index 72ff4d7723ec..687797f1e466 100644
--- a/ell/tls.c
+++ b/ell/tls.c
@@ -3072,7 +3072,7 @@ static void tls_finished(struct l_tls *tls)
 
 	if (!renegotiation) {
 		tls->in_callback = true;
-		tls->ready_handle(peer_identity, tls->user_data);
+		tls->ready_handler(peer_identity, tls->user_data);
 		tls->in_callback = false;
 	}
 
@@ -3361,7 +3361,7 @@ LIB_EXPORT struct l_tls *l_tls_new(bool server,
 	tls->server = server;
 	tls->rx = app_data_handler;
 	tls->tx = tx_handler;
-	tls->ready_handle = ready_handler;
+	tls->ready_handler = ready_handler;
 	tls->disconnected = disconnect_handler;
 	tls->user_data = user_data;
 	tls->cipher_suite_pref_list = tls_cipher_suite_pref;
-- 
2.39.0


                 reply	other threads:[~2023-01-03 14:47 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230103144000.641471-2-marcel@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=andrew.zaborowski@intel.com \
    --cc=ell@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).