From: Fangrui Song <maskray@google.com>
To: dwarves@vger.kernel.org
Cc: Bill Wendling <morbo@google.com>
Subject: pahole -J usage in kernel scripts/link-vmlinux.sh
Date: Wed, 17 Mar 2021 16:26:57 -0700 [thread overview]
Message-ID: <20210317232657.mdnsuoqx6nbddjgt@google.com> (raw)
Hi BTF folks,
I have discovered some problems with pahole -J.
Its usage in kernel scripts/link-vmlinux.sh is like (make LLVM=1 bzImage):
ld.lld -m elf_x86_64 --emit-relocs --discard-none -z max-page-size=0x200000 --build-id=sha1 --orphan-handling=warn -o .tmp_vmlinux.btf -T ./arch/x86/kernel/vmlinux.lds --whole-archive arch/x86/kernel/head_64.o arch/x86/kernel/head64.o arch/x86/kernel/ebda.o arch/x86/kernel/platform-quirks.o init/built-in.a usr/built-in.a arch/x86/built-in.a kernel/built-in.a certs/built-in.a mm/built-in.a fs/built-in.a ipc/built-in.a security/built-in.a crypto/built-in.a block/built-in.a lib/built-in.a arch/x86/lib/built-in.a lib/lib.a arch/x86/lib/lib.a drivers/built-in.a sound/built-in.a net/built-in.a virt/built-in.a arch/x86/pci/built-in.a arch/x86/power/built-in.a arch/x86/video/built-in.a --no-whole-archive --start-group --end-group
pahole -J .tmp_vmlinux.btf
llvm-objcopy --only-section=.BTF --set-section-flags .BTF=alloc,readonly --strip-all .tmp_vmlinux.btf .btf.vmlinux.bin.o
pahole -J adds .BTF and rewrites .tmp_vmlinux.btf, then llvm-objcopy produces .btf.vmlinux.bin.o of just one section.
Why doesn't pahole provide a command generating an object file with just the .BTF section?
When I contributed https://git.kernel.org/linus/90ceddcb495008ac8ba7a3dce297841efcd7d584 ,
I remember pahole at that time added a non-SHF_ALLOC .BTF , now (1.20) .BTF becomes SHF_ALLOC.
This is problematic if pahole does not have full-fledged binary manipulation ability (objcopy,llvm-objcopy).
In particular, there are two bugs:
* pahole does not respect max-page-size (p_align of PT_LOAD). See the .text section, its
sh_offset != sh_addr (mod max-page-size)
Section Headers:
[Nr] Name Type Address Off Size ES Flg Lk Inf Al
[ 0] NULL 0000000000000000 000000 000000 00 0 0 0
- [ 1] .text PROGBITS ffffffff81000000 200000 1003917 00 AX 0 0 4096
+ [ 1] .text PROGBITS ffffffff81000000 001000 e0169a 00 AX 0 0 4096
* pahole does not rewrite p_offset/p_filesz of PT_LOAD segments.
Because of the first bug, pahole -J rewritten object file generally has small offsets.
If p_offset/p_filesz of PT_LOAD segments are not rewritten, the file offset range of .symtab may be within
a PT_LOAD range. llvm-objcopy --strip-all considers .symtab as part of the PT_LOAD and refuses --strip-all:
error: '.tmp_vmlinux.btf': string table '.strtab' cannot be removed because it is referenced by the symbol table '.symtab'
This is very rare, though.
So I suggest:
* pahole -J: restore the previous non-SHF_ALLOC behavior. Don't rewrite sh_offset of existing sections.
Place the new non-SHF_ALLOC .BTF section at the end.
Then not rewriting PT_LOAD will be justified.
* Add a new option incorporating the current pahole -J + llvm-objcopy
next reply other threads:[~2021-03-17 23:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 23:26 Fangrui Song [this message]
2021-03-19 22:44 ` pahole -J usage in kernel scripts/link-vmlinux.sh Andrii Nakryiko
2021-03-19 23:30 ` Bill Wendling
2021-03-19 23:38 ` Andrii Nakryiko
2021-03-19 23:47 ` Bill Wendling
2021-03-20 17:21 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210317232657.mdnsuoqx6nbddjgt@google.com \
--to=maskray@google.com \
--cc=dwarves@vger.kernel.org \
--cc=morbo@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).