From: Jiri Olsa <jolsa@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: dwarves@vger.kernel.org, bpf@vger.kernel.org,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andriin@fb.com>, Yonghong Song <yhs@fb.com>,
Hao Luo <haoluo@google.com>
Subject: [PATCH] btf_encoder: Move btf_elf__verbose/btf_elf__force setup
Date: Mon, 16 Nov 2020 20:33:48 +0100 [thread overview]
Message-ID: <20201116193348.1222960-1-jolsa@kernel.org> (raw)
With introduction of collect_symbols function, we moved the
percpu variables code before btf_elf__verbose/btf_elf__force
setup, so they don't have any effect in that code anymore.
Also btf_elf__verbose is used in code that prepares ftrace
filter for functions generations, also called within
collect_symbols function.
Moving btf_elf__verbose/btf_elf__force setup early in the
cu__encode_btf function, so we can get verbose messages
and see the effect of the force option.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
btf_encoder.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/btf_encoder.c b/btf_encoder.c
index f3f6291391ee..4f856cfd5577 100644
--- a/btf_encoder.c
+++ b/btf_encoder.c
@@ -540,6 +540,9 @@ int cu__encode_btf(struct cu *cu, int verbose, bool force,
struct tag *pos;
int err = 0;
+ btf_elf__verbose = verbose;
+ btf_elf__force = force;
+
if (btfe && strcmp(btfe->filename, cu->filename)) {
err = btf_encoder__encode();
if (err)
@@ -579,8 +582,6 @@ int cu__encode_btf(struct cu *cu, int verbose, bool force,
}
}
- btf_elf__verbose = verbose;
- btf_elf__force = force;
type_id_off = btf__get_nr_types(btfe->btf);
cu__for_each_type(cu, core_id, pos) {
--
2.26.2
next reply other threads:[~2020-11-16 19:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 19:33 Jiri Olsa [this message]
2020-11-16 19:46 ` [PATCH] btf_encoder: Move btf_elf__verbose/btf_elf__force setup Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116193348.1222960-1-jolsa@kernel.org \
--to=jolsa@kernel.org \
--cc=acme@kernel.org \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=dwarves@vger.kernel.org \
--cc=haoluo@google.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).