From: Sam Ravnborg <sam@ravnborg.org>
To: lichenyang <lichenyang@loongson.cn>
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@linux.ie>,
Huacai Chen <chenhuacai@kernel.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
dri-devel@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
devel@linuxdriverproject.org,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v4 3/3] drm/loongson: Add interrupt driver for LS7A
Date: Sat, 7 Aug 2021 11:56:59 +0200 [thread overview]
Message-ID: <YQ5Y650wDABR5TAV@ravnborg.org> (raw)
In-Reply-To: <20210730094148.620768-3-lichenyang@loongson.cn>
Hi lichenyang,
On Fri, Jul 30, 2021 at 05:41:48PM +0800, lichenyang wrote:
> Add LS7A DC vsync interrupt enable and close function, and
> register irq_handler function interface.
> Add vbrank event processing flow.
s/vbrank/vblank/
>
> v4:
> - Replace drm_irq_install with devm_request_irq.
> - Delete the irq_ hooks in drm_driver.
>
> v3:
> - Improve code readability.
> - Use the to_pci_dev function to get pci_dev.
>
> v2:
> - Added error handling in the loongson_drm_load function.
>
> Signed-off-by: lichenyang <lichenyang@loongson.cn>
Patch looks good,
Acked-by: Sam Ravnborg <sam@ravnborg.org>
But then I am not to fluent in the vblank stuff, so I hope someone else
takes a look too.
Sam
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2021-08-07 9:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 9:41 [PATCH v4 1/3] drm/loongson: Add DRM Driver for Loongson 7A1000 bridge chip lichenyang
2021-07-30 9:41 ` [PATCH v4 2/3] drm/loongson: Add GPIO and I2C driver for loongson drm lichenyang
2021-08-01 20:28 ` Sam Ravnborg
2021-08-07 9:51 ` Sam Ravnborg
2021-07-30 9:41 ` [PATCH v4 3/3] drm/loongson: Add interrupt driver for LS7A lichenyang
2021-08-07 9:56 ` Sam Ravnborg [this message]
2021-08-04 21:12 ` [PATCH v4 1/3] drm/loongson: Add DRM Driver for Loongson 7A1000 bridge chip Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQ5Y650wDABR5TAV@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=chenhuacai@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=daniel@ffwll.ch \
--cc=devel@linuxdriverproject.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=lichenyang@loongson.cn \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).