DriverDev-Devel Archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Benjamin Philip <benjamin.philip495@gmail.com>
Cc: devel mailing list <devel@linuxdriverproject.org>,
	Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH] staging: rtl8188eu: remove unnecessary blank lines in core/rtw_ap.c
Date: Wed, 21 Jul 2021 13:11:53 +0200	[thread overview]
Message-ID: <YPgA+QB82Pjm/76B@kroah.com> (raw)
In-Reply-To: <20210721105808.63735-1-benjamin.philip495@gmail.com>

On Wed, Jul 21, 2021 at 04:28:09PM +0530, Benjamin Philip wrote:
> This commit fixes some checkpatch checks for blank lines before
> and after braces in drivers/staging/rtl8188eu/core/rtw_ap.c
> 
> Signed-off-by: Benjamin Philip <benjamin.philip495@gmail.com>
> ---
> 
> This patch fixes some checkpatch.pl CHECKs for blank lines.
> 
> Note: Since all I have done is remove some empty blank lines, I didn't
> compile and test the driver.

Always test-build your changes, do not force me to do that for you.

Please do that and resend.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2021-07-21 11:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-21 10:58 [PATCH] staging: rtl8188eu: remove unnecessary blank lines in core/rtw_ap.c Benjamin Philip
2021-07-21 11:11 ` Greg Kroah-Hartman [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-07-21 19:45 Benjamin Philip

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPgA+QB82Pjm/76B@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=benjamin.philip495@gmail.com \
    --cc=devel@linuxdriverproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).