From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
Cc: <nouveau@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>, <ttabi@nvidia.com>,
<dakr@redhat.com>, <airlied@redhat.com>, <lyude@redhat.com>,
<bskeggs@nvidia.com>
Subject: Re: [PATCH] nouveau: Add missing break statement
Date: Tue, 30 Apr 2024 08:53:09 -0500 [thread overview]
Message-ID: <faewrlmfd6hjhmidbpa2nmepk2sioudmscozgidkq2u74hivh3@fszn4ilyes6r> (raw)
In-Reply-To: <20240430131840.742924-1-chaitanya.kumar.borah@intel.com>
On Tue, Apr 30, 2024 at 06:48:40PM GMT, Chaitanya Kumar Borah wrote:
>Add the missing break statement that causes the following build error
>
> CC [M] drivers/gpu/drm/i915/display/intel_display_device.o
> ../drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c: In function ‘build_registry’:
> ../drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c:1266:3: error: label at end of compound statement
> 1266 | default:
> | ^~~~~~~
> CC [M] drivers/gpu/drm/amd/amdgpu/gfx_v10_0.o
> HDRTEST drivers/gpu/drm/xe/compat-i915-headers/i915_reg.h
> CC [M] drivers/gpu/drm/amd/amdgpu/imu_v11_0.o
> make[7]: *** [../scripts/Makefile.build:244: drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.o] Error 1
> make[7]: *** Waiting for unfinished jobs....
>
>Fixes: b58a0bc904ff ("nouveau: add command-line GSP-RM registry support")
>Closes: https://lore.kernel.org/all/913052ca6c0988db1bab293cfae38529251b4594.camel@nvidia.com/T/#m3c9acebac754f2e74a85b76c858c093bb1aacaf0
Just found a previous bug report, so we can add here:
Closes: https://lore.kernel.org/all/CA+G9fYu7Ug0K8h9QJT0WbtWh_LL9Juc+VC0WMU_Z_vSSPDNymg@mail.gmail.com/
>Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
>---
> drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c
>index 0b46db5c77b8..63619512e7f6 100644
>--- a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c
>+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c
>@@ -1264,6 +1264,7 @@ static void build_registry(struct nvkm_gsp *gsp, PACKED_REGISTRY_TABLE *registry
> str_offset += reg->vlen;
> break;
> default:
>+ break;
since reg->type is an enum and we are handling all the values, another
possible approach is to remove the default handling and then the
compiler will warn you of missing cases if built with -Wswitch.
Any of the approaches seem good to me.
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Lucas De Marchi
> }
>
> i++;
>--
>2.25.1
>
next prev parent reply other threads:[~2024-04-30 13:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 13:18 [PATCH] nouveau: Add missing break statement Chaitanya Kumar Borah
2024-04-30 13:53 ` Lucas De Marchi [this message]
2024-04-30 14:28 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=faewrlmfd6hjhmidbpa2nmepk2sioudmscozgidkq2u74hivh3@fszn4ilyes6r \
--to=lucas.demarchi@intel.com \
--cc=airlied@redhat.com \
--cc=bskeggs@nvidia.com \
--cc=chaitanya.kumar.borah@intel.com \
--cc=dakr@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=lyude@redhat.com \
--cc=nouveau@lists.freedesktop.org \
--cc=ttabi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).