From: Thomas Zimmermann <tzimmermann@suse.de>
To: Easwar Hariharan <eahariha@linux.microsoft.com>,
Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
Helge Deller <deller@gmx.de>,
"open list:VIA UNICHROME(PRO)/CHROME9 FRAMEBUFFER DRIVER"
<linux-fbdev@vger.kernel.org>,
"open list:FRAMEBUFFER LAYER" <dri-devel@lists.freedesktop.org>,
open list <linux-kernel@vger.kernel.org>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
"open list:RADEON and AMDGPU DRM DRIVERS"
<amd-gfx@lists.freedesktop.org>,
"open list:INTEL DRM DISPLAY FOR XE AND I915 DRIVERS"
<intel-gfx@lists.freedesktop.org>,
"open list:INTEL DRM DISPLAY FOR XE AND I915 DRIVERS"
<intel-xe@lists.freedesktop.org>,
"open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS"
<nouveau@lists.freedesktop.org>,
"open list:I2C SUBSYSTEM HOST DRIVERS"
<linux-i2c@vger.kernel.org>,
"open list:BTTV VIDEO4LINUX DRIVER" <linux-media@vger.kernel.org>
Subject: Re: [PATCH v1 12/12] fbdev/viafb: Make I2C terminology more inclusive
Date: Fri, 3 May 2024 09:39:35 +0200 [thread overview]
Message-ID: <f1eccd9d-885f-4508-9325-3454ecc35eae@suse.de> (raw)
In-Reply-To: <076e0a0d-ad26-490e-9784-300ed52637ca@linux.microsoft.com>
Hi
Am 03.05.24 um 00:26 schrieb Easwar Hariharan:
> On 5/2/2024 3:46 AM, Thomas Zimmermann wrote:
>>
>> Am 30.04.24 um 19:38 schrieb Easwar Hariharan:
>>> I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave"
>>> with more appropriate terms. Inspired by and following on to Wolfram's
>>> series to fix drivers/i2c/[1], fix the terminology for users of
>>> I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists
>>> in the specification.
>>>
>>> Compile tested, no functionality changes intended
>>>
>>> [1]: https://lore.kernel.org/all/20240322132619.6389-1-wsa+renesas@sang-engineering.com/
>>>
>>> Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com>
>> Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
>>
> Thanks for the ack! I had been addressing feedback as I got it on the v0 series, and it seems
> I missed out on updating viafb and smscufx to spec-compliant controller/target terminology like
> the v0->v1 changelog calls out before posting v1.
>
> For smscufx, I feel phrasing the following line (as an example)
>
>> -/* sets up I2C Controller for 100 Kbps, std. speed, 7-bit addr, host,
>> +/* sets up I2C Controller for 100 Kbps, std. speed, 7-bit addr, *controller*,
> would actually impact readability negatively, so I propose to leave smscufx as is.
Why? I don't see much of a difference.
>
> For viafb, I propose making it compliant with the spec using the controller/target terminology and
> posting a v2 respin (which I can send out as soon as you say) and ask you to review again.
>
> What do you think?
I think we should adopt the spec's language everywhere. That makes it
possible to grep the spec for terms used in the source code. Using
'host' in smscufx appears to introduce yet another term. If you are
worried about using 'I2C controller' and 'controller' in the same
sentence, you can replace 'I2C controller' with 'DDC channel'. That's
even more precise about the purpose of this code.
Best regards
Thomas
>
> Thanks,
> Easwar
>
>>> ---
>>> drivers/video/fbdev/via/chip.h | 8 ++++----
>>> drivers/video/fbdev/via/dvi.c | 24 ++++++++++++------------
>>> drivers/video/fbdev/via/lcd.c | 6 +++---
>>> drivers/video/fbdev/via/via_aux.h | 2 +-
>>> drivers/video/fbdev/via/via_i2c.c | 12 ++++++------
>>> drivers/video/fbdev/via/vt1636.c | 6 +++---
>>> 6 files changed, 29 insertions(+), 29 deletions(-)
>>>
> <snip>
>
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
next prev parent reply other threads:[~2024-05-03 7:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 17:37 [PATCH v1 00/12] Make I2C terminology more inclusive for I2C Algobit and consumers Easwar Hariharan
2024-04-30 17:38 ` [PATCH v1 01/12] drm/amdgpu, drm/radeon: Make I2C terminology more inclusive Easwar Hariharan
2024-04-30 17:38 ` [PATCH v1 02/12] drm/gma500: " Easwar Hariharan
2024-05-02 10:45 ` Thomas Zimmermann
2024-04-30 17:38 ` [PATCH v1 03/12] drm/i915: " Easwar Hariharan
2024-04-30 20:29 ` Rodrigo Vivi
2024-04-30 21:40 ` Easwar Hariharan
2024-05-03 7:23 ` Zhi Wang
2024-04-30 17:38 ` [PATCH v1 04/12] media: au0828: " Easwar Hariharan
2024-04-30 17:38 ` [PATCH v1 05/12] media: cobalt: " Easwar Hariharan
2024-04-30 17:38 ` [PATCH v1 06/12] media: cx18: " Easwar Hariharan
2024-04-30 17:38 ` [PATCH v1 07/12] media: cx25821: " Easwar Hariharan
2024-04-30 17:38 ` [PATCH v1 08/12] media: ivtv: " Easwar Hariharan
2024-04-30 17:38 ` [PATCH v1 09/12] media: cx23885: " Easwar Hariharan
2024-04-30 17:38 ` [PATCH v1 10/12] sfc: falcon: " Easwar Hariharan
2024-05-03 22:13 ` Jakub Kicinski
2024-05-06 15:54 ` Easwar Hariharan
2024-04-30 17:38 ` [PATCH v1 11/12] fbdev/smscufx: " Easwar Hariharan
2024-05-02 10:45 ` Thomas Zimmermann
2024-04-30 17:38 ` [PATCH v1 12/12] fbdev/viafb: " Easwar Hariharan
2024-05-02 10:46 ` Thomas Zimmermann
2024-05-02 22:26 ` Easwar Hariharan
2024-05-03 7:39 ` Thomas Zimmermann [this message]
2024-05-03 16:48 ` Easwar Hariharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1eccd9d-885f-4508-9325-3454ecc35eae@suse.de \
--to=tzimmermann@suse.de \
--cc=FlorianSchandinat@gmx.de \
--cc=amd-gfx@lists.freedesktop.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=eahariha@linux.microsoft.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).