From: Markus Elfring <Markus.Elfring@web.de>
To: "Dan Carpenter" <dan.carpenter@linaro.org>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
kernel-janitors@vger.kernel.org,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"David Airlie" <airlied@gmail.com>,
"Evan Quan" <evan.quan@amd.com>,
"Jesse Zhang" <jesse.zhang@amd.com>,
"Lijo Lazar" <lijo.lazar@amd.com>, "Ma Jun" <Jun.Ma2@amd.com>,
"Tim Huang" <Tim.Huang@amd.com>,
"Xinhui Pan" <Xinhui.Pan@amd.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Ruan Jinjie <ruanjinjie@huawei.com>
Subject: Re: [PATCH] drm/amd/pm: Fix error code in vega10_hwmgr_backend_init()
Date: Sat, 4 May 2024 19:13:32 +0200 [thread overview]
Message-ID: <d56a6e3f-1371-4bb7-8947-1c2468e4d677@web.de> (raw)
In-Reply-To: <502fda28-fde7-4851-b17f-4d48848955bc@moroto.mountain>
> Return -EINVAL on error instead of success. Also on the success path,
> return a literal zero instead of "return result;"
How do you think about to omit the initialisation for the variable “result”
in another update step?
Regards,
Markus
prev parent reply other threads:[~2024-05-04 17:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-04 11:26 [PATCH] drm/amd/pm: Fix error code in vega10_hwmgr_backend_init() Dan Carpenter
2024-05-04 17:13 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d56a6e3f-1371-4bb7-8947-1c2468e4d677@web.de \
--to=markus.elfring@web.de \
--cc=Jun.Ma2@amd.com \
--cc=Tim.Huang@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dan.carpenter@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=evan.quan@amd.com \
--cc=jesse.zhang@amd.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lijo.lazar@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ruanjinjie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).