From: Liviu Dudau <liviu.dudau@arm.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: dri-devel@lists.freedesktop.org,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 1/1] drm: arm: display: komeda: komeda_crtc: use 'time_left' variable with wait_for_completion_timeout()
Date: Fri, 3 May 2024 12:55:44 +0100 [thread overview]
Message-ID: <ZjTQwBoCei02Bzp_@e110455-lin.cambridge.arm.com> (raw)
In-Reply-To: <20240502210252.11617-2-wsa+renesas@sang-engineering.com>
On Thu, May 02, 2024 at 11:02:53PM +0200, Wolfram Sang wrote:
> There is a confusing pattern in the kernel to use a variable named 'timeout' to
> store the result of wait_for_completion_timeout() causing patterns like:
>
> timeout = wait_for_completion_timeout(...)
> if (!timeout) return -ETIMEDOUT;
>
> with all kinds of permutations. Use 'time_left' as a variable to make the code
> self explaining.
>
> Fix to the proper variable type 'unsigned long' while here.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c b/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c
> index 2c661f28410e..c867acb737d6 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c
> @@ -294,7 +294,7 @@ komeda_crtc_flush_and_wait_for_flip_done(struct komeda_crtc *kcrtc,
> struct komeda_dev *mdev = kcrtc->master->mdev;
> struct completion *flip_done;
> struct completion temp;
> - int timeout;
> + unsigned long time_left;
>
> /* if caller doesn't send a flip_done, use a private flip_done */
> if (input_flip_done) {
> @@ -308,8 +308,8 @@ komeda_crtc_flush_and_wait_for_flip_done(struct komeda_crtc *kcrtc,
> mdev->funcs->flush(mdev, kcrtc->master->id, 0);
>
> /* wait the flip take affect.*/
> - timeout = wait_for_completion_timeout(flip_done, HZ);
> - if (timeout == 0) {
> + time_left = wait_for_completion_timeout(flip_done, HZ);
> + if (time_left == 0) {
Honestly, if the name of the variable is confusing I would get rid of it completely. Can you
send a patch that removes the timeout variable and here just does:
if (wait_for_completion_timeout(flip_done, HZ) == 0) {
Thanks,
Liviu
> DRM_ERROR("wait pipe%d flip done timeout\n", kcrtc->master->id);
> if (!input_flip_done) {
> unsigned long flags;
> --
> 2.43.0
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
next prev parent reply other threads:[~2024-05-03 11:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 21:02 [PATCH 1/1] drm: arm: display: komeda: komeda_crtc: use 'time_left' variable with wait_for_completion_timeout() Wolfram Sang
2024-05-03 11:55 ` Liviu Dudau [this message]
2024-05-05 13:25 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjTQwBoCei02Bzp_@e110455-lin.cambridge.arm.com \
--to=liviu.dudau@arm.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).