From: Marius Vlad <marius.vlad@collabora.com>
To: Brandon Pollack <brpol@chromium.org>
Cc: hamohammed.sa@gmail.com, rodrigosiqueiramelo@gmail.com,
linux-doc@vger.kernel.org, hirono@chromium.org,
mduggan@chromium.org, corbet@lwn.net,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
melissa.srw@gmail.com, mairacanal@riseup.net, mripard@kernel.org,
tzimmermann@suse.de, jshargo@chromium.org
Subject: Re: [PATCH v6 0/7] Adds support for ConfigFS to VKMS!
Date: Fri, 1 Sep 2023 12:32:10 +0300 [thread overview]
Message-ID: <ZPGvmpExLxwmfFBB@xpredator> (raw)
In-Reply-To: <20230829053201.423261-1-brpol@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 3665 bytes --]
Hi Brandon,
You can now add https://lists.freedesktop.org/archives/igt-dev/2023-September/060717.html
as part of this series.
On Tue, Aug 29, 2023 at 05:30:52AM +0000, Brandon Pollack wrote:
> Since Jim is busy with other work and I'm working on some things that
> rely on this, I've taken up the task of doing the iterations. I've
> addressed the comments as best I can (those replies are to each
> individual change) and here is the patch set to go with those.
>
> I added my own signoff to each commit, but I've left jshargo@ as the
> author of all the commits he wrote. I'm sure there is still more to
> address and the ICT tests that were writtein parallel to this may also
> need some additions, but I'm hoping we're in a good enough state to get
> this in and iterate from there soon.
>
> Since V6:
> ========
> rmdirs for documentation examples
> fix crtc mask for writebacks
>
> Since V5:
> ========
> Fixed some bad merge conflicts and locking behaviours as well as
> clarified some documentation, should be good to go now :)
>
> Since V4:
> ========
> Fixed up some documentation as suggested by Marius
> Fixed up some bad locking as suggested by Marius
> Small fixes here and there (most have email responses to previous chain
> emails)
>
> Since V3:
> ========
> I've added hotplug support in the latest patch. This has been reviewed some
> and the notes from that review are addressed here as well.
>
> Relevant/Utilizing work:
> =======================
> I've built a while test framework based on this as proof it functions (though
> I'm sure there may be lingering bugs!). You can check that out on
> crrev.com if you are interested and need to get started yourself (but be
> aware of any licensing that may differ from the kernel itself! Make
> sure you understand the license:
>
> https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/platform/tast-tests/LICENSE
>
> That said, you can see the changes in review on the crrev gerrit:
>
> https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/4666669
>
> Outro:
> =====
> I really appreciate everyone's input and tolerance in getting these
> changes in. Jim's first patch series was this, and other than some
> small cleanups and documentation, taking over it is also mine.
>
> Thank you everyone :)
>
> Brandon Pollack (1):
> drm/vkms Add hotplug support via configfs to VKMS.
>
> Jim Shargo (6):
> drm/vkms: Back VKMS with DRM memory management instead of static
> objects
> drm/vkms: Support multiple DRM objects (crtcs, etc.) per VKMS device
> drm/vkms: Provide platform data when creating VKMS devices
> drm/vkms: Add ConfigFS scaffolding to VKMS
> drm/vkms: Support enabling ConfigFS devices
> drm/vkms: Add a module param to enable/disable the default device
>
> Documentation/gpu/vkms.rst | 20 +-
> drivers/gpu/drm/Kconfig | 1 +
> drivers/gpu/drm/vkms/Makefile | 1 +
> drivers/gpu/drm/vkms/vkms_composer.c | 30 +-
> drivers/gpu/drm/vkms/vkms_configfs.c | 723 ++++++++++++++++++++++++++
> drivers/gpu/drm/vkms/vkms_crtc.c | 102 ++--
> drivers/gpu/drm/vkms/vkms_drv.c | 206 +++++---
> drivers/gpu/drm/vkms/vkms_drv.h | 182 +++++--
> drivers/gpu/drm/vkms/vkms_output.c | 404 ++++++++++++--
> drivers/gpu/drm/vkms/vkms_plane.c | 44 +-
> drivers/gpu/drm/vkms/vkms_writeback.c | 42 +-
> 11 files changed, 1514 insertions(+), 241 deletions(-)
> create mode 100644 drivers/gpu/drm/vkms/vkms_configfs.c
>
> --
> 2.42.0.rc2.253.gd59a3bf2b4-goog
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-09-01 9:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 5:30 [PATCH v6 0/7] Adds support for ConfigFS to VKMS! Brandon Pollack
2023-08-29 5:30 ` [PATCH v6 1/7] drm/vkms: Back VKMS with DRM memory management instead of static objects Brandon Pollack
2024-04-30 7:47 ` Daniel Vetter
2023-08-29 5:30 ` [PATCH v6 2/7] drm/vkms: Support multiple DRM objects (crtcs, etc.) per VKMS device Brandon Pollack
2023-09-01 9:33 ` Marius Vlad
2024-04-30 7:53 ` Daniel Vetter
2023-08-29 5:30 ` [PATCH v6 3/7] drm/vkms: Provide platform data when creating VKMS devices Brandon Pollack
2024-04-30 7:53 ` Daniel Vetter
2023-08-29 5:30 ` [PATCH v6 4/7] drm/vkms: Add ConfigFS scaffolding to VKMS Brandon Pollack
2024-04-30 8:14 ` Daniel Vetter
2023-08-29 5:30 ` [PATCH v6 5/7] drm/vkms: Support enabling ConfigFS devices Brandon Pollack
2024-04-30 8:22 ` Daniel Vetter
2024-04-30 8:32 ` Daniel Vetter
2023-08-29 5:30 ` [PATCH v6 6/7] drm/vkms: Add a module param to enable/disable the default device Brandon Pollack
2023-08-29 5:30 ` [PATCH v6 7/7] drm/vkms Add hotplug support via configfs to VKMS Brandon Pollack
2023-09-20 18:03 ` Helen Koike
2023-09-21 3:44 ` Brandon Ross Pollack
2024-04-30 8:27 ` Daniel Vetter
2023-09-01 9:32 ` Marius Vlad [this message]
2024-04-30 8:36 ` [PATCH v6 0/7] Adds support for ConfigFS to VKMS! Daniel Vetter
2024-05-08 18:17 ` José Expósito
2024-05-09 22:18 ` Jim Shargo
2024-05-10 16:19 ` Louis Chauvet
2024-05-13 8:08 ` José Expósito
2024-05-13 9:03 ` Marius Vlad
2024-05-13 16:23 ` José Expósito
2024-05-17 16:00 ` Louis Chauvet
2024-05-21 12:25 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPGvmpExLxwmfFBB@xpredator \
--to=marius.vlad@collabora.com \
--cc=brpol@chromium.org \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=hamohammed.sa@gmail.com \
--cc=hirono@chromium.org \
--cc=jshargo@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mairacanal@riseup.net \
--cc=mduggan@chromium.org \
--cc=melissa.srw@gmail.com \
--cc=mripard@kernel.org \
--cc=rodrigosiqueiramelo@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).