From: "Lisovskiy, Stanislav" <stanislav.lisovskiy@intel.com>
To: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [1/2] drm/display/dp: Assume 8 bpc support when DSC is supported
Date: Wed, 30 Aug 2023 10:51:41 +0300 [thread overview]
Message-ID: <ZO71Dbu1NvY8qYup@intel.com> (raw)
In-Reply-To: <20230824125121.840298-2-ankit.k.nautiyal@intel.com>
On Thu, Aug 24, 2023 at 06:21:20PM +0530, Ankit Nautiyal wrote:
> As per DP v1.4, a DP DSC Sink device shall support 8bpc in DPCD 6Ah.
> Apparently some panels that do support DSC, are not setting the bit for
> 8bpc.
>
> So always assume 8bpc support by DSC decoder, when DSC is claimed to be
> supported.
>
> v2: Use helper to get check dsc support. (Ankit)
> v3: Fix styling and other typos. (Jani)
>
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Reviewed-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> ---
> drivers/gpu/drm/display/drm_dp_helper.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c
> index e6a78fd32380..8a1b64c57dfd 100644
> --- a/drivers/gpu/drm/display/drm_dp_helper.c
> +++ b/drivers/gpu/drm/display/drm_dp_helper.c
> @@ -2449,12 +2449,16 @@ int drm_dp_dsc_sink_supported_input_bpcs(const u8 dsc_dpcd[DP_DSC_RECEIVER_CAP_S
> int num_bpc = 0;
> u8 color_depth = dsc_dpcd[DP_DSC_DEC_COLOR_DEPTH_CAP - DP_DSC_SUPPORT];
>
> + if (!drm_dp_sink_supports_dsc(dsc_dpcd))
> + return 0;
> +
> if (color_depth & DP_DSC_12_BPC)
> dsc_bpc[num_bpc++] = 12;
> if (color_depth & DP_DSC_10_BPC)
> dsc_bpc[num_bpc++] = 10;
> - if (color_depth & DP_DSC_8_BPC)
> - dsc_bpc[num_bpc++] = 8;
> +
> + /* A DP DSC Sink device shall support 8 bpc. */
> + dsc_bpc[num_bpc++] = 8;
>
> return num_bpc;
> }
next prev parent reply other threads:[~2023-08-30 7:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 12:51 [PATCH 0/2] eDP DSC fixes Ankit Nautiyal
2023-08-24 12:51 ` [PATCH 1/2] drm/display/dp: Assume 8 bpc support when DSC is supported Ankit Nautiyal
2023-08-29 8:44 ` [Intel-gfx] " Jani Nikula
2023-08-29 9:01 ` Maxime Ripard
2023-08-30 7:51 ` Lisovskiy, Stanislav [this message]
2023-08-30 12:00 ` [Intel-gfx] [1/2] " Jani Nikula
2023-08-24 12:51 ` [PATCH 2/2] drivers/drm/i915: Honor limits->max_bpp while computing DSC max input bpp Ankit Nautiyal
2023-08-30 12:02 ` [Intel-gfx] " Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZO71Dbu1NvY8qYup@intel.com \
--to=stanislav.lisovskiy@intel.com \
--cc=ankit.k.nautiyal@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).