From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: amd-gfx@lists.freedesktop.org, sunpeng.li@amd.com,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, airlied@linux.ie,
Werner Sembach <wse@tuxedocomputers.com>,
tzimmermann@suse.de, rodrigo.vivi@intel.com,
alexander.deucher@amd.com, christian.koenig@amd.com
Subject: Re: [PATCH v2 4/7] drm/i915/display: Add handling for new "active bpc" property
Date: Thu, 10 Jun 2021 16:59:05 +0300 [thread overview]
Message-ID: <YMIaqZnWTAiixwXJ@intel.com> (raw)
In-Reply-To: <20210610125036.33fpnaoz4xpiqslw@gilmour>
On Thu, Jun 10, 2021 at 02:50:36PM +0200, Maxime Ripard wrote:
> Hi
>
> On Tue, Jun 08, 2021 at 07:43:17PM +0200, Werner Sembach wrote:
> > This commits implements the "active bpc" drm property for the Intel GPU driver.
> >
> > Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_display.c | 14 ++++++++++++++
> > drivers/gpu/drm/i915/display/intel_dp.c | 8 ++++++--
> > drivers/gpu/drm/i915/display/intel_dp_mst.c | 4 +++-
> > drivers/gpu/drm/i915/display/intel_hdmi.c | 4 +++-
> > 4 files changed, 26 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> > index 64e9107d70f7..50c11b8770a7 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > @@ -10388,6 +10388,9 @@ static int intel_atomic_commit(struct drm_device *dev,
> > {
> > struct intel_atomic_state *state = to_intel_atomic_state(_state);
> > struct drm_i915_private *dev_priv = to_i915(dev);
> > + struct drm_connector *connector;
> > + struct drm_connector_state *new_conn_state;
> > + int i;
> > int ret = 0;
> >
> > state->wakeref = intel_runtime_pm_get(&dev_priv->runtime_pm);
> > @@ -10456,6 +10459,17 @@ static int intel_atomic_commit(struct drm_device *dev,
> > intel_shared_dpll_swap_state(state);
> > intel_atomic_track_fbs(state);
> >
> > + /* Extract information from crtc to communicate it to userspace as connector properties */
> > + for_each_new_connector_in_state(&state->base, connector, new_conn_state, i) {
> > + struct intel_crtc *crtc = to_intel_crtc(new_conn_state->crtc);
> > + if (crtc) {
> > + struct intel_crtc_state *new_crtc_state = intel_atomic_get_new_crtc_state(state, crtc);
> > + new_conn_state->active_bpc = new_crtc_state->pipe_bpp / 3;
> > + }
> > + else
> > + new_conn_state->active_bpc = 0;
> > + }
> > +
>
> This seems fairly intrusive, but also commit / commit_tail might not be
> the best place to put this, we want to support it at the connector
> level.
>
> Indeed, this will cause some issue if your HDMI output is a bridge for
> example, where the commit will be in an entirely different driver that
> has no dependency on the HDMI controller one.
>
> I think it would be best to do that assignment in atomic_check. That
> way, if the userspace does a commit with DRM_MODE_ATOMIC_TEST_ONLY it
> would know what the output state would have been like.
DRM_MODE_ATOMIC_TEST_ONLY isn't allowed to change anything.
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2021-06-10 13:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 17:43 [PATCH 0/7] Add "activ bpc" and "active color format" drm property Werner Sembach
2021-06-08 17:43 ` [PATCH v2 1/7] drm/amd/display: Add missing cases convert_dc_color_depth_into_bpc Werner Sembach
2021-06-08 17:43 ` [PATCH v2 2/7] drm/uAPI: Add "active bpc" as feedback channel for "max bpc" drm property Werner Sembach
2021-06-10 7:55 ` Pekka Paalanen
2021-06-14 15:59 ` Mario Kleiner
2021-06-08 17:43 ` [PATCH v2 3/7] drm/amd/display: Add handling for new "active bpc" property Werner Sembach
2021-06-08 17:43 ` [PATCH v2 4/7] drm/i915/display: " Werner Sembach
2021-06-10 12:50 ` Maxime Ripard
2021-06-10 13:59 ` Ville Syrjälä [this message]
2021-06-08 17:43 ` [PATCH v2 5/7] drm/uAPI: Add "active color format" drm property as feedback for userspace Werner Sembach
2021-06-10 8:11 ` Pekka Paalanen
2021-06-08 17:43 ` [PATCH v2 6/7] drm/amd/display: Add handling for new "active color format" property Werner Sembach
2021-06-08 17:43 ` [PATCH v2 7/7] drm/i915/display: " Werner Sembach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMIaqZnWTAiixwXJ@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=rodrigo.vivi@intel.com \
--cc=sunpeng.li@amd.com \
--cc=tzimmermann@suse.de \
--cc=wse@tuxedocomputers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).