From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Douglas Anderson <dianders@chromium.org>,
Maxime Ripard <mripard@kernel.org>,
linux-renesas-soc@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: renesas: shmobile: Call drm_helper_force_disable_all() at shutdown time
Date: Tue, 5 Dec 2023 14:31:24 +0100 [thread overview]
Message-ID: <CAMuHMdWziG0T6XdtcyvLz2si7Ai6sQN0tDU1345nSouz2tUq8A@mail.gmail.com> (raw)
In-Reply-To: <20231205121617.GF17394@pendragon.ideasonboard.com>
Hi Laurent,
On Tue, Dec 5, 2023 at 1:16 PM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Tue, Dec 05, 2023 at 12:30:02PM +0100, Geert Uytterhoeven wrote:
> > From: Douglas Anderson <dianders@chromium.org>
> >
> > Based on grepping through the source code, this driver appears to be
> > missing a call to drm_atomic_helper_shutdown() at system shutdown time.
> > This is important because drm_helper_force_disable_all() will cause
> > panels to get disabled cleanly which may be important for their power
> > sequencing. Future changes will remove any custom powering off in
> > individual panel drivers so the DRM drivers need to start getting this
> > right.
> >
> > The fact that we should call drm_atomic_helper_shutdown() in the case of
> > OS shutdown comes straight out of the kernel doc "driver instance
> > overview" in drm_drv.c.
> >
> > Suggested-by: Maxime Ripard <mripard@kernel.org>
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> > Link: https://lore.kernel.org/r/20230901164111.RFT.15.Iaf638a1d4c8b3c307a6192efabb4cbb06b195f15@changeid
> > [geert: s/drm_helper_force_disable_all/drm_atomic_helper_shutdown/]
> > [geert: shmob_drm_remove() already calls drm_atomic_helper_shutdown]
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Thanks!
> > Panel-simple does print two new warnings:
> >
> > +panel-simple panel: Skipping disable of already disabled panel
> > +panel-simple panel: Skipping unprepare of already unprepared panel
>
> Have you investigated where this comes from ?
Meh, I knew I forgot something ;-)
The panel is unprepared and disabled a first time from shmob_drm's
.shutdown() callback:
shmob_drm_shutdown
drm_atomic_helper_shutdown
drm_atomic_helper_disable_all
drm_atomic_commit
drm_atomic_helper_commit
commit_tail
drm_atomic_helper_commit_tail
drm_atomic_helper_commit_modeset_disables
disable_outputs
drm_atomic_bridge_chain_disable
drm_panel_disable
drm_atomic_bridge_chain_post_disable
drm_panel_unprepare
And a second time from simple_panel's .shutdown() callback():
panel_simple_platform_shutdown
panel_simple_shutdown
drm_panel_disable
drm_panel_unprepare
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2023-12-05 13:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 11:30 [PATCH] drm: renesas: shmobile: Call drm_helper_force_disable_all() at shutdown time Geert Uytterhoeven
2023-12-05 12:16 ` Laurent Pinchart
2023-12-05 13:31 ` Geert Uytterhoeven [this message]
2023-12-05 13:40 ` Laurent Pinchart
2023-12-05 17:35 ` Doug Anderson
2024-05-03 23:11 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdWziG0T6XdtcyvLz2si7Ai6sQN0tDU1345nSouz2tUq8A@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mripard@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).