From: cong yang <yangcong5@huaqin.corp-partner.google.com>
To: Doug Anderson <dianders@chromium.org>
Cc: sam@ravnborg.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linus.walleij@linaro.org,
xuxinxiong@huaqin.corp-partner.google.com, airlied@gmail.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
devicetree@vger.kernel.org, conor+dt@kernel.org,
daniel@ffwll.ch, neil.armstrong@linaro.org,
"Rob Herring (Arm)" <robh@kernel.org>
Subject: Re: [PATCH v4 1/7] dt-bindings: display: panel: Add himax hx83102 panel bindings
Date: Wed, 8 May 2024 19:43:35 +0800 [thread overview]
Message-ID: <CAHwB_NLhKqqy-Ot=HjiG2oZ6MraYvvMaV_=r60=1yR4164FeaA@mail.gmail.com> (raw)
In-Reply-To: <CAD=FV=VNNB=jtyM1BMTUTzyTjOUqDxobWTYz9RAnCmYha-DG0w@mail.gmail.com>
Hi, Doug &Conor
Doug Anderson <dianders@chromium.org> 于2024年5月8日周三 00:40写道：
>
> Hi,
>
> On Tue, May 7, 2024 at 8:14 AM Rob Herring (Arm) <robh@kernel.org> wrote:
> >
> >
> > On Tue, 07 May 2024 21:52:28 +0800, Cong Yang wrote:
> > > In V1, discussed with Doug and Linus [1], we need break out as separate
> > > driver for the himax83102-j02 controller. Beacuse "starry,himax83102-j02"
> > > and in this series "BOE nv110wum-l60" "IVO t109nw41" panels use same
> > > controller, they have some common CMDS. So add new documentation for
> > > this panels.
> > >
> > > For himax83102-j02 controller, no need 3v3 supply, so remove it.
> > >
> > > [1]: https://lore.kernel.org/all/CACRpkdbzYZAS0=zBQJUC4CB2wj4s1h6n6aSAZQvdMV95r3zRUw@mail.gmail.com
> > >
> > > Signed-off-by: Cong Yang <yangcong5@huaqin.corp-partner.google.com>
> > > ---
> > > Chage since V4:
> > >
> > > - Update commit message and add fallback compatible.
> > >
> > > V3: https://lore.kernel.org/all/20240424023010.2099949-2-yangcong5@huaqin.corp-partner.google.com
> > >
> > > Chage since V3:
> > >
> > > - Update commit message.
> > >
> > > V2: https://lore.kernel.org/all/20240422090310.3311429-2-yangcong5@huaqin.corp-partner.google.com
> > >
> > > ---
> > > .../display/panel/boe,tv101wum-nl6.yaml | 2 -
> > > .../bindings/display/panel/himax,hx83102.yaml | 73 +++++++++++++++++++
> > > 2 files changed, 73 insertions(+), 2 deletions(-)
> > > create mode 100644 Documentation/devicetree/bindings/display/panel/himax,hx83102.yaml
> > >
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/himax,hx83102.example.dtb: panel@0: compatible:0: 'starry,himax83102-j02, himax,hx83102' does not match '^[a-zA-Z0-9][a-zA-Z0-9,+\\-._/]+$'
> > from schema $id: http://devicetree.org/schemas/dt-core.yaml#
> > Documentation/devicetree/bindings/display/panel/himax,hx83102.example.dtb: /example-0/dsi/panel@0: failed to match any schema with compatible: ['starry,himax83102-j02, himax,hx83102']
> >
> > doc reference errors (make refcheckdocs):
> >
> > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240507135234.1356855-2-yangcong5@huaqin.corp-partner.google.com
> >
> > The base for the series is generally the latest rc1. A different dependency
> > should be noted in *this* patch.
> >
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure 'yamllint' is installed and dt-schema is up to
> > date:
> >
> > pip3 install dtschema --upgrade
> >
> > Please check and re-submit after running the above command yourself. Note
> > that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> > your schema. However, it must be unset to test all examples with your schema.
>
> I think several of your bindings patches have triggered Rob's bot.
> Please make sure you're set up to test this yourself and make sure you
> run it locally before sending out the next version of your patches. In
> general you should get in the habit of running 'make dt_binding_check'
> locally before you post any bindings changes.
Sorry, I forgot to running 'make dt_binding_check'.
Thanks for the correction.
>
> Thanks!
>
> -Doug
next prev parent reply other threads:[~2024-05-08 11:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 13:52 [PATCH v4 0/7] Break out as separate driver and add BOE nv110wum-l60 IVO t109nw41 MIPI-DSI panel Cong Yang
2024-05-07 13:52 ` [PATCH v4 1/7] dt-bindings: display: panel: Add himax hx83102 panel bindings Cong Yang
2024-05-07 15:14 ` Rob Herring (Arm)
2024-05-07 16:32 ` Doug Anderson
2024-05-08 11:43 ` cong yang [this message]
2024-05-07 16:35 ` Conor Dooley
2024-05-07 13:52 ` [PATCH v4 2/7] drm/panel: himax-hx83102: Break out as separate driver Cong Yang
2024-05-07 23:35 ` Doug Anderson
2024-05-08 11:51 ` cong yang
2024-05-08 17:24 ` Doug Anderson
2024-05-07 13:52 ` [PATCH v4 3/7] arm64: defconfig: Enable HIMAX_HX83102 panel Cong Yang
2024-05-07 13:52 ` [PATCH v4 4/7] dt-bindings: display: panel: Add compatible for BOE nv110wum-l60 Cong Yang
2024-05-07 16:33 ` Conor Dooley
2024-05-07 13:52 ` [PATCH v4 5/7] drm/panel: himax-hx83102: Support for BOE nv110wum-l60 MIPI-DSI panel Cong Yang
2024-05-07 23:35 ` Doug Anderson
2024-05-08 11:55 ` cong yang
2024-05-07 13:52 ` [PATCH v4 6/7] dt-bindings: display: panel: Add compatible for IVO t109nw41 Cong Yang
2024-05-07 16:33 ` Conor Dooley
2024-05-07 13:52 ` [PATCH v4 7/7] drm/panel: himax-hx83102: Support for IVO t109nw41 MIPI-DSI panel Cong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHwB_NLhKqqy-Ot=HjiG2oZ6MraYvvMaV_=r60=1yR4164FeaA@mail.gmail.com' \
--to=yangcong5@huaqin.corp-partner.google.com \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=xuxinxiong@huaqin.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).