From: Shresth Prasad <shresthprasad7@gmail.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
R Sundar <prosunofficial@gmail.com>, Lee Jones <lee@kernel.org>,
Jingoo Han <jingoohan1@gmail.com>, Helge Deller <deller@gmx.de>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
javier.carrasco.cruz@gmail.com
Subject: Re: [PATCH] backlight: sky81452-backlight: replace of_node_put with __free
Date: Thu, 2 May 2024 11:49:54 +0530 [thread overview]
Message-ID: <CAE8VWiLZvmeMdR5rsJ7vugXPyW6ABMZZwPRhJ=iU-KXqOJZ77w@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2405011618351.3278@hadrien>
I'll remove the unnecessary braces and resend the patch.
Regards,
Shresth
On Wed, May 1, 2024 at 7:49 PM Julia Lawall <julia.lawall@inria.fr> wrote:
>
>
>
> On Wed, 1 May 2024, Daniel Thompson wrote:
>
> > On Wed, May 01, 2024 at 06:21:46PM +0530, R Sundar wrote:
> > > Use the new cleanup magic to replace of_node_put() with
> > > __free(device_node) marking to auto release when they get out of scope.
> > >
> > > Suggested-by: Julia Lawall <julia.lawall@inria.fr>
> > > Signed-off-by: R Sundar <prosunofficial@gmail.com>
> >
> > Thanks for the patch but I think this one is a more appropriate
> > solution to this issue:
> > https://lore.kernel.org/all/20240421104916.312588-2-shresthprasad7@gmail.com/
>
> Maybe neither one is perfect? The one I see at that link has:
>
> if (!pdata) {
> - of_node_put(np);
> return ERR_PTR(-ENOMEM);
> }
>
> which has unneeded {}
>
> julia
>
>
> >
> >
> > Daniel.
> >
prev parent reply other threads:[~2024-05-02 6:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 12:51 [PATCH] backlight: sky81452-backlight: replace of_node_put with __free R Sundar
2024-05-01 14:01 ` Daniel Thompson
2024-05-01 14:19 ` Julia Lawall
2024-05-02 6:19 ` Shresth Prasad [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE8VWiLZvmeMdR5rsJ7vugXPyW6ABMZZwPRhJ=iU-KXqOJZ77w@mail.gmail.com' \
--to=shresthprasad7@gmail.com \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=julia.lawall@inria.fr \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prosunofficial@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).