From: "Heiko Stübner" <heiko@sntech.de>
To: Quentin Schulz <quentin.schulz@cherry.de>
Cc: hjc@rock-chips.com, andy.yan@rock-chips.com,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Heiko Stuebner <heiko.stuebner@cherry.de>
Subject: Re: [PATCH 2/2] drm/rockchip: vop2: configure layers for vp3 on rk3588
Date: Fri, 03 May 2024 15:02:01 +0200 [thread overview]
Message-ID: <9626238.rMLUfLXkoz@diego> (raw)
In-Reply-To: <062d86ab-1518-4160-870c-3cd36228d055@cherry.de>
Am Freitag, 3. Mai 2024, 14:57:03 CEST schrieb Quentin Schulz:
> Hi Heiko,
>
> On 4/25/24 9:55 PM, Heiko Stuebner wrote:
> > From: Heiko Stuebner <heiko.stuebner@cherry.de>
> >
> > The rk3588 VOP2 has 4 video-ports, yet the driver currently only
> > configures the first 3, as used on the rk3568.
> >
>
> I'm wondering whether we should update the drawing at the top of the
> driver then?
>
> > Add another block to configure the vp3 as well, if applicable.
> >
> > Fixes: 5a028e8f062f ("drm/rockchip: vop2: Add support for rk3588")
> > Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de>
> > ---
> > drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 12 ++++++++++++
> > drivers/gpu/drm/rockchip/rockchip_drm_vop2.h | 1 +
> > 2 files changed, 13 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> > index 523880a4e8e74..1a327a9ed7ee4 100644
> > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> > @@ -2303,6 +2303,7 @@ static void vop2_setup_alpha(struct vop2_video_port *vp)
> > static void vop2_setup_layer_mixer(struct vop2_video_port *vp)
> > {
> > struct vop2 *vop2 = vp->vop2;
> > + const struct vop2_data *vop2_data = vop2->data;
> > struct drm_plane *plane;
> > u32 layer_sel = 0;
> > u32 port_sel;
> > @@ -2344,6 +2345,17 @@ static void vop2_setup_layer_mixer(struct vop2_video_port *vp)
> > else
> > port_sel |= FIELD_PREP(RK3568_OVL_PORT_SET__PORT2_MUX, 8);
> >
> > + /* configure vp3 */
> > + if (vop2_data->soc_id == 3588) {
>
> I think it'd be smarter to check against vop2->data->nr_vps >= 4; so
> that we don't need to maintain a list of SoCs that support a specific
> number of video ports.
probably ;-)
>
> > + struct vop2_video_port *vp3 = &vop2->vps[3];
>
> This is always possible because vps is statically allocated for 4 items,
> c.f. struct vop2_video_port vps[ROCKCHIP_MAX_CRTC]; so we don't
> necessarily need it in this specific location and can group it with the
> others. Cosmetic suggestion though.
>
> Otherwise, the change itself makes sense to me, so:
>
> Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
though comments from Andy from Rockchip in another thread suggest that
this is not necessary at all, as the "last" vp somehow has a hardware lock
to take the remaining layers or so.
And while tracking down dsi issues I had a "binary" state of
"gray display" without this patch and working DSI with it, in the last days
I haven't been able to reproduce this anymore.
So I guess I'll fix up the first patch according to your comment and keep
this change here for later.
Heiko
prev parent reply other threads:[~2024-05-03 13:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 19:55 [PATCH 0/2] drm/rockchip: vop2: two fixes from working on DSI enablement Heiko Stuebner
2024-04-25 19:55 ` [PATCH 1/2] drm/rockchip: vop2: fix rk3588 dp+dsi maxclk verification Heiko Stuebner
2024-05-03 12:13 ` Quentin Schulz
2024-04-25 19:55 ` [PATCH 2/2] drm/rockchip: vop2: configure layers for vp3 on rk3588 Heiko Stuebner
2024-05-03 12:57 ` Quentin Schulz
2024-05-03 13:02 ` Heiko Stübner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9626238.rMLUfLXkoz@diego \
--to=heiko@sntech.de \
--cc=andy.yan@rock-chips.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko.stuebner@cherry.de \
--cc=hjc@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=quentin.schulz@cherry.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).