From: Danilo Krummrich <dakr@redhat.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com,
tursulin@ursulin.net, airlied@gmail.com, daniel@ffwll.ch,
dmitry.baryshkov@linaro.org, lyude@redhat.com,
andrzej.hajda@intel.com, lucas.demarchi@intel.com,
alexander.deucher@amd.com
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] drm/i915: fix missing linux/debugfs.h includes
Date: Tue, 30 Apr 2024 17:27:29 +0200 [thread overview]
Message-ID: <848f4b3b-eb6e-41e4-b410-4867351c6eeb@redhat.com> (raw)
In-Reply-To: <875xvy3nr6.fsf@intel.com>
On 4/30/24 16:53, Jani Nikula wrote:
> On Tue, 30 Apr 2024, Danilo Krummrich <dakr@redhat.com> wrote:
>> After dropping linux/debugfs.h include from drm/drm_print.h the following
>> files in i915 miss the linux/debugfs.h include: i915_debugfs.c,
>> i915_debugfs_params.c and i915_gpu_error.c.
>>
>> Add the include to fix the corresponding build errors.
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Fixes: 33d5ae6cacf4 ("drm/print: drop include debugfs.h and include where needed")
>> Closes: https://lore.kernel.org/oe-kbuild-all/202404260726.nyGuvl59-lkp@intel.com/
>> Signed-off-by: Danilo Krummrich <dakr@redhat.com>
>
> Thanks, but it's already fixed by commit 7fa043eafdb7 ("drm/i915: fix
> build with missing debugfs includes") in drm-next.
Even better, note that drm-misc-next is still broken though.
- Danilo
>
> BR,
> Jani.
>
>
>> ---
>> drivers/gpu/drm/i915/i915_debugfs.c | 1 +
>> drivers/gpu/drm/i915/i915_debugfs_params.c | 1 +
>> drivers/gpu/drm/i915/i915_gpu_error.c | 1 +
>> 3 files changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
>> index 24c78873b3cf..b552e27cdcd5 100644
>> --- a/drivers/gpu/drm/i915/i915_debugfs.c
>> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
>> @@ -26,6 +26,7 @@
>> *
>> */
>>
>> +#include <linux/debugfs.h>
>> #include <linux/sched/mm.h>
>> #include <linux/sort.h>
>> #include <linux/string_helpers.h>
>> diff --git a/drivers/gpu/drm/i915/i915_debugfs_params.c b/drivers/gpu/drm/i915/i915_debugfs_params.c
>> index 8bca02025e09..295486b8ceb1 100644
>> --- a/drivers/gpu/drm/i915/i915_debugfs_params.c
>> +++ b/drivers/gpu/drm/i915/i915_debugfs_params.c
>> @@ -3,6 +3,7 @@
>> * Copyright © 2019 Intel Corporation
>> */
>>
>> +#include <linux/debugfs.h>
>> #include <linux/kernel.h>
>>
>> #include "i915_debugfs_params.h"
>> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
>> index 2594eb10c559..625b3c024540 100644
>> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
>> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
>> @@ -28,6 +28,7 @@
>> */
>>
>> #include <linux/ascii85.h>
>> +#include <linux/debugfs.h>
>> #include <linux/highmem.h>
>> #include <linux/nmi.h>
>> #include <linux/pagevec.h>
>>
>> base-commit: 4a9a567ab101e659a4fafb7a691ff6b84531a10a
>
prev parent reply other threads:[~2024-04-30 15:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 14:25 [PATCH] drm/i915: fix missing linux/debugfs.h includes Danilo Krummrich
2024-04-30 14:53 ` Jani Nikula
2024-04-30 15:27 ` Danilo Krummrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=848f4b3b-eb6e-41e4-b410-4867351c6eeb@redhat.com \
--to=dakr@redhat.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=andrzej.hajda@intel.com \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=lkp@intel.com \
--cc=lucas.demarchi@intel.com \
--cc=lyude@redhat.com \
--cc=rodrigo.vivi@intel.com \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).