From: Jon Hunter <jonathanh@nvidia.com>
To: Abhinav Kumar <quic_abhinavk@quicinc.com>,
Rob Clark <robdclark@gmail.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] drm/msm: Fix gen_header.py for python earlier than v3.9
Date: Wed, 8 May 2024 21:52:37 +0100 [thread overview]
Message-ID: <780207c9-fcf1-460e-b16a-aad60c12ac71@nvidia.com> (raw)
In-Reply-To: <83b6e1aa-c8ec-0bd7-2c98-20705741b76a@quicinc.com>
On 08/05/2024 17:46, Abhinav Kumar wrote:
>
>
> On 5/8/2024 2:17 AM, Jon Hunter wrote:
>> Building the kernel with python3 versions earlier than v3.9 fails with
>> ...
>>
>> Traceback (most recent call last):
>> File "drivers/gpu/drm/msm/registers/gen_header.py", line 970, in
>> <module>
>> main()
>> File "drivers/gpu/drm/msm/registers/gen_header.py", line 951, in main
>> parser.add_argument('--validate',
>> action=argparse.BooleanOptionalAction)
>> AttributeError: module 'argparse' has no attribute
>> 'BooleanOptionalAction'
>>
>> The argparse attribute 'BooleanOptionalAction' is only supported for
>> python v3.9 and later. Fix support for earlier python3 versions by
>> explicitly defining '--validate' and '--no-validate' arguments.
>>
>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>> ---
>> drivers/gpu/drm/msm/registers/gen_header.py | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>
> Thanks for your patch, I had sent something similar y'day.
>
> If you are alright with https://patchwork.freedesktop.org/patch/593057/,
> we can use that one.
Yes that's fine with me.
Thanks
Jon
--
nvpublic
prev parent reply other threads:[~2024-05-08 20:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 9:17 [PATCH] drm/msm: Fix gen_header.py for python earlier than v3.9 Jon Hunter
2024-05-08 16:46 ` Abhinav Kumar
2024-05-08 20:52 ` Jon Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=780207c9-fcf1-460e-b16a-aad60c12ac71@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).