From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74110C48BCF for ; Wed, 9 Jun 2021 09:21:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A8BA61285 for ; Wed, 9 Jun 2021 09:21:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A8BA61285 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6A6DC6E50C; Wed, 9 Jun 2021 09:21:20 +0000 (UTC) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2047.outbound.protection.outlook.com [40.107.243.47]) by gabe.freedesktop.org (Postfix) with ESMTPS id CFF3F6E4BB; Wed, 9 Jun 2021 09:21:18 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FiID1J0KzamhYkLvW6+f5CFBt9iMSijmhlVXVee6VBtKNvv64fFoI0ZYKJ0Hmj7a8agllSbs1xMWrttsLBrceOvmEQHui9iXeOfsi/ARKnsrKiPdwwV0zB0zJZiK/d5z/I9CmwrB0xK1hZD5/igzZuUrozDqXlZvmWd6xJX4z5cJYyHj21dihaucf9crII73rtHFYbbGcKEhjC673Lq+tnZUAtKqkhESQFl+E8SKQAZaZv0eDIDYDbQJFcffCE91jdaBK31zKRQZueCLKguz2MoUxJ7VSIEpWMGJYgV/BBpJoJAo0o2f8n9EmTpah/gsKrFo+w75xA0nUfOj0TcTMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WEs3YBRW1RiP/S7IyJy3Si1nG0qgvckv6I1do9nJzVo=; b=XMhMa3n5DWckchMUgEa0o0+sh+9DmkaYDfL6jA0T3ntkJf+2E9R8ZUX/iMfH7VPiWbmRF5l+VLu7ibLvGC/U5tpgl3DEHZjCxZMVtk0xHwOKa6kLdQaY/Oq09CKKiiEaXk0u3+BZlvRJISzZ95yXk0tYzS32R1YywIuILtf3Ng8RFWmw8fi4vDHKPBwjC3a82b4+4bHuGX7yBk3oDompIKuOTThrS2SLnRxile7k8YJud1YeqPYTsUprnImgmtzWkv5SoDDARzARsIOFF+nxzdwJfZHoscgwdYwCHIJqXqBz8Ib9kiSU2peQbGhD7VgmltYsmAqjvRhMFevQnUATdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WEs3YBRW1RiP/S7IyJy3Si1nG0qgvckv6I1do9nJzVo=; b=4Q40rZB3O7AUJ/jWSqSRqLvoo87NwSX/CttnZtHpdmASEz4iIbeFVQ5brNVeaEZCQ5K9iWds3dynKod9XZ+sHY6w5e3jJ8ch4Emo5M13RJvCMdIU2JOEfK1NdVJNPh8aszaBCIsG3RmYE4HvT8AwSimD9VaPUgfIYMm98sJOvVc= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=amd.com; Received: from BY5PR12MB3764.namprd12.prod.outlook.com (2603:10b6:a03:1ac::17) by BYAPR12MB2616.namprd12.prod.outlook.com (2603:10b6:a03:66::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.20; Wed, 9 Jun 2021 09:21:13 +0000 Received: from BY5PR12MB3764.namprd12.prod.outlook.com ([fe80::d05:4bca:ea51:15af]) by BY5PR12MB3764.namprd12.prod.outlook.com ([fe80::d05:4bca:ea51:15af%6]) with mapi id 15.20.4195.030; Wed, 9 Jun 2021 09:21:13 +0000 Subject: Re: nouveau broken on Riva TNT2 in 5.13.0-rc4: NULL pointer dereference in nouveau_bo_sync_for_device To: Ondrej Zary References: <202106052143.52488.linux@zary.sk> <202106090857.42133.linux@zary.sk> <1c4a7360-57e3-c75a-c729-1432db5b90b9@amd.com> <202106090910.51188.linux@zary.sk> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <762c1044-6e3a-48fc-95e4-1730b6ef2a2e@amd.com> Date: Wed, 9 Jun 2021 11:21:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <202106090910.51188.linux@zary.sk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [2a02:908:1252:fb60:3e79:91ff:ea38:2624] X-ClientProxiedBy: PR3P191CA0014.EURP191.PROD.OUTLOOK.COM (2603:10a6:102:54::19) To BY5PR12MB3764.namprd12.prod.outlook.com (2603:10b6:a03:1ac::17) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2a02:908:1252:fb60:3e79:91ff:ea38:2624] (2a02:908:1252:fb60:3e79:91ff:ea38:2624) by PR3P191CA0014.EURP191.PROD.OUTLOOK.COM (2603:10a6:102:54::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21 via Frontend Transport; Wed, 9 Jun 2021 09:21:11 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7f29e7db-7784-48f7-d435-08d92b27ecdc X-MS-TrafficTypeDiagnostic: BYAPR12MB2616: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4502; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PXCZd0hYnTUQ/d6FiKsiCBjnUehJNryGqQUCtKh9VZtGj/h9v6er5qahwnQ64hxgXaiYujiTaN2VGRTbXHwinQLswYvSrlmAHzxK6Z9HO+TNg1gWHGCzg6rYRFp2xowNQweIHc/S5oqXuq5AbV0Jogp8FZIbCkAdj5d745fcbrGbqwL3QUUad/djUKrC6JI42P4FVeoYefaJ8/Zi07Utpu1thporF7kSaXd1wTN50lXUIGyhWFHg53SGn9SrH+JmGpHb1tzS1CpczBdciky5yVOWJU4iAXuy8Ob1RG6K9VzZ15qd2xwKQD9DClAXvpH1Jbn2hsA/qBF0r+Qj+ecg7RUFdRgpgQmr33QNYMWx2iKMyFMbZxFFSopYyslVJ8Me/h51siwrsiRCFI+4Zh+ft1b8ls2I+CJp+hVzbd6UgkjpNxCzHMan/kkpwmjBbJt+u0YkoqTgOLZWLMi11IXgXBNZs2/whgslEZ+8QxOKaAL55dhkfA5rZ6MGhoUeZ5u8QwuTR17PXxFxENADJJttwWnrDw0SCDv0B+hRNfNlAaroFfXe2XzsRYxSeWgzVD5jDMU2VMRephn0LGq9KJSSZ8SJvmSIsOh94UaXqkfU90IcxLCQxVf8dmeLxDNfWcVLdAa5XPF8EdKaUa20vJqmhCFeM+ZPc2q6nwTzyCqTGRF3JO47fvzQTHr/01uhb7YRMHGMYlagwv3KseoSuqDj9pUrBXsMOIWGnV6ut8IhCF/yU9NknE4vRxS6T01AXnmdm/ywUMQJUNU9NT33+6ENBfhzJv+ecr5TG5JJjkbqozaNFRUsmHi9+YvtSVpDxMWz X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR12MB3764.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(396003)(39860400002)(366004)(136003)(346002)(4326008)(6666004)(316002)(38100700002)(16526019)(8676002)(186003)(66476007)(966005)(478600001)(36756003)(5660300002)(86362001)(45080400002)(6916009)(31696002)(83380400001)(66556008)(6486002)(2616005)(31686004)(8936002)(2906002)(66946007)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ajR4S2Z0Y0lzdEZ3aHFZU2UzcVZ5VXNtcVpwYXB5SFgzK0s4UHRKLzNDS1Zw?= =?utf-8?B?SG82alM4bDJsYlFZdmd0UC9iTGgyVlhGYW14ckVZR3IrU3ByalMzTHN3Z2dD?= =?utf-8?B?OENjK1lSNWtuT0JUOWcyUktIV0poN3ErWXhjUlV3U0o4R05OYVZacmhvalJG?= =?utf-8?B?QjVxTUFIa3kydjdEY09RSFpoUlNTbXRScjdDVWNNRzFxbXMvUkJCekRtK1k5?= =?utf-8?B?d3JXVWlQeTZob1JGLzlQakdNVXFGZ3Y2WUk5Y3ExbVNZaHpnbm81QVdicDFy?= =?utf-8?B?bGJsbWhueEl4NzFQdGw3UU53dkRLRHBlU3g4RGMvNzI5cXQyeHdES09YV3Qz?= =?utf-8?B?U3c2TlVqWUpLeDIxbzVwV01KTTBwRnVNbVdEVnk2S2RESnZVbVRSRnVoRDRQ?= =?utf-8?B?TFpqSGZsQlMyaGJLWUJyZ1JjMjV0RVFtc09ocnJ1QmswWmRvaVdEb0JIcW1K?= =?utf-8?B?eW9CczczbnNtanI1RUpKS2pQVHpRMFMvQ04xblQ4SGxZQnIxZlVqWHBFUHl0?= =?utf-8?B?ZE5aK0M1WnFGajFab0s2RElMd3ZwOWhDTnhlczJwOTJpVjlSbmxZQmd3M05U?= =?utf-8?B?bzNYOTYzZEEwT3MyVy9XcWtLQVh1WXV1d0VOTmFiMW1qUWZBWVpQTWVYNHZm?= =?utf-8?B?cGtzM0hNelVtaDh4QUdkMUEzcTBETmE3OHAwenJ4LzdybEZmWWk1bDVWOFhm?= =?utf-8?B?YXMrYmMxazlJNlkrdWZBT3pEd2RnSjhPdjJwb2FUZnlRN3pYdXNZbzRzUzdW?= =?utf-8?B?TzF2L0EvV2pUTWRhRVlnaVh4SlppYjM1QUhld29GbWpXaDhscFpiL2h5Q1JM?= =?utf-8?B?b2pWZXAwZjd3a2xZVTFRVFV2NEh6VURWSXViMjI4RkZlZDZIdmxsdk1pSmMv?= =?utf-8?B?OVNlRHZBR0RWODlMWW9RNWlWVXJXNm1XbGc1NlBQYVZ4WVBYWTBkeThuNnFJ?= =?utf-8?B?STMvaXZGdGlzZkY5QzdCVm5UYlhadWlKcEJIOXRSYUJNWXc4RTNJQ2FCdmJQ?= =?utf-8?B?ajF4blcvUnp6Z1d1dDl4RG0rTEExejZNZHB4VmpiSHpOQ0F4UXVxWUVQMmNE?= =?utf-8?B?d09EakpQY1M5SHB4TW5hdWYyZkNIQUZVNWZ3T0ltaXBkakZzRXNTTjRteTdo?= =?utf-8?B?ZHVKZ3FFTXU4eERPT1JhR0N2R0N2dm13dGdZSVdENmJGVEZvOUViOEhkbld1?= =?utf-8?B?QmJLS2wrdTQzcm51SmJINjJ6U0hJSURPTGt1T3RaVHNOdzJzZVhzemgyYzNp?= =?utf-8?B?WktFL1pqMHZSTWlQbXNWUXhRc1VWYWNpb1ZqTklWbnlUZFlxWFBFSlIxN2Iy?= =?utf-8?B?NW9JclpCT3NhY2tkMDlSWWpZYXMrdVJSVmRwcXBMUURUeW1WdG5VVnRPQklm?= =?utf-8?B?eDZCKzhFK29PQmxtTzU4U0o5Qml3Rk4vSXZ1YXBPdkppeTRNK0twZnpBT2V0?= =?utf-8?B?Q1QxVFJvUDNva2VCZElENmFPaWh4Mktxdjd5RGZJT05ZM0VzY041MGppeVFl?= =?utf-8?B?Qk9OZXB0MjcxTE1zNWJ0N2tFbERTditUdmIwTklrUjM3TEswYnoxYy85aGI3?= =?utf-8?B?VEJJekNmZTJWL2xHbCtpUlZGdngrdnpCTEJBMmJLbFVnMVE3ZzFFTFNtRVlx?= =?utf-8?B?K1pBUjd0MHg1NTFiU2NuallWU1FCOE9DT3gzNXhzT2pEVnpQNUw1M1VlR21Z?= =?utf-8?B?MGREN3BCall0aEhpUnMvK2tLRGRCTVViY0hWNWwrOU1TcWhqQjIzbDNlT0ow?= =?utf-8?B?THJkTzQ5Qm5VVnp2M0JYQkgwbEhKUzIwTG9LUDZHK1N2eXJMb3Rud3lOWGNP?= =?utf-8?B?VDZ5Q0ZsTUlBckxVeVBhMm1SSTRwbUwrNUZ2VGtCM0MyVFRZckZKb0ErNjVI?= =?utf-8?Q?Rp0139+J25EkQ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f29e7db-7784-48f7-d435-08d92b27ecdc X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB3764.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2021 09:21:13.0358 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cCBMBF5jdk9kfWwNQ9KJppehirH34XOcyE6Ix4Q0EbpvcT0kcI6JXEj1Tng4oeSt X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2616 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nouveau@lists.freedesktop.org, Ben Skeggs , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Am 09.06.21 um 09:10 schrieb Ondrej Zary: > On Wednesday 09 June 2021, Christian König wrote: >> Am 09.06.21 um 08:57 schrieb Ondrej Zary: >>> [SNIP] >>>> Thanks for the heads up. So the problem with my patch is already fixed, >>>> isn't it? >>> The NULL pointer dereference in nouveau_bo_wr16 introduced in >>> 141b15e59175aa174ca1f7596188bd15a7ca17ba was fixed by >>> aea656b0d05ec5b8ed5beb2f94c4dd42ea834e9d. >>> >>> That's the bug I hit when bisecting the original problem: >>> NULL pointer dereference in nouveau_bo_sync_for_device >>> It's caused by: >>> # first bad commit: [e34b8feeaa4b65725b25f49c9b08a0f8707e8e86] drm/ttm: merge ttm_dma_tt back into ttm_tt >> Good that I've asked :) >> >> Ok that's a bit strange. e34b8feeaa4b65725b25f49c9b08a0f8707e8e86 was >> created mostly automated. >> >> Do you have the original backtrace of that NULL pointer deref once more? > The original backtrace is here: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flkml.org%2Flkml%2F2021%2F6%2F5%2F350&data=04%7C01%7Cchristian.koenig%40amd.com%7Ce905b6bd2aa842ace15508d92b15b96d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637588195000729460%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=zFqheBbJcOHtYgqG%2Fs63AT1dwuk4REmUDJWHvzaLAlc%3D&reserved=0 And the problem is that ttm_dma->dma_address is NULL, right? Mhm, I don't see how that can happen since nouveau is using ttm_sg_tt_init(). Apart from that what nouveau does here is rather questionable since you need a coherent architecture for most things anyway, but that's not what we are trying to fix here. Can you try to narrow down if ttm_sg_tt_init is called before calling this function for the tt object in question? Thanks, Christian.