From: Jayesh Choudhary <j-choudhary@ti.com>
To: Maxime Ripard <mripard@kernel.org>
Cc: <andrzej.hajda@intel.com>, <neil.armstrong@linaro.org>,
<rfoss@kernel.org>, <Laurent.pinchart@ideasonboard.com>,
<jonas@kwiboo.se>, <jernej.skrabec@gmail.com>,
<maarten.lankhorst@linux.intel.com>, <tzimmermann@suse.de>,
<airlied@gmail.com>, <daniel@ffwll.ch>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/bridge: sii902x: Fix mode_valid hook
Date: Fri, 3 May 2024 20:43:54 +0530 [thread overview]
Message-ID: <758be932-d791-48e5-ae36-de7542c7a2a3@ti.com> (raw)
In-Reply-To: <20240415-venomous-enthusiastic-wildebeest-a7a446@houat>
Hello Maxime,
Thanks for the review.
On 15/04/24 13:10, Maxime Ripard wrote:
> Hi,
>
> On Mon, Apr 08, 2024 at 01:44:35PM +0530, Jayesh Choudhary wrote:
>> Currently, mode_valid hook returns all mode as valid. Add the check
>> for the maximum and minimum pixel clock that the bridge can support
>> while validating a mode.
>>
>> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
>> ---
>> drivers/gpu/drm/bridge/sii902x.c | 16 +++++++++++++++-
>> 1 file changed, 15 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c
>> index 8f84e98249c7..658819199c84 100644
>> --- a/drivers/gpu/drm/bridge/sii902x.c
>> +++ b/drivers/gpu/drm/bridge/sii902x.c
>> @@ -163,6 +163,16 @@
>>
>> #define SII902X_AUDIO_PORT_INDEX 3
>>
>> +/*
>> + * The maximum resolution supported by the HDMI bridge is 1080p@60Hz
>> + * and 1920x1200 requiring a pixel clock of 165MHz and the minimum
>> + * resolution supported is 480p@60Hz requiring a pixel clock of 25MHz
>> + *
>> + * (drm_display_mode clock is in kHz)
>> + */
>> +#define SII902X_MIN_PIXEL_CLOCK 25000
>> +#define SII902X_MAX_PIXEL_CLOCK 165000
>> +
>
> You should probably add a KHZ suffix or something to make it obvious.
> The natural unit for a frequency is Hertz.
Okay.
Instead of adding the kHz in comments, I will add that in suffix
like SII902X_MIN_PIXEL_CLOCK_KHZ.
>
>> struct sii902x {
>> struct i2c_client *i2c;
>> struct regmap *regmap;
>> @@ -313,7 +323,11 @@ static int sii902x_get_modes(struct drm_connector *connector)
>> static enum drm_mode_status sii902x_mode_valid(struct drm_connector *connector,
>> struct drm_display_mode *mode)
>> {
>> - /* TODO: check mode */
>> + if (mode->clock < SII902X_MIN_PIXEL_CLOCK)
>> + return MODE_CLOCK_LOW;
>> +
>> + if (mode->clock > SII902X_MAX_PIXEL_CLOCK)
>> + return MODE_CLOCK_HIGH;
>>
>> return MODE_OK;
>> }
>
> It's something you should do in atomic_check too
>
Like using clock from adjusted mode in crtc_state?
Will update in the next revision.
Warm Regards,
-Jayesh
prev parent reply other threads:[~2024-05-03 15:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 8:14 [PATCH] drm/bridge: sii902x: Fix mode_valid hook Jayesh Choudhary
2024-04-15 7:40 ` Maxime Ripard
2024-05-03 15:13 ` Jayesh Choudhary [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=758be932-d791-48e5-ae36-de7542c7a2a3@ti.com \
--to=j-choudhary@ti.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).