From: 隋景峰 <suijingfeng@bosc.ac.cn>
To: "Maxime Ripard" <mripard@kernel.org>
Cc: "Sui Jingfeng" <sui.jingfeng@linux.dev>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Douglas Anderson" <dianders@chromium.org>,
"Biju Das" <biju.das.jz@bp.renesas.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: Re: drm/debugfs: Drop conditionals around of_node pointers
Date: Tue, 30 Apr 2024 09:15:49 +0800 (GMT+08:00) [thread overview]
Message-ID: <6db82a3f.c7.18f2c927d9f.Coremail.suijingfeng@bosc.ac.cn> (raw)
In-Reply-To: <20240429-enchanted-cooperative-jacamar-cf2902@houat>
Hi,
> -----原始邮件-----
> 发件人: "Maxime Ripard" <mripard@kernel.org>
> 发送时间: 2024-04-29 19:30:24 (星期一)
> 收件人: "Sui Jingfeng" <suijingfeng@bosc.ac.cn>
> 抄送: "Sui Jingfeng" <sui.jingfeng@linux.dev>, "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>, "Thomas Zimmermann" <tzimmermann@suse.de>, "David Airlie" <airlied@gmail.com>, "Daniel Vetter" <daniel@ffwll.ch>, "Douglas Anderson" <dianders@chromium.org>, "Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>, "Biju Das" <biju.das.jz@bp.renesas.com>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
> 主题: Re: drm/debugfs: Drop conditionals around of_node pointers
>
> On Sun, Apr 28, 2024 at 04:52:13PM +0800, Sui Jingfeng wrote:
> > ping
> >
> > 在 2024/3/22 06:22, Sui Jingfeng 写道:
> > > Having conditional around the of_node pointer of the drm_bridge structure
> > > turns out to make driver code use ugly #ifdef blocks.
>
> The code being ugly is an opinion, what problem is it causing exactly?
>
> > Drop the conditionals to simplify debugfs.
>
> What does it simplifies?
>
> > >
> > > Fixes: d8dfccde2709 ("drm/bridge: Drop conditionals around of_node pointers")
> > > Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev>
>
> Why do we want to backport that patch to stable?
My commit message is written based on commit of d8dfccde2709
$ git show c9e358dfc4a8
This patch is based on commit c9e358dfc4a8 ("driver-core: remove
conditionals around devicetree pointers").
Having conditional around the of_node pointer of the drm_bridge
structure turns out to make driver code use ugly #ifdef blocks. Drop the
conditionals to simplify drivers. While this slightly increases the size
of struct drm_bridge on non-OF system, the number of bridges used today
and foreseen tomorrow on those systems is very low, so this shouldn't be
an issue.
So drop #if conditionals by adding struct device_node forward declaration.
> Maxime
I'm just start to contribute by mimic other people's tone, there seems no need
to over read.
next prev parent reply other threads:[~2024-04-30 1:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 22:22 [PATCH] drm/debugfs: Drop conditionals around of_node pointers Sui Jingfeng
2024-04-28 8:52 ` Sui Jingfeng
2024-04-29 11:30 ` Maxime Ripard
2024-04-30 1:15 ` 隋景峰 [this message]
2024-04-30 21:33 ` Doug Anderson
2024-05-01 4:36 ` Sui Jingfeng
2024-04-29 11:20 ` [PATCH] " Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6db82a3f.c7.18f2c927d9f.Coremail.suijingfeng@bosc.ac.cn \
--to=suijingfeng@bosc.ac.cn \
--cc=airlied@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=sui.jingfeng@linux.dev \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).