From: Tvrtko Ursulin <tursulin@ursulin.net>
To: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>,
Jeffrey Hugo <quic_jhugo@quicinc.com>,
dri-devel@lists.freedesktop.org
Cc: oded.gabbay@gmail.com, Tomasz Rusinowicz <tomasz.rusinowicz@intel.com>
Subject: Re: [PATCH 12/12] accel/ivpu: Share NPU busy time in sysfs
Date: Mon, 13 May 2024 11:45:11 +0100 [thread overview]
Message-ID: <66cde8ee-b174-4061-bcfd-a6b6811af6ef@ursulin.net> (raw)
In-Reply-To: <dbd2e32c-a75e-4d8a-9653-6f23cc494924@linux.intel.com>
On 13/05/2024 11:22, Jacek Lawrynowicz wrote:
> Hi,
>
> On 10.05.2024 18:55, Jeffrey Hugo wrote:
>> On 5/8/2024 7:29 AM, Jacek Lawrynowicz wrote:
>>> From: Tomasz Rusinowicz <tomasz.rusinowicz@intel.com>
>>>
>>> The driver tracks the time spent by NPU executing jobs
>>> and shares it through sysfs `npu_busy_time_us` file.
>>> It can be then used by user space applications to monitor device
>>> utilization.
>>>
>>> NPU is considered 'busy' starting with a first job submitted
>>> to firmware and ending when there is no more jobs pending/executing.
>>>
>>> Signed-off-by: Tomasz Rusinowicz <tomasz.rusinowicz@intel.com>
>>> Signed-off-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
>>
>> This feels like something that would normally be handled by perf. Why not use that mechanism?
>
> Yeah, probably but we had several request to provide easy to use interface for this metric that
> could be integrated in various user space apps/tools that do not use ftrace.
Probably more Perf/PMU aka performance counters? Which would be
scriptable via $kernel/tools/perf or directly via perf_event_open(2) and
read(2).
Note it is not easy to get right and in the i915 implementation (see
i915_pmu.c) we have a known issue with PCI hot unplug and use after free
which needs input from perf core folks.
Regards,
Tvrtko
next prev parent reply other threads:[~2024-05-13 10:45 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 13:20 [PATCH 00/12] accel/ivpu: Changes for 6.10 Jacek Lawrynowicz
2024-05-08 13:20 ` [PATCH 01/12] accel/ivpu: Update VPU FW API headers Jacek Lawrynowicz
2024-05-10 16:27 ` Jeffrey Hugo
2024-05-08 13:20 ` [PATCH 02/12] accel/ivpu: Add sched_mode module param Jacek Lawrynowicz
2024-05-10 16:30 ` Jeffrey Hugo
2024-05-13 10:08 ` Jacek Lawrynowicz
2024-05-08 13:21 ` [PATCH 03/12] accel/ivpu: Create priority based command queues Jacek Lawrynowicz
2024-05-10 16:32 ` Jeffrey Hugo
2024-05-08 13:21 ` [PATCH 04/12] accel/ivpu: Implement support for preemption buffers Jacek Lawrynowicz
2024-05-10 16:36 ` Jeffrey Hugo
2024-05-08 13:21 ` [PATCH 05/12] accel/ivpu: Add HWS JSM messages Jacek Lawrynowicz
2024-05-10 16:38 ` Jeffrey Hugo
2024-05-08 13:21 ` [PATCH 06/12] accel/ivpu: Implement support for hardware scheduler Jacek Lawrynowicz
2024-05-10 16:41 ` Jeffrey Hugo
2024-05-13 10:10 ` Jacek Lawrynowicz
2024-05-08 13:21 ` [PATCH 07/12] accel/ivpu: Add resume engine support Jacek Lawrynowicz
2024-05-10 16:42 ` Jeffrey Hugo
2024-05-13 10:11 ` Jacek Lawrynowicz
2024-05-08 13:21 ` [PATCH 08/12] accel/ivpu: Add NPU profiling support Jacek Lawrynowicz
2024-05-10 16:46 ` Jeffrey Hugo
2024-05-13 10:12 ` Jacek Lawrynowicz
2024-05-08 13:21 ` [PATCH 09/12] accel/ivpu: Add force snoop module parameter Jacek Lawrynowicz
2024-05-10 16:47 ` Jeffrey Hugo
2024-05-08 13:28 ` [PATCH 10/12] accel/ivpu: Configure fw logging using debugfs Jacek Lawrynowicz
2024-05-08 13:29 ` [PATCH 11/12] accel/ivpu: Increase reset counter when warm boot fails Jacek Lawrynowicz
2024-05-10 16:49 ` Jeffrey Hugo
2024-05-08 13:29 ` [PATCH 12/12] accel/ivpu: Share NPU busy time in sysfs Jacek Lawrynowicz
2024-05-10 16:55 ` Jeffrey Hugo
2024-05-13 10:22 ` Jacek Lawrynowicz
2024-05-13 10:45 ` Tvrtko Ursulin [this message]
2024-05-13 11:39 ` Jacek Lawrynowicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66cde8ee-b174-4061-bcfd-a6b6811af6ef@ursulin.net \
--to=tursulin@ursulin.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.lawrynowicz@linux.intel.com \
--cc=oded.gabbay@gmail.com \
--cc=quic_jhugo@quicinc.com \
--cc=tomasz.rusinowicz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).