From: Felix Kuehling <felix.kuehling@amd.com>
To: Matthew Wilcox <willy@infradead.org>, Alex Sierra <alex.sierra@amd.com>
Cc: rcampbell@nvidia.com, dri-devel@lists.freedesktop.org,
linux-mm@kvack.org, jglisse@redhat.com,
amd-gfx@lists.freedesktop.org, jgg@nvidia.com,
akpm@linux-foundation.org, hch@lst.de
Subject: Re: [RFC PATCH v2 1/8] ext4/xfs: add page refcount helper
Date: Mon, 14 Jun 2021 11:26:01 -0400 [thread overview]
Message-ID: <652c22b4-8ca6-acf9-653c-c93166c83770@amd.com> (raw)
In-Reply-To: <YMEVN8XZbCnyPu9/@casper.infradead.org>
Am 2021-06-09 um 3:23 p.m. schrieb Matthew Wilcox:
> On Mon, Jun 07, 2021 at 03:42:19PM -0500, Alex Sierra wrote:
>> +++ b/include/linux/dax.h
>> @@ -243,6 +243,16 @@ static inline bool dax_mapping(struct address_space *mapping)
>> return mapping->host && IS_DAX(mapping->host);
>> }
>>
>> +static inline bool dax_layout_is_idle_page(struct page *page)
>> +{
>> + return page_ref_count(page) == 1;
>> +}
> We already have something called an idle page, and that's quite a
> different thing from this. How about dax_page_unused() (it's a use
> count, so once it's got down to its minimum value, it's unused)?
>
Hi Matthew,
Thank you very much for your feedback. This patch looks straight-forward
enough, but do we need the filesystem maintainers to review this as
well? I guess we should CC the linux-ext4 and linux-xfs mailing lists in
the next revision.
Hi Ralph,
Are you OK if we update your patch with this suggestion?
Thanks,
Felix
next prev parent reply other threads:[~2021-06-14 15:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 20:42 [RFC PATCH v2 0/8] Support DEVICE_GENERIC memory in migrate_vma_* Alex Sierra
2021-06-07 20:42 ` [RFC PATCH v2 1/8] ext4/xfs: add page refcount helper Alex Sierra
2021-06-08 0:29 ` Liam Howlett
2021-06-08 14:33 ` Matthew Wilcox
2021-06-09 19:23 ` Matthew Wilcox
2021-06-14 15:26 ` Felix Kuehling [this message]
2021-06-07 20:42 ` [RFC PATCH v2 2/8] mm: remove extra ZONE_DEVICE struct page refcount Alex Sierra
2021-06-07 20:42 ` [RFC PATCH v2 3/8] kernel: resource: lookup_resource as exported symbol Alex Sierra
2021-06-07 20:42 ` [RFC PATCH v2 4/8] drm/amdkfd: add SPM support for SVM Alex Sierra
2021-06-07 20:42 ` [RFC PATCH v2 5/8] drm/amdkfd: generic type as sys mem on migration to ram Alex Sierra
2021-06-07 20:42 ` [RFC PATCH v2 6/8] include/linux/mm.h: helpers to check zone device generic type Alex Sierra
2021-06-07 20:42 ` [RFC PATCH v2 7/8] mm: add generic type support to migrate_vma helpers Alex Sierra
2021-06-07 20:42 ` [RFC PATCH v2 8/8] mm: call pgmap->ops->page_free for DEVICE_GENERIC pages Alex Sierra
2021-06-08 14:26 ` [RFC PATCH v2 0/8] Support DEVICE_GENERIC memory in migrate_vma_* Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=652c22b4-8ca6-acf9-653c-c93166c83770@amd.com \
--to=felix.kuehling@amd.com \
--cc=akpm@linux-foundation.org \
--cc=alex.sierra@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=jgg@nvidia.com \
--cc=jglisse@redhat.com \
--cc=linux-mm@kvack.org \
--cc=rcampbell@nvidia.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).