From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: John Harrison <john.c.harrison@intel.com>,
Matthew Brost <matthew.brost@intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>,
"Wajdeczko, Michal" <Michal.Wajdeczko@intel.com>
Subject: Re: [Intel-gfx] [PATCH 1/1] drm/i915/uc: Use platform specific defaults for GuC/HuC enabling
Date: Fri, 8 Apr 2022 10:44:58 +0100 [thread overview]
Message-ID: <5b6a4f83-0a0c-6916-1f75-a44f8b36ade7@linux.intel.com> (raw)
In-Reply-To: <006e88f8-38c5-3cda-0c89-cb97fa0cd817@intel.com>
On 07/04/2022 21:49, John Harrison wrote:
> On 4/7/2022 08:49, Tvrtko Ursulin wrote:
>> On 03/06/2021 17:48, Matthew Brost wrote:
>>> From: John Harrison <John.C.Harrison@Intel.com>
>>>
>>> The meaning of 'default' for the enable_guc module parameter has been
>>> updated to accurately reflect what is supported on current platforms.
>>> So start using the defaults instead of forcing everything off.
>>> Although, note that right now, the default is for everything to be off
>>> anyway. So this is not a change for current platforms.
>>>
>>> Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
>>> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
>>> Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>>> ---
>>> drivers/gpu/drm/i915/i915_params.c | 2 +-
>>> drivers/gpu/drm/i915/i915_params.h | 2 +-
>>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/i915_params.c
>>> b/drivers/gpu/drm/i915/i915_params.c
>>> index 0320878d96b0..e07f4cfea63a 100644
>>> --- a/drivers/gpu/drm/i915/i915_params.c
>>> +++ b/drivers/gpu/drm/i915/i915_params.c
>>> @@ -160,7 +160,7 @@ i915_param_named_unsafe(edp_vswing, int, 0400,
>>> i915_param_named_unsafe(enable_guc, int, 0400,
>>> "Enable GuC load for GuC submission and/or HuC load. "
>>> "Required functionality can be selected using bitmask values. "
>>> - "(-1=auto, 0=disable [default], 1=GuC submission, 2=HuC load)");
>>> + "(-1=auto [default], 0=disable, 1=GuC submission, 2=HuC load)");
>>> i915_param_named(guc_log_level, int, 0400,
>>> "GuC firmware logging level. Requires GuC to be loaded. "
>>> diff --git a/drivers/gpu/drm/i915/i915_params.h
>>> b/drivers/gpu/drm/i915/i915_params.h
>>> index 4a114a5ad000..f27eceb82c0f 100644
>>> --- a/drivers/gpu/drm/i915/i915_params.h
>>> +++ b/drivers/gpu/drm/i915/i915_params.h
>>> @@ -59,7 +59,7 @@ struct drm_printer;
>>> param(int, disable_power_well, -1, 0400) \
>>> param(int, enable_ips, 1, 0600) \
>>> param(int, invert_brightness, 0, 0600) \
>>> - param(int, enable_guc, 0, 0400) \
>>> + param(int, enable_guc, -1, 0400) \
>>> param(int, guc_log_level, -1, 0400) \
>>> param(char *, guc_firmware_path, NULL, 0400) \
>>> param(char *, huc_firmware_path, NULL, 0400) \
>>
>> What is the BKM to use this with multi-GPU setups? Specifically I have
>> a TGL+DG1 laptop (off the shelf) and want to have GuC with DG1 only.
>> If I pass i915.enable_guc=3 it seems it wants to enable it for TGL as
>> well and wedges the GPU if it can't?
>>
> I don't think there is one.
>
> Module parameters are driver global and therefore apply to all cards in
> the system, both discrete and integrated. The '-1' default can and does
> have different meanings for each card. So in the TGL+DG1 case, TGL
> should default to execlist and DG1 should already be defaulting to GuC.
> So the -1 setting should do what you want. But if you did need to
> override for one specific card only then I think you would need to do
> that with a code change and rebuild.
You are right, I was on a kernel where DG1 wasn't yet defaulting to GuC
hence the confusion when I tried to pass enable_guc=3 that broke TGL as
well, but because I had no up to date firmware for it.
We really need per device modparams, as long as we have modparams..
Regards,
Tvrtko
prev parent reply other threads:[~2022-04-08 9:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 16:48 [PATCH 0/1] Use platform specific defaults for GuC/HuC enabling Matthew Brost
2021-06-03 16:48 ` [PATCH 1/1] drm/i915/uc: " Matthew Brost
2021-06-09 18:31 ` [Intel-gfx] " Daniele Ceraolo Spurio
2022-04-07 15:49 ` Tvrtko Ursulin
2022-04-07 20:49 ` John Harrison
2022-04-08 9:44 ` Tvrtko Ursulin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b6a4f83-0a0c-6916-1f75-a44f8b36ade7@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Michal.Wajdeczko@intel.com \
--cc=daniele.ceraolospurio@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=john.c.harrison@intel.com \
--cc=matthew.brost@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).