From: Danilo Krummrich <dakr@redhat.com>
To: Timur Tabi <ttabi@nvidia.com>,
Lucas De Marchi <lucas.demarchi@intel.com>
Cc: "airlied@redhat.com" <airlied@redhat.com>,
"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
"lyude@redhat.com" <lyude@redhat.com>,
Ben Skeggs <bskeggs@nvidia.com>,
chaitanya.kumar.borah@intel.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] [v7] nouveau: add command-line GSP-RM registry support
Date: Tue, 30 Apr 2024 15:15:13 +0200 [thread overview]
Message-ID: <59308970-b85a-4f09-a047-146bb24ffcb0@redhat.com> (raw)
In-Reply-To: <wuoxhpvhh7pzmniv5clkr3756fjrqyukahw63ugbljte72o5gq@fdc3wpcasimh>
On 4/30/24 15:06, Lucas De Marchi wrote:
> On Fri, Apr 26, 2024 at 06:08:19PM GMT, Danilo Krummrich wrote:
>> On 4/25/24 18:38, Timur Tabi wrote:
>>> On Thu, 2024-04-25 at 15:22 +0200, Danilo Krummrich wrote:
>>>>> + size_t length;
>>>>> +
>>>>> + /* Remove any whitespace from the parameter string */
>>>>> + length = strip(p, " \t\n");
>>>>
>>>> With that, I see the following warning compiling this patch.
>>>>
>>>> warning: variable ‘length’ set but not used [-Wunused-but-set-variable]
>>>>
>>>> Did you intend to use the length for anything?
>>>
>>> No, and I could have sworn I fixed that before sending out v7. I think I
>>> originally intended 'length' to determine when I finished parsing the
>>> string.
>>>
>>>> Also, looking at the warning made me aware of 'p' potentially being NULL.
>>>>
>>>> If you agree, I can fix the warning and add the corresponding NULL check
>>>> when
>>>> applying the patch.
>>>
>>> Yes, that would be great. You can just delete 'length'. The NULL check for
>>> 'p' should call clean_registry() before returning -ENOMEM.
>>
>> Applied to drm-misc-next, thanks!
>
>
> since this commit our CI is failing to build with the following error:
>
> CC [M] drivers/gpu/drm/i915/display/intel_display_device.o
> ../drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c: In function ‘build_registry’:
> ../drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c:1266:3: error: label at end of compound statement
> 1266 | default:
> | ^~~~~~~
> CC [M] drivers/gpu/drm/amd/amdgpu/gfx_v10_0.o
> HDRTEST drivers/gpu/drm/xe/compat-i915-headers/i915_reg.h
> CC [M] drivers/gpu/drm/amd/amdgpu/imu_v11_0.o
> make[7]: *** [../scripts/Makefile.build:244: drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.o] Error 1
> make[7]: *** Waiting for unfinished jobs....
>
> you are missing a `break;` after that default.
@Timur, do you want to send a quick fix for this yourself? Otherwise, I can send
one as well.
We should fix this asap.
- Danilo
>
>
>>
>>>
>>> Thanks for catching this.
>>
>
prev parent reply other threads:[~2024-04-30 13:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240417215317.3490856-1-ttabi@nvidia.com>
[not found] ` <162ef3c0-1d7b-4220-a21f-b0008657f8a5@redhat.com>
[not found] ` <913052ca6c0988db1bab293cfae38529251b4594.camel@nvidia.com>
[not found] ` <5df03f8d-7835-4a90-b8fa-d20bd05e62fc@redhat.com>
2024-04-30 13:06 ` [PATCH] [v7] nouveau: add command-line GSP-RM registry support Lucas De Marchi
2024-04-30 13:15 ` Danilo Krummrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59308970-b85a-4f09-a047-146bb24ffcb0@redhat.com \
--to=dakr@redhat.com \
--cc=airlied@redhat.com \
--cc=bskeggs@nvidia.com \
--cc=chaitanya.kumar.borah@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=lyude@redhat.com \
--cc=nouveau@lists.freedesktop.org \
--cc=ttabi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).