dri-devel Archive mirror
 help / color / mirror / Atom feed
From: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
To: dri-devel@lists.freedesktop.org
Cc: oded.gabbay@gmail.com, quic_jhugo@quicinc.com,
	Tomasz Rusinowicz <tomasz.rusinowicz@intel.com>
Subject: Re: [PATCH 10/12] accel/ivpu: Configure fw logging using debugfs
Date: Wed, 8 May 2024 15:30:43 +0200	[thread overview]
Message-ID: <301ca63c-668b-4f2c-a7a0-c3fe2144658b@linux.intel.com> (raw)
In-Reply-To: <20240508132557.2388267-1-jacek.lawrynowicz@linux.intel.com>

Hi,

Please ignore this patch. It got here by mistake.
There is another one sent as a part of a patchset.

On 08.05.2024 15:25, Jacek Lawrynowicz wrote:
> From: Tomasz Rusinowicz <tomasz.rusinowicz@intel.com>
> 
> Add fw_dyndbg file that can be used to control FW logging.
> 
> Signed-off-by: Tomasz Rusinowicz <tomasz.rusinowicz@intel.com>
> Signed-off-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
> ---
>  drivers/accel/ivpu/ivpu_debugfs.c | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/drivers/accel/ivpu/ivpu_debugfs.c b/drivers/accel/ivpu/ivpu_debugfs.c
> index 6ff967e595cf..b6c7d6a53c79 100644
> --- a/drivers/accel/ivpu/ivpu_debugfs.c
> +++ b/drivers/accel/ivpu/ivpu_debugfs.c
> @@ -145,6 +145,30 @@ static const struct file_operations dvfs_mode_fops = {
>  	.write = dvfs_mode_fops_write,
>  };
>  
> +static ssize_t
> +fw_dyndbg_fops_write(struct file *file, const char __user *user_buf, size_t size, loff_t *pos)
> +{
> +	struct ivpu_device *vdev = file->private_data;
> +	char buffer[VPU_DYNDBG_CMD_MAX_LEN] = {};
> +	int ret;
> +
> +	if (size >= VPU_DYNDBG_CMD_MAX_LEN)
> +		return -EINVAL;
> +
> +	ret = strncpy_from_user(buffer, user_buf, size);
> +	if (ret < 0)
> +		return ret;
> +
> +	ivpu_jsm_dyndbg_control(vdev, buffer, size);
> +	return size;
> +}
> +
> +static const struct file_operations fw_dyndbg_fops = {
> +	.owner = THIS_MODULE,
> +	.open = simple_open,
> +	.write = fw_dyndbg_fops_write,
> +};
> +
>  static int fw_log_show(struct seq_file *s, void *v)
>  {
>  	struct ivpu_device *vdev = s->private;
> @@ -369,6 +393,8 @@ void ivpu_debugfs_init(struct ivpu_device *vdev)
>  	debugfs_create_file("dvfs_mode", 0200, debugfs_root, vdev,
>  			    &dvfs_mode_fops);
>  
> +	debugfs_create_file("fw_dyndbg", 0200, debugfs_root, vdev,
> +			    &fw_dyndbg_fops);
>  	debugfs_create_file("fw_log", 0644, debugfs_root, vdev,
>  			    &fw_log_fops);
>  	debugfs_create_file("fw_trace_destination_mask", 0200, debugfs_root, vdev,

  reply	other threads:[~2024-05-08 13:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-08 13:25 [PATCH 10/12] accel/ivpu: Configure fw logging using debugfs Jacek Lawrynowicz
2024-05-08 13:30 ` Jacek Lawrynowicz [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-05-08 13:20 [PATCH 00/12] accel/ivpu: Changes for 6.10 Jacek Lawrynowicz
2024-05-08 13:28 ` [PATCH 10/12] accel/ivpu: Configure fw logging using debugfs Jacek Lawrynowicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=301ca63c-668b-4f2c-a7a0-c3fe2144658b@linux.intel.com \
    --to=jacek.lawrynowicz@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=oded.gabbay@gmail.com \
    --cc=quic_jhugo@quicinc.com \
    --cc=tomasz.rusinowicz@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).