From: Borislav Petkov <bp@alien8.de>
To: Alexey Makhalov <alexey.makhalov@broadcom.com>
Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux.dev,
hpa@zytor.com, dave.hansen@linux.intel.com, mingo@redhat.com,
tglx@linutronix.de, x86@kernel.org, netdev@vger.kernel.org,
richardcochran@gmail.com, linux-input@vger.kernel.org,
dmitry.torokhov@gmail.com, zackr@vmware.com,
linux-graphics-maintainer@vmware.com, pv-drivers@vmware.com,
timothym@vmware.com, akaher@vmware.com,
dri-devel@lists.freedesktop.org, daniel@ffwll.ch,
airlied@gmail.com, tzimmermann@suse.de, mripard@kernel.org,
maarten.lankhorst@linux.intel.com, horms@kernel.org,
kirill.shutemov@linux.intel.com,
Nadav Amit <nadav.amit@gmail.com>, Jeff Sipek <jsipek@vmware.com>
Subject: Re: [PATCH v9 3/8] x86/vmware: Introduce VMware hypercall API
Date: Tue, 7 May 2024 11:58:52 +0200 [thread overview]
Message-ID: <20240507095852.GVZjn7XM0VMXzBfKsd@fat_crate.local> (raw)
In-Reply-To: <20240506215305.30756-4-alexey.makhalov@broadcom.com>
On Mon, May 06, 2024 at 02:53:00PM -0700, Alexey Makhalov wrote:
> +#define VMWARE_HYPERCALL \
> + ALTERNATIVE_3("cmpb $" \
> + __stringify(CPUID_VMWARE_FEATURES_ECX_VMMCALL) \
> + ", %[mode]\n\t" \
> + "jg 2f\n\t" \
> + "je 1f\n\t" \
> + "movw %[port], %%dx\n\t" \
> + "inl (%%dx), %%eax\n\t" \
> + "jmp 3f\n\t" \
> + "1: vmmcall\n\t" \
> + "jmp 3f\n\t" \
> + "2: vmcall\n\t" \
> + "3:\n\t", \
> + "movw %[port], %%dx\n\t" \
> + "inl (%%dx), %%eax", X86_FEATURE_HYPERVISOR, \
That's a bunch of insns and their size would inadvertently go into the final
image.
What you should try to do is something like this:
ALTERNATIVE_3("jmp .Lend_legacy_call", "", X86_FEATURE_HYPERVISOR,
"vmcall; jmp .Lend_legacy_call", X86_FEATURE_VMCALL,
"vmmcall; jmp .Lend_legacy_call", X86_FEATURE_VMW_VMMCALL)
/* bunch of conditional branches and INs and V*MCALLs, etc go here */
.Lend_legacy_call:
so that you don't have these 26 bytes, as you say, of alternatives to patch but
only the JMPs and the VM*CALLs.
See for an example the macros in arch/x86/entry/calling.h which simply jump
over the code when not needed.
Also, you could restructure the alternative differently so that that bunch of
insns call is completely out-of-line because all current machines support
VM*CALL so you won't even need to patch. You only get to patch when running on
some old rust and there you can just as well go completely out-of-line.
Something along those lines, anyway.
> - * The high bandwidth in call. The low word of edx is presumed to have the
> - * HB bit set.
> + * High bandwidth calls are not supported on encrypted memory guests.
> + * The caller should check cc_platform_has(CC_ATTR_MEM_ENCRYPT) and use
> + * low bandwidth hypercall it memory encryption is set.
s/it/if/
> -#define VMWARE_PORT(cmd, eax, ebx, ecx, edx) \
> - __asm__("inl (%%dx), %%eax" : \
> - "=a"(eax), "=c"(ecx), "=d"(edx), "=b"(ebx) : \
> - "a"(VMWARE_HYPERVISOR_MAGIC), \
> - "c"(VMWARE_CMD_##cmd), \
> - "d"(VMWARE_HYPERVISOR_PORT), "b"(UINT_MAX) : \
> - "memory")
> -
> -#define VMWARE_VMCALL(cmd, eax, ebx, ecx, edx) \
> - __asm__("vmcall" : \
> - "=a"(eax), "=c"(ecx), "=d"(edx), "=b"(ebx) : \
> - "a"(VMWARE_HYPERVISOR_MAGIC), \
> - "c"(VMWARE_CMD_##cmd), \
> - "d"(0), "b"(UINT_MAX) : \
> - "memory")
> -
> -#define VMWARE_VMMCALL(cmd, eax, ebx, ecx, edx) \
> - __asm__("vmmcall" : \
> - "=a"(eax), "=c"(ecx), "=d"(edx), "=b"(ebx) : \
> - "a"(VMWARE_HYPERVISOR_MAGIC), \
> - "c"(VMWARE_CMD_##cmd), \
> - "d"(0), "b"(UINT_MAX) : \
> - "memory")
> -
> -#define VMWARE_CMD(cmd, eax, ebx, ecx, edx) do { \
> - switch (vmware_hypercall_mode) { \
> - case CPUID_VMWARE_FEATURES_ECX_VMCALL: \
> - VMWARE_VMCALL(cmd, eax, ebx, ecx, edx); \
> - break; \
> - case CPUID_VMWARE_FEATURES_ECX_VMMCALL: \
> - VMWARE_VMMCALL(cmd, eax, ebx, ecx, edx); \
> - break; \
> - default: \
> - VMWARE_PORT(cmd, eax, ebx, ecx, edx); \
> - break; \
> - } \
> - } while (0)
You're kidding, right?
You went to all that trouble in patch 1 to move those to the header only to
*remove* them here?
You do realize that that is a unnecessary churn for no good reason, right?
So that set needs to be restructured differently.
* first patch introduces those new API calls.
* follow-on patches convert the callers to the new API
* last patch removes the old API.
Ok?
And when you redo them, make sure you drop all Reviewed-by tags because the new
versions are not reviewed anymore.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2024-05-07 9:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 22:56 [PATCH v8 0/7] VMware hypercalls enhancements Alexey Makhalov
2024-04-22 22:56 ` [PATCH v8 1/7] x86/vmware: Move common macros to vmware.h Alexey Makhalov
2024-04-24 16:06 ` Borislav Petkov
2024-04-24 23:12 ` Alexey Makhalov
2024-04-24 23:14 ` [PATCH v9 1/8] x86/vmware: Correct macro names Alexey Makhalov
2024-04-24 23:14 ` [PATCH v9 2/8] x86/vmware: Move common macros to vmware.h Alexey Makhalov
2024-05-05 18:28 ` Borislav Petkov
2024-05-06 21:52 ` [PATCH v9 0/8] VMware hypercalls enhancements Alexey Makhalov
2024-05-06 21:52 ` [PATCH v9 1/8] x86/vmware: Move common macros to vmware.h Alexey Makhalov
2024-05-07 9:14 ` Borislav Petkov
2024-05-09 22:57 ` Alexey Makhalov
2024-05-06 21:52 ` [PATCH v9 2/8] x86/vmware: Correct macro names Alexey Makhalov
2024-05-06 21:53 ` [PATCH v9 3/8] x86/vmware: Introduce VMware hypercall API Alexey Makhalov
2024-05-07 9:58 ` Borislav Petkov [this message]
2024-05-09 23:42 ` Alexey Makhalov
2024-05-10 5:24 ` kernel test robot
2024-05-11 15:02 ` Simon Horman
2024-05-06 21:53 ` [PATCH v9 4/8] ptp/vmware: Use " Alexey Makhalov
2024-05-06 21:53 ` [PATCH v9 5/8] input/vmmouse: " Alexey Makhalov
2024-05-06 21:53 ` [PATCH v9 6/8] drm/vmwgfx: " Alexey Makhalov
2024-05-10 7:31 ` kernel test robot
2024-05-06 21:53 ` [PATCH v9 7/8] x86/vmware: Undefine VMWARE_HYPERCALL Alexey Makhalov
2024-05-06 21:53 ` [PATCH v9 8/8] x86/vmware: Add TDX hypercall support Alexey Makhalov
2024-04-25 15:21 ` [PATCH v9 1/8] x86/vmware: Correct macro names Borislav Petkov
2024-04-25 17:27 ` Alexey Makhalov
2024-04-22 22:56 ` [PATCH v8 2/7] x86/vmware: Introduce VMware hypercall API Alexey Makhalov
2024-04-22 22:56 ` [PATCH v8 3/7] ptp/vmware: Use " Alexey Makhalov
2024-04-22 22:56 ` [PATCH v8 4/7] input/vmmouse: " Alexey Makhalov
2024-04-22 22:56 ` [PATCH v8 5/7] drm/vmwgfx: " Alexey Makhalov
2024-04-22 22:56 ` [PATCH v8 6/7] x86/vmware: Undefine VMWARE_HYPERCALL Alexey Makhalov
2024-04-22 22:56 ` [PATCH v8 7/7] x86/vmware: Add TDX hypercall support Alexey Makhalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240507095852.GVZjn7XM0VMXzBfKsd@fat_crate.local \
--to=bp@alien8.de \
--cc=airlied@gmail.com \
--cc=akaher@vmware.com \
--cc=alexey.makhalov@broadcom.com \
--cc=daniel@ffwll.ch \
--cc=dave.hansen@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=horms@kernel.org \
--cc=hpa@zytor.com \
--cc=jsipek@vmware.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-graphics-maintainer@vmware.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mingo@redhat.com \
--cc=mripard@kernel.org \
--cc=nadav.amit@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=richardcochran@gmail.com \
--cc=tglx@linutronix.de \
--cc=timothym@vmware.com \
--cc=tzimmermann@suse.de \
--cc=virtualization@lists.linux.dev \
--cc=x86@kernel.org \
--cc=zackr@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).