From: Lee Jones <lee@kernel.org>
To: "Daniel Thompson" <daniel.thompson@linaro.org>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Helge Deller" <deller@gmx.de>,
"Bruno Prémont" <bonbons@linux-vserver.org>,
"Jiri Kosina" <jikos@kernel.org>,
"Benjamin Tissoires" <bentiss@kernel.org>,
"Alexander Shiyan" <shc_work@mail.ru>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Shawn Guo" <shawnguo@kernel.org>,
"Fabio Estevam" <festevam@gmail.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
linux-omap@vger.kernel.org,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Thomas Weißschuh" <linux@weissschuh.net>
Subject: Re: [PATCH v2 00/19] backlight: Constify lcd_ops
Date: Fri, 3 May 2024 10:55:12 +0100 [thread overview]
Message-ID: <20240503095512.GQ1227636@google.com> (raw)
In-Reply-To: <20240503094319.GP1227636@google.com>
On Fri, 03 May 2024, Lee Jones wrote:
> On Fri, 03 May 2024, Lee Jones wrote:
>
> > On Wed, 24 Apr 2024 08:33:26 +0200, Krzysztof Kozlowski wrote:
> > > Changes in v2:
> > > - Collect tags, including wrongly places Thomas' tag (which requires me
> > > to manually edit 15 other patches to drop it).
> > > - Combine here checkpatch patch:
> > > https://lore.kernel.org/all/20240414185440.288812-1-krzk@kernel.org/
> > > - Link to v1: https://lore.kernel.org/r/20240414-video-backlight-lcd-ops-v1-0-9b37fcbf546a@kernel.org
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > [01/19] backlight: Constify lcd_ops
> > commit: 9258e31adebf0ccf0797867841f3f9800695dba2
> > [02/19] backlight: ams369fg06: Constify lcd_ops
> > commit: 8053c4fa200c3fef07859bac9469ad3f26f5aba1
> > [03/19] backlight: corgi_lcd: Constify lcd_ops
> > commit: 18c5d4ab9f6312f2c9c6c409287d552112db810a
> > [04/19] backlight: hx8357: Constify lcd_ops
> > commit: 1d669c1998b559393ec2eaac0449f4989a255049
> > [05/19] backlight: ili922x: Constify lcd_ops
> > commit: e77fef89de954b1557cb91b64696cd4fc06c80ad
> > [06/19] backlight: ili9320: Constify lcd_ops
> > commit: 06cfc92faa1eabb2ea226c58d6fd0b5ab117ee39
> > [07/19] backlight: jornada720_lcd: Constify lcd_ops
> > commit: a54b4999dc204bc5839bb70602078c7c8e4a5010
> > [08/19] backlight: l4f00242t03: Constify lcd_ops
> > commit: 657e6c1b270e9f4a890059f5d08a08ea842fa1a8
> > [09/19] backlight: lms283gf05: Constify lcd_ops
> > commit: 66e5a10818fd332e973d36429e36f4c436a86a91
> > [10/19] backlight: lms501kf03: Constify lcd_ops
> > commit: 31c205d1e8426dd0cce0143c500ff1ff71fe64d1
> > [11/19] backlight: ltv350qv: Constify lcd_ops
> > commit: 24424f84d7568d9d794657622e080b1cba1e9290
> > [12/19] backlight: otm3225a: Constify lcd_ops
> > commit: 02949072ee8fb6141cd8ac2be9867ef466580ddb
> > [13/19] backlight: platform_lcd: Constify lcd_ops
> > commit: d217a8d5a39851caa16996756682715c9debb4a9
> > [14/19] backlight: tdo24m: Constify lcd_ops
> > commit: c7a1809d1982f671e66a4b1c1ffd8bdd5ba260aa
> > [15/19] HID: picoLCD: Constify lcd_ops
> > commit: 238724635763e7c5d82c0581b0c49e5dfdd5505a
> > [16/19] fbdev: clps711x: Constify lcd_ops
> > commit: 55d9a955375af3b3fd5725a9b5cbc658d4bdd244
> > [17/19] fbdev: imx: Constify lcd_ops
> > commit: a6abbb5783345c4c7cc9fbd583b81e167bd0207d
> > [18/19] fbdev: omap: lcd_ams_delta: Constify lcd_ops
> > commit: ca991e8e096c9f0cff0300289e2d4813192b8ef3
> > [19/19] const_structs.checkpatch: add lcd_ops
> > commit: f02aeccbec6108d768f54d31e7cb48b06c0e3814
>
> Please ensure you use checkpatch.pl before submitting:
>
> ====
>
> ERROR: Does not appear to be a unified-diff format patch
>
> total: 1 errors, 0 warnings, 0 lines checked
>
> NOTE: For some of the reported defects, checkpatch may be able to
> mechanically convert to the typical style using --fix or --fix-inplace.
>
> "[PATCH v2 19/19] const_structs.checkpatch: add lcd_ops" has style problems, please review.
>
> NOTE: If any of the errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.
> WARNING: Missing commit description - Add an appropriate one
>
> ERROR: Missing Signed-off-by: line(s)
>
> total: 1 errors, 1 warnings, 7 lines checked
>
> NOTE: For some of the reported defects, checkpatch may be able to
> mechanically convert to the typical style using --fix or --fix-inplace.
>
> Your patch has style problems, please review.
>
> NOTE: If any of the errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.
>
> ====
>
> Some of them are a little odd. I fixed the relevant ones
Change of plan - I actually can't find anything to fix.
All of this reports seem bogus!
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-05-03 9:55 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 6:33 [PATCH v2 00/19] backlight: Constify lcd_ops Krzysztof Kozlowski
2024-04-24 6:33 ` [PATCH v2 01/19] " Krzysztof Kozlowski
2024-04-24 6:33 ` [PATCH v2 02/19] backlight: ams369fg06: " Krzysztof Kozlowski
2024-04-24 6:33 ` [PATCH v2 03/19] backlight: corgi_lcd: " Krzysztof Kozlowski
2024-04-24 6:33 ` [PATCH v2 04/19] backlight: hx8357: " Krzysztof Kozlowski
2024-04-24 6:33 ` [PATCH v2 05/19] backlight: ili922x: " Krzysztof Kozlowski
2024-04-24 6:33 ` [PATCH v2 06/19] backlight: ili9320: " Krzysztof Kozlowski
2024-04-24 6:33 ` [PATCH v2 07/19] backlight: jornada720_lcd: " Krzysztof Kozlowski
2024-04-24 6:33 ` [PATCH v2 08/19] backlight: l4f00242t03: " Krzysztof Kozlowski
2024-04-24 6:33 ` [PATCH v2 09/19] backlight: lms283gf05: " Krzysztof Kozlowski
2024-04-24 6:33 ` [PATCH v2 10/19] backlight: lms501kf03: " Krzysztof Kozlowski
2024-04-24 6:33 ` [PATCH v2 11/19] backlight: ltv350qv: " Krzysztof Kozlowski
2024-04-24 6:33 ` [PATCH v2 12/19] backlight: otm3225a: " Krzysztof Kozlowski
2024-04-24 6:33 ` [PATCH v2 13/19] backlight: platform_lcd: " Krzysztof Kozlowski
2024-04-24 6:33 ` [PATCH v2 14/19] backlight: tdo24m: " Krzysztof Kozlowski
2024-04-24 6:33 ` [PATCH v2 15/19] HID: picoLCD: " Krzysztof Kozlowski
2024-04-24 6:33 ` [PATCH v2 16/19] fbdev: clps711x: " Krzysztof Kozlowski
2024-04-24 6:33 ` [PATCH v2 17/19] fbdev: imx: " Krzysztof Kozlowski
2024-04-24 7:05 ` Peng Fan
2024-04-24 6:33 ` [PATCH v2 18/19] fbdev: omap: lcd_ams_delta: " Krzysztof Kozlowski
2024-04-24 6:33 ` [PATCH v2 19/19] const_structs.checkpatch: add lcd_ops Krzysztof Kozlowski
2024-04-24 10:08 ` Daniel Thompson
2024-05-02 7:21 ` Lee Jones
2024-05-02 7:22 ` [PATCH v2 00/19] backlight: Constify lcd_ops Lee Jones
2024-05-02 7:47 ` Krzysztof Kozlowski
2024-05-03 9:41 ` Lee Jones
2024-05-03 9:43 ` Lee Jones
2024-05-03 9:55 ` Lee Jones [this message]
2024-05-10 14:55 ` [GIT PULL] Immutable branch between Backlight, HID and fbdev due for the v6.10 merge window Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240503095512.GQ1227636@google.com \
--to=lee@kernel.org \
--cc=bentiss@kernel.org \
--cc=bonbons@linux-vserver.org \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jikos@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shc_work@mail.ru \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).