From: Boris Brezillon <boris.brezillon@collabora.com>
To: Steven Price <steven.price@arm.com>
Cc: "Liviu Dudau" <liviu.dudau@arm.com>,
"Adrián Larumbe" <adrian.larumbe@collabora.com>,
dri-devel@lists.freedesktop.org, kernel@collabora.com
Subject: Re: [PATCH] drm/panthor: Kill the faulty_slots variable in panthor_sched_suspend()
Date: Thu, 2 May 2024 17:59:40 +0200 [thread overview]
Message-ID: <20240502175940.6f1142dd@collabora.com> (raw)
In-Reply-To: <093eec5f-1c47-4481-bf0a-567441fd6bc3@arm.com>
On Thu, 25 Apr 2024 12:18:29 +0100
Steven Price <steven.price@arm.com> wrote:
> On 25/04/2024 11:39, Boris Brezillon wrote:
> > We can use upd_ctx.timedout_mask directly, and the faulty_slots update
> > in the flush_caches_failed situation is never used.
> >
> > Suggested-by: Suggested-by: Steven Price <steven.price@arm.com>
>
> I'm obviously too full of suggestions! ;)
Pushed to drm-misc-next-fixes, but I realize I forgot to drop the extra
Suggested-by. Oh well.
>
> And you're doing a much better job of my todo list than I am!
>
> > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
>
> Reviewed-by: Steven Price <steven.price@arm.com>
>
> > ---
> > drivers/gpu/drm/panthor/panthor_sched.c | 10 +++-------
> > 1 file changed, 3 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c
> > index fad4678ca4c8..fed28c16d5d1 100644
> > --- a/drivers/gpu/drm/panthor/panthor_sched.c
> > +++ b/drivers/gpu/drm/panthor/panthor_sched.c
> > @@ -2584,8 +2584,8 @@ void panthor_sched_suspend(struct panthor_device *ptdev)
> > {
> > struct panthor_scheduler *sched = ptdev->scheduler;
> > struct panthor_csg_slots_upd_ctx upd_ctx;
> > - u32 suspended_slots, faulty_slots;
> > struct panthor_group *group;
> > + u32 suspended_slots;
> > u32 i;
> >
> > mutex_lock(&sched->lock);
> > @@ -2605,10 +2605,9 @@ void panthor_sched_suspend(struct panthor_device *ptdev)
> >
> > csgs_upd_ctx_apply_locked(ptdev, &upd_ctx);
> > suspended_slots &= ~upd_ctx.timedout_mask;
> > - faulty_slots = upd_ctx.timedout_mask;
> >
> > - if (faulty_slots) {
> > - u32 slot_mask = faulty_slots;
> > + if (upd_ctx.timedout_mask) {
> > + u32 slot_mask = upd_ctx.timedout_mask;
> >
> > drm_err(&ptdev->base, "CSG suspend failed, escalating to termination");
> > csgs_upd_ctx_init(&upd_ctx);
> > @@ -2659,9 +2658,6 @@ void panthor_sched_suspend(struct panthor_device *ptdev)
> >
> > slot_mask &= ~BIT(csg_id);
> > }
> > -
> > - if (flush_caches_failed)
> > - faulty_slots |= suspended_slots;
> > }
> >
> > for (i = 0; i < sched->csg_slot_count; i++) {
>
next prev parent reply other threads:[~2024-05-02 15:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 10:39 [PATCH] drm/panthor: Kill the faulty_slots variable in panthor_sched_suspend() Boris Brezillon
2024-04-25 11:04 ` Erik Faye-Lund
2024-04-25 11:18 ` Steven Price
2024-05-02 15:59 ` Boris Brezillon [this message]
2024-04-26 11:56 ` Liviu Dudau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240502175940.6f1142dd@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=adrian.larumbe@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@collabora.com \
--cc=liviu.dudau@arm.com \
--cc=steven.price@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).