From: Lee Jones <lee@kernel.org>
To: Shresth Prasad <shresthprasad7@gmail.com>
Cc: daniel.thompson@linaro.org, jingoohan1@gmail.com, deller@gmx.de,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, javier.carrasco.cruz@gmail.com,
skhan@linuxfoundation.org, julia.lawall@inria.fr
Subject: Re: [PATCH v3][next] backlight: sky81452-backlight: Remove unnecessary call to of_node_get
Date: Thu, 2 May 2024 11:35:48 +0100 [thread overview]
Message-ID: <20240502103548.GU5338@google.com> (raw)
In-Reply-To: <20240502100822.GS5338@google.com>
On Thu, 02 May 2024, Lee Jones wrote:
> On Thu, 02 May 2024, Shresth Prasad wrote:
>
> > On Thu, May 2, 2024 at 3:06 PM Lee Jones <lee@kernel.org> wrote:
> > >
> > > On Thu, 02 May 2024, Shresth Prasad wrote:
> > >
> > > > `dev->of_node` already has a reference to the device_node and calling
> > > > of_node_get on it is unnecessary. All conresponding calls to
> > > > of_node_put are also removed.
> > > >
> > > > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> > > > Signed-off-by: Shresth Prasad <shresthprasad7@gmail.com>
> > > > ---
> > > > Changes in v3:
> > > > - Remove unnecessary braces
> > > >
> > > > drivers/video/backlight/sky81452-backlight.c | 8 ++------
> > > > 1 file changed, 2 insertions(+), 6 deletions(-)
> > >
> > > No idea what you're talking about.
> > >
> > > This patch/version doesn't exist in either my inbox or LORE:
> > >
> > > https://lore.kernel.org/all/?q=%22%5BPATCH+v3%5D%5Bnext%5D+backlight%3A+sky81452-backlight%3A+Remove+unnecessary+call+to+of_node_get%22
> > >
> > > --
> > > Lee Jones [李琼斯]
> >
> > I'm not sure what you mean.
> > The patches show up just fine:
> > https://lore.kernel.org/all/?q=backlight%3A+sky81452-backlight%3A+Remove+unnecessary+call+to+of_node_get
> >
> > If you mean that the first version doesn't show up, it's because the
> > commit message
> > was changed to better reflect changes.
>
> Those are v2
>
> You replied to a non-existent v3 which started a new thread.
Something funky is going on. Your pokey emails are coming through
disconnected from the patches which is causing confusion.
The best thing going forward is to submit [RESEND]s instead of
contentless pokes.
Please submit a [RESEND] for v3 and we can start again.
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2024-05-02 10:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 6:36 [PATCH v3][next] backlight: sky81452-backlight: Remove unnecessary call to of_node_get Shresth Prasad
2024-05-02 9:36 ` Lee Jones
2024-05-02 10:00 ` Shresth Prasad
2024-05-02 10:08 ` Lee Jones
2024-05-02 10:35 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240502103548.GU5338@google.com \
--to=lee@kernel.org \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=julia.lawall@inria.fr \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shresthprasad7@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).