* [PATCH] drm/tests: Build KMS helpers when DRM_KUNIT_TEST_HELPERS is enabled
@ 2024-03-13 14:21 Karolina Stolarek
2024-03-15 10:34 ` Maxime Ripard
0 siblings, 1 reply; 2+ messages in thread
From: Karolina Stolarek @ 2024-03-13 14:21 UTC (permalink / raw
To: dri-devel; +Cc: Karolina Stolarek, Maxime Ripard, Maíra Canal
Commit 66671944e176 ("drm/tests: helpers: Add atomic helpers")
introduced a dependency on CRTC helpers in KUnit test helpers.
Select the former when building KUnit test helpers to avoid
linker errors.
Fixes: 66671944e176 ("drm/tests: helpers: Add atomic helpers")
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Maíra Canal <mcanal@igalia.com>
Signed-off-by: Karolina Stolarek <karolina.stolarek@intel.com>
---
Run into this when trying to run TTM KUnit tests. As for now,
TTM KUnit test suite are the only outside user of these helpers,
but I think it makes sense to explicitly select DRM_KMS_HELPER
together with DRM_KUNIT_TEST_HELPERS, instead of doing it in
DRM_TTM_KUNIT_TEST.
drivers/gpu/drm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index c08e18108c2a..91776996ada4 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -68,6 +68,7 @@ config DRM_USE_DYNAMIC_DEBUG
config DRM_KUNIT_TEST_HELPERS
tristate
depends on DRM && KUNIT
+ select DRM_KMS_HELPER
help
KUnit Helpers for KMS drivers.
@@ -80,7 +81,6 @@ config DRM_KUNIT_TEST
select DRM_EXEC
select DRM_EXPORT_FOR_TESTS if m
select DRM_GEM_SHMEM_HELPER
- select DRM_KMS_HELPER
select DRM_KUNIT_TEST_HELPERS
select DRM_LIB_RANDOM
select PRIME_NUMBERS
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/tests: Build KMS helpers when DRM_KUNIT_TEST_HELPERS is enabled
2024-03-13 14:21 [PATCH] drm/tests: Build KMS helpers when DRM_KUNIT_TEST_HELPERS is enabled Karolina Stolarek
@ 2024-03-15 10:34 ` Maxime Ripard
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2024-03-15 10:34 UTC (permalink / raw
To: dri-devel, Karolina Stolarek; +Cc: Maíra Canal
On Wed, 13 Mar 2024 15:21:42 +0100, Karolina Stolarek wrote:
> Commit 66671944e176 ("drm/tests: helpers: Add atomic helpers")
> introduced a dependency on CRTC helpers in KUnit test helpers.
> Select the former when building KUnit test helpers to avoid
> linker errors.
>
>
Applied to misc/kernel.git (drm-misc-next-fixes).
Thanks!
Maxime
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-15 10:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-13 14:21 [PATCH] drm/tests: Build KMS helpers when DRM_KUNIT_TEST_HELPERS is enabled Karolina Stolarek
2024-03-15 10:34 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).