* [PATCH -next] drm: bridge: dw_hdmi: clean up some inconsistent indentings
@ 2023-08-07 0:42 Yang Li
2023-08-07 19:55 ` Robert Foss
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2023-08-07 0:42 UTC (permalink / raw
To: airlied, daniel, andrzej.hajda, neil.armstrong, rfoss
Cc: jernej.skrabec, jonas, Abaci Robot, linux-kernel, dri-devel,
Yang Li, Laurent.pinchart
drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c:332 dw_hdmi_cec_suspend() warn: inconsistent indenting
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6101
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
index be21c11de1f2..14640b219dfa 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
@@ -329,9 +329,9 @@ static int __maybe_unused dw_hdmi_cec_suspend(struct device *dev)
struct dw_hdmi_cec *cec = dev_get_drvdata(dev);
/* store interrupt status/mask registers */
- cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
- cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
- cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);
+ cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
+ cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
+ cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);
return 0;
}
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] drm: bridge: dw_hdmi: clean up some inconsistent indentings
2023-08-07 0:42 [PATCH -next] drm: bridge: dw_hdmi: clean up some inconsistent indentings Yang Li
@ 2023-08-07 19:55 ` Robert Foss
0 siblings, 0 replies; 2+ messages in thread
From: Robert Foss @ 2023-08-07 19:55 UTC (permalink / raw
To: Yang Li
Cc: neil.armstrong, jonas, dri-devel, Abaci Robot, linux-kernel,
jernej.skrabec, Laurent.pinchart, andrzej.hajda
On Mon, Aug 7, 2023 at 2:43 AM Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c:332 dw_hdmi_cec_suspend() warn: inconsistent indenting
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6101
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
> index be21c11de1f2..14640b219dfa 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
> @@ -329,9 +329,9 @@ static int __maybe_unused dw_hdmi_cec_suspend(struct device *dev)
> struct dw_hdmi_cec *cec = dev_get_drvdata(dev);
>
> /* store interrupt status/mask registers */
> - cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
> - cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
> - cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);
> + cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
> + cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
> + cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);
>
> return 0;
> }
NAK
The value of maintaining the git blame history is higher than
following the correct whitespace
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-07 19:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-07 0:42 [PATCH -next] drm: bridge: dw_hdmi: clean up some inconsistent indentings Yang Li
2023-08-07 19:55 ` Robert Foss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).