* [PATCH -next v2 0/2] drm: Do not check for 0 return after calling platform_get_irq()
@ 2023-08-03 4:03 Ruan Jinjie
2023-08-03 4:03 ` [PATCH -next v2 1/2] drm/panfrost: Do not check for 0 return after calling platform_get_irq_byname() Ruan Jinjie
2023-08-03 4:04 ` [PATCH -next v2 2/2] drm/mediatek: Do not check for 0 return after calling platform_get_irq() Ruan Jinjie
0 siblings, 2 replies; 4+ messages in thread
From: Ruan Jinjie @ 2023-08-03 4:03 UTC (permalink / raw
To: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg,
angelogioacchino.delregno, robh, tomeu.vizoso, steven.price,
alyssa.rosenzweig, dri-devel, linux-mediatek, linux-arm-kernel
Cc: ruanjinjie
Since commit a85a6c86c25b ("driver core: platform: Clarify that
IRQ 0 is invalid"), there is no possible both for platform_get_irq()
and platform_get_irq_byname() to return 0.
And the return value of platform_get_irq() or platform_get_irq_byname()
is more sensible to show the error reason.
Changes in v2:
- Update the cover letter to fix the style warning.
Ruan Jinjie (2):
drm/panfrost: Do not check for 0 return after calling
platform_get_irq_byname()
drm/mediatek: Do not check for 0 return after calling
platform_get_irq()
drivers/gpu/drm/mediatek/mtk_dpi.c | 4 ++--
drivers/gpu/drm/panfrost/panfrost_gpu.c | 4 ++--
drivers/gpu/drm/panfrost/panfrost_job.c | 4 ++--
drivers/gpu/drm/panfrost/panfrost_mmu.c | 4 ++--
4 files changed, 8 insertions(+), 8 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH -next v2 1/2] drm/panfrost: Do not check for 0 return after calling platform_get_irq_byname()
2023-08-03 4:03 [PATCH -next v2 0/2] drm: Do not check for 0 return after calling platform_get_irq() Ruan Jinjie
@ 2023-08-03 4:03 ` Ruan Jinjie
2023-08-21 14:11 ` Steven Price
2023-08-03 4:04 ` [PATCH -next v2 2/2] drm/mediatek: Do not check for 0 return after calling platform_get_irq() Ruan Jinjie
1 sibling, 1 reply; 4+ messages in thread
From: Ruan Jinjie @ 2023-08-03 4:03 UTC (permalink / raw
To: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg,
angelogioacchino.delregno, robh, tomeu.vizoso, steven.price,
alyssa.rosenzweig, dri-devel, linux-mediatek, linux-arm-kernel
Cc: ruanjinjie
It is not possible for platform_get_irq_byname() to return 0.
Use the return value from platform_get_irq_byname().
Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
---
drivers/gpu/drm/panfrost/panfrost_gpu.c | 4 ++--
drivers/gpu/drm/panfrost/panfrost_job.c | 4 ++--
drivers/gpu/drm/panfrost/panfrost_mmu.c | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c b/drivers/gpu/drm/panfrost/panfrost_gpu.c
index d28b99732dde..2faa344d89ee 100644
--- a/drivers/gpu/drm/panfrost/panfrost_gpu.c
+++ b/drivers/gpu/drm/panfrost/panfrost_gpu.c
@@ -390,8 +390,8 @@ int panfrost_gpu_init(struct panfrost_device *pfdev)
dma_set_max_seg_size(pfdev->dev, UINT_MAX);
irq = platform_get_irq_byname(to_platform_device(pfdev->dev), "gpu");
- if (irq <= 0)
- return -ENODEV;
+ if (irq < 0)
+ return irq;
err = devm_request_irq(pfdev->dev, irq, panfrost_gpu_irq_handler,
IRQF_SHARED, KBUILD_MODNAME "-gpu", pfdev);
diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c
index dbc597ab46fb..3322b3024937 100644
--- a/drivers/gpu/drm/panfrost/panfrost_job.c
+++ b/drivers/gpu/drm/panfrost/panfrost_job.c
@@ -794,8 +794,8 @@ int panfrost_job_init(struct panfrost_device *pfdev)
spin_lock_init(&js->job_lock);
js->irq = platform_get_irq_byname(to_platform_device(pfdev->dev), "job");
- if (js->irq <= 0)
- return -ENODEV;
+ if (js->irq < 0)
+ return js->irq;
ret = devm_request_threaded_irq(pfdev->dev, js->irq,
panfrost_job_irq_handler,
diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.c b/drivers/gpu/drm/panfrost/panfrost_mmu.c
index c0123d09f699..d54d4e7b2195 100644
--- a/drivers/gpu/drm/panfrost/panfrost_mmu.c
+++ b/drivers/gpu/drm/panfrost/panfrost_mmu.c
@@ -755,8 +755,8 @@ int panfrost_mmu_init(struct panfrost_device *pfdev)
int err, irq;
irq = platform_get_irq_byname(to_platform_device(pfdev->dev), "mmu");
- if (irq <= 0)
- return -ENODEV;
+ if (irq < 0)
+ return irq;
err = devm_request_threaded_irq(pfdev->dev, irq,
panfrost_mmu_irq_handler,
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH -next v2 2/2] drm/mediatek: Do not check for 0 return after calling platform_get_irq()
2023-08-03 4:03 [PATCH -next v2 0/2] drm: Do not check for 0 return after calling platform_get_irq() Ruan Jinjie
2023-08-03 4:03 ` [PATCH -next v2 1/2] drm/panfrost: Do not check for 0 return after calling platform_get_irq_byname() Ruan Jinjie
@ 2023-08-03 4:04 ` Ruan Jinjie
1 sibling, 0 replies; 4+ messages in thread
From: Ruan Jinjie @ 2023-08-03 4:04 UTC (permalink / raw
To: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg,
angelogioacchino.delregno, robh, tomeu.vizoso, steven.price,
alyssa.rosenzweig, dri-devel, linux-mediatek, linux-arm-kernel
Cc: ruanjinjie
It is not possible for platform_get_irq() to return 0. Use the
return value from platform_get_irq().
Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
---
drivers/gpu/drm/mediatek/mtk_dpi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
index 28bdb1f427ff..641a43ae4e6f 100644
--- a/drivers/gpu/drm/mediatek/mtk_dpi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
@@ -1073,8 +1073,8 @@ static int mtk_dpi_probe(struct platform_device *pdev)
}
dpi->irq = platform_get_irq(pdev, 0);
- if (dpi->irq <= 0)
- return -EINVAL;
+ if (dpi->irq < 0)
+ return dpi->irq;
ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0,
NULL, &dpi->next_bridge);
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next v2 1/2] drm/panfrost: Do not check for 0 return after calling platform_get_irq_byname()
2023-08-03 4:03 ` [PATCH -next v2 1/2] drm/panfrost: Do not check for 0 return after calling platform_get_irq_byname() Ruan Jinjie
@ 2023-08-21 14:11 ` Steven Price
0 siblings, 0 replies; 4+ messages in thread
From: Steven Price @ 2023-08-21 14:11 UTC (permalink / raw
To: Ruan Jinjie, chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg,
angelogioacchino.delregno, robh, dri-devel, linux-mediatek,
linux-arm-kernel
On 03/08/2023 05:03, Ruan Jinjie wrote:
> It is not possible for platform_get_irq_byname() to return 0.
> Use the return value from platform_get_irq_byname().
>
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Reviewed-by: Steven Price <steven.price@arm.com>
I'll push this to drm-misc-next.
Thanks,
Steve
> ---
> drivers/gpu/drm/panfrost/panfrost_gpu.c | 4 ++--
> drivers/gpu/drm/panfrost/panfrost_job.c | 4 ++--
> drivers/gpu/drm/panfrost/panfrost_mmu.c | 4 ++--
> 3 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c b/drivers/gpu/drm/panfrost/panfrost_gpu.c
> index d28b99732dde..2faa344d89ee 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_gpu.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_gpu.c
> @@ -390,8 +390,8 @@ int panfrost_gpu_init(struct panfrost_device *pfdev)
> dma_set_max_seg_size(pfdev->dev, UINT_MAX);
>
> irq = platform_get_irq_byname(to_platform_device(pfdev->dev), "gpu");
> - if (irq <= 0)
> - return -ENODEV;
> + if (irq < 0)
> + return irq;
>
> err = devm_request_irq(pfdev->dev, irq, panfrost_gpu_irq_handler,
> IRQF_SHARED, KBUILD_MODNAME "-gpu", pfdev);
> diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c
> index dbc597ab46fb..3322b3024937 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_job.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_job.c
> @@ -794,8 +794,8 @@ int panfrost_job_init(struct panfrost_device *pfdev)
> spin_lock_init(&js->job_lock);
>
> js->irq = platform_get_irq_byname(to_platform_device(pfdev->dev), "job");
> - if (js->irq <= 0)
> - return -ENODEV;
> + if (js->irq < 0)
> + return js->irq;
>
> ret = devm_request_threaded_irq(pfdev->dev, js->irq,
> panfrost_job_irq_handler,
> diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.c b/drivers/gpu/drm/panfrost/panfrost_mmu.c
> index c0123d09f699..d54d4e7b2195 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_mmu.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_mmu.c
> @@ -755,8 +755,8 @@ int panfrost_mmu_init(struct panfrost_device *pfdev)
> int err, irq;
>
> irq = platform_get_irq_byname(to_platform_device(pfdev->dev), "mmu");
> - if (irq <= 0)
> - return -ENODEV;
> + if (irq < 0)
> + return irq;
>
> err = devm_request_threaded_irq(pfdev->dev, irq,
> panfrost_mmu_irq_handler,
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-21 14:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-03 4:03 [PATCH -next v2 0/2] drm: Do not check for 0 return after calling platform_get_irq() Ruan Jinjie
2023-08-03 4:03 ` [PATCH -next v2 1/2] drm/panfrost: Do not check for 0 return after calling platform_get_irq_byname() Ruan Jinjie
2023-08-21 14:11 ` Steven Price
2023-08-03 4:04 ` [PATCH -next v2 2/2] drm/mediatek: Do not check for 0 return after calling platform_get_irq() Ruan Jinjie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).