From: kernel test robot <lkp@intel.com>
To: Jason Ekstrand <jason@jlekstrand.net>,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: clang-built-linux@googlegroups.com, kbuild-all@lists.01.org
Subject: Re: [Intel-gfx] [PATCH 30/31] drm/i915: Finalize contexts in GEM_CONTEXT_CREATE on version 13+
Date: Wed, 9 Jun 2021 18:13:26 +0800 [thread overview]
Message-ID: <202106091829.b26u6VeR-lkp@intel.com> (raw)
In-Reply-To: <20210609043613.102962-31-jason@jlekstrand.net>
[-- Attachment #1: Type: text/plain, Size: 6290 bytes --]
Hi Jason,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-tip/drm-tip]
[cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next drm/drm-next v5.13-rc5 next-20210608]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jason-Ekstrand/drm-i915-gem-ioctl-clean-ups-v6/20210609-123926
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: x86_64-randconfig-r011-20210608 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project d2012d965d60c3258b3a69d024491698f8aec386)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/48a06ef4f7f3fbb4b4768b25829796cf235de32c
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jason-Ekstrand/drm-i915-gem-ioctl-clean-ups-v6/20210609-123926
git checkout 48a06ef4f7f3fbb4b4768b25829796cf235de32c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/gpu/drm/i915/gem/i915_gem_context.c:1910:1: error: no previous prototype for function 'finalize_create_context_locked' [-Werror,-Wmissing-prototypes]
finalize_create_context_locked(struct drm_i915_file_private *file_priv,
^
drivers/gpu/drm/i915/gem/i915_gem_context.c:1909:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
struct i915_gem_context *
^
static
>> drivers/gpu/drm/i915/gem/i915_gem_context.c:2007:45: error: variable 'id' is uninitialized when used here [-Werror,-Wuninitialized]
gem_context_register(ctx, ext_data.fpriv, id);
^~
drivers/gpu/drm/i915/gem/i915_gem_context.c:1964:8: note: initialize the variable 'id' to silence this warning
u32 id;
^
= 0
2 errors generated.
vim +/id +2007 drivers/gpu/drm/i915/gem/i915_gem_context.c
1908
1909 struct i915_gem_context *
> 1910 finalize_create_context_locked(struct drm_i915_file_private *file_priv,
1911 struct i915_gem_proto_context *pc, u32 id)
1912 {
1913 struct i915_gem_context *ctx;
1914 void *old;
1915
1916 lockdep_assert_held(&file_priv->proto_context_lock);
1917
1918 ctx = i915_gem_create_context(file_priv->dev_priv, pc);
1919 if (IS_ERR(ctx))
1920 return ctx;
1921
1922 gem_context_register(ctx, file_priv, id);
1923
1924 old = xa_erase(&file_priv->proto_context_xa, id);
1925 GEM_BUG_ON(old != pc);
1926 proto_context_close(pc);
1927
1928 /* One for the xarray and one for the caller */
1929 return i915_gem_context_get(ctx);
1930 }
1931
1932 struct i915_gem_context *
1933 i915_gem_context_lookup(struct drm_i915_file_private *file_priv, u32 id)
1934 {
1935 struct i915_gem_proto_context *pc;
1936 struct i915_gem_context *ctx;
1937
1938 ctx = __context_lookup(file_priv, id);
1939 if (ctx)
1940 return ctx;
1941
1942 mutex_lock(&file_priv->proto_context_lock);
1943 /* Try one more time under the lock */
1944 ctx = __context_lookup(file_priv, id);
1945 if (!ctx) {
1946 pc = xa_load(&file_priv->proto_context_xa, id);
1947 if (!pc)
1948 ctx = ERR_PTR(-ENOENT);
1949 else
1950 ctx = finalize_create_context_locked(file_priv, pc, id);
1951 }
1952 mutex_unlock(&file_priv->proto_context_lock);
1953
1954 return ctx;
1955 }
1956
1957 int i915_gem_context_create_ioctl(struct drm_device *dev, void *data,
1958 struct drm_file *file)
1959 {
1960 struct drm_i915_private *i915 = to_i915(dev);
1961 struct drm_i915_gem_context_create_ext *args = data;
1962 struct create_ext ext_data;
1963 int ret;
1964 u32 id;
1965
1966 if (!DRIVER_CAPS(i915)->has_logical_contexts)
1967 return -ENODEV;
1968
1969 if (args->flags & I915_CONTEXT_CREATE_FLAGS_UNKNOWN)
1970 return -EINVAL;
1971
1972 ret = intel_gt_terminally_wedged(&i915->gt);
1973 if (ret)
1974 return ret;
1975
1976 ext_data.fpriv = file->driver_priv;
1977 if (client_is_banned(ext_data.fpriv)) {
1978 drm_dbg(&i915->drm,
1979 "client %s[%d] banned from creating ctx\n",
1980 current->comm, task_pid_nr(current));
1981 return -EIO;
1982 }
1983
1984 ext_data.pc = proto_context_create(i915, args->flags);
1985 if (IS_ERR(ext_data.pc))
1986 return PTR_ERR(ext_data.pc);
1987
1988 if (args->flags & I915_CONTEXT_CREATE_FLAGS_USE_EXTENSIONS) {
1989 ret = i915_user_extensions(u64_to_user_ptr(args->extensions),
1990 create_extensions,
1991 ARRAY_SIZE(create_extensions),
1992 &ext_data);
1993 if (ret)
1994 goto err_pc;
1995 }
1996
1997 if (GRAPHICS_VER(i915) > 12) {
1998 struct i915_gem_context *ctx;
1999
2000 ctx = i915_gem_create_context(i915, ext_data.pc);
2001 if (IS_ERR(ctx)) {
2002 ret = PTR_ERR(ctx);
2003 goto err_pc;
2004 }
2005
2006 proto_context_close(ext_data.pc);
> 2007 gem_context_register(ctx, ext_data.fpriv, id);
2008 } else {
2009 ret = proto_context_register(ext_data.fpriv, ext_data.pc, &id);
2010 if (ret < 0)
2011 goto err_pc;
2012 }
2013
2014 args->ctx_id = id;
2015 drm_dbg(&i915->drm, "HW context %d created\n", args->ctx_id);
2016
2017 return 0;
2018
2019 err_pc:
2020 proto_context_close(ext_data.pc);
2021 return ret;
2022 }
2023
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31235 bytes --]
next prev parent reply other threads:[~2021-06-09 10:13 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 4:35 [PATCH 00/31] drm/i915/gem: ioctl clean-ups (v6) Jason Ekstrand
2021-06-09 4:35 ` [PATCH 01/31] drm/i915: Drop I915_CONTEXT_PARAM_RINGSIZE Jason Ekstrand
2021-06-09 4:35 ` [PATCH 02/31] drm/i915: Stop storing the ring size in the ring pointer (v2) Jason Ekstrand
2021-06-09 4:35 ` [PATCH 03/31] drm/i915: Drop I915_CONTEXT_PARAM_NO_ZEROMAP Jason Ekstrand
2021-06-09 4:35 ` [PATCH 04/31] drm/i915/gem: Set the watchdog timeout directly in intel_context_set_gem (v2) Jason Ekstrand
2021-06-09 4:35 ` [PATCH 05/31] drm/i915/gem: Return void from context_apply_all Jason Ekstrand
2021-06-09 4:35 ` [PATCH 06/31] drm/i915: Drop the CONTEXT_CLONE API (v2) Jason Ekstrand
2021-06-09 4:35 ` [PATCH 07/31] drm/i915: Implement SINGLE_TIMELINE with a syncobj (v4) Jason Ekstrand
2021-06-09 4:35 ` [PATCH 08/31] drm/i915: Drop getparam support for I915_CONTEXT_PARAM_ENGINES Jason Ekstrand
2021-06-09 4:35 ` [PATCH 09/31] drm/i915/gem: Disallow bonding of virtual engines (v3) Jason Ekstrand
2021-06-09 4:35 ` [PATCH 10/31] drm/i915/gem: Remove engine auto-magic with FENCE_SUBMIT (v2) Jason Ekstrand
2021-06-09 4:35 ` [PATCH 11/31] drm/i915/request: Remove the hook from await_execution Jason Ekstrand
2021-06-09 4:35 ` [PATCH 12/31] drm/i915/gem: Disallow creating contexts with too many engines Jason Ekstrand
2021-06-09 4:35 ` [PATCH 13/31] drm/i915: Stop manually RCU banging in reset_stats_ioctl (v2) Jason Ekstrand
2021-06-09 4:35 ` [PATCH 14/31] drm/i915/gem: Add a separate validate_priority helper Jason Ekstrand
2021-06-09 4:35 ` [PATCH 15/31] drm/i915: Add gem/i915_gem_context.h to the docs Jason Ekstrand
2021-06-09 4:35 ` [PATCH 16/31] drm/i915/gem: Add an intermediate proto_context struct (v4) Jason Ekstrand
2021-06-09 11:28 ` [Intel-gfx] " Daniel Vetter
2021-06-09 16:00 ` Jason Ekstrand
2021-06-10 16:44 ` Daniel Vetter
2021-06-10 16:53 ` Jason Ekstrand
2021-06-09 4:35 ` [PATCH 17/31] drm/i915/gem: Rework error handling in default_engines Jason Ekstrand
2021-06-09 4:36 ` [PATCH 18/31] drm/i915/gem: Optionally set SSEU in intel_context_set_gem Jason Ekstrand
2021-06-09 4:36 ` [PATCH 19/31] drm/i915: Add an i915_gem_vm_lookup helper Jason Ekstrand
2021-06-09 4:36 ` [PATCH 20/31] drm/i915/gem: Make an alignment check more sensible Jason Ekstrand
2021-06-09 4:36 ` [PATCH 21/31] drm/i915/gem: Use the proto-context to handle create parameters (v3) Jason Ekstrand
2021-06-09 4:36 ` [PATCH 22/31] drm/i915/gem: Return an error ptr from context_lookup Jason Ekstrand
2021-06-09 4:36 ` [PATCH 23/31] drm/i915/gt: Drop i915_address_space::file (v2) Jason Ekstrand
2021-06-09 4:36 ` [PATCH 24/31] drm/i915/gem: Delay context creation (v2) Jason Ekstrand
2021-06-09 8:25 ` [Intel-gfx] " kernel test robot
2021-06-09 11:38 ` kernel test robot
2021-06-09 11:44 ` kernel test robot
2021-06-09 4:36 ` [PATCH 25/31] drm/i915/gem: Don't allow changing the VM on running contexts (v2) Jason Ekstrand
2021-06-09 7:39 ` [Intel-gfx] " kernel test robot
2021-06-09 11:34 ` Daniel Vetter
2021-06-09 11:34 ` Daniel Vetter
2021-06-09 16:06 ` Jason Ekstrand
2021-06-09 4:36 ` [PATCH 26/31] drm/i915/gem: Don't allow changing the engine set " Jason Ekstrand
2021-06-09 4:36 ` [PATCH 27/31] drm/i915/selftests: Take a VM in kernel_context() Jason Ekstrand
2021-06-09 4:36 ` [PATCH 28/31] i915/gem/selftests: Assign the VM at context creation in igt_shared_ctx_exec Jason Ekstrand
2021-06-09 4:36 ` [PATCH 29/31] drm/i915/gem: Roll all of context creation together Jason Ekstrand
2021-06-09 4:36 ` [PATCH 30/31] drm/i915: Finalize contexts in GEM_CONTEXT_CREATE on version 13+ Jason Ekstrand
2021-06-09 10:13 ` kernel test robot [this message]
2021-06-09 11:38 ` [Intel-gfx] " Daniel Vetter
2021-06-09 4:36 ` [PATCH 31/31] drm/i915: Drop some RCU usage around context VMs Jason Ekstrand
2021-06-09 11:41 ` [Intel-gfx] " Daniel Vetter
2021-06-09 16:07 ` Jason Ekstrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202106091829.b26u6VeR-lkp@intel.com \
--to=lkp@intel.com \
--cc=clang-built-linux@googlegroups.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jason@jlekstrand.net \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).