dri-devel Archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Vivek Kasireddy <vivek.kasireddy@intel.com>
Cc: Dongwon Kim <dongwon.kim@intel.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] udmabuf: Add support for mapping hugepages (v3)
Date: Wed, 9 Jun 2021 08:56:40 +0200	[thread overview]
Message-ID: <20210609065640.an5vxoup7yesenwb@sirius.home.kraxel.org> (raw)
In-Reply-To: <20210604205939.376598-1-vivek.kasireddy@intel.com>

  Hi,

> +					hpage = find_get_page_flags(

checkpatch doesn't like that:

-:76: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('

> +				page = shmem_read_mapping_page(

Same here.

take care,
  Gerd


  parent reply	other threads:[~2021-06-09  6:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03  8:52 [PATCH] udmabuf: Add support for mapping hugepages Vivek Kasireddy
2021-06-03  9:44 ` Gerd Hoffmann
2021-06-03 23:59   ` [PATCH] udmabuf: Add support for mapping hugepages (v2) Vivek Kasireddy
2021-06-04  5:59     ` Gerd Hoffmann
2021-06-04 20:59       ` [PATCH] udmabuf: Add support for mapping hugepages (v3) Vivek Kasireddy
2021-06-08 17:35         ` Dongwon Kim
2021-06-09  6:11           ` Gerd Hoffmann
2021-06-09  6:56         ` Gerd Hoffmann [this message]
2021-06-09 18:29           ` [PATCH] udmabuf: Add support for mapping hugepages (v4) Vivek Kasireddy
2021-06-10  6:01             ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210609065640.an5vxoup7yesenwb@sirius.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=dongwon.kim@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=vivek.kasireddy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).