From: "Rob Herring (Arm)" <robh@kernel.org>
To: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com>
Cc: devicetree@vger.kernel.org, benjamin.tissoires@redhat.co,
dmitry.torokhov@gmail.com, krzysztof.kozlowski+dt@linaro.org,
jikos@kernel.org, hsinyi@google.com, dianders@google.com,
dri-devel@lists.freedesktop.org, conor+dt@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] dt-bindings: input: i2c-hid: Introduce Ilitek ili2900
Date: Thu, 09 May 2024 03:17:23 -0500 [thread overview]
Message-ID: <171524264306.4104969.8390645355822762827.robh@kernel.org> (raw)
In-Reply-To: <20240509064336.9803-1-lvzhaoxiong@huaqin.corp-partner.google.com>
On Thu, 09 May 2024 14:43:35 +0800, Zhaoxiong Lv wrote:
> From: lvzhaoxiong <lvzhaoxiong@huaqin.corp-partner.google.com>
>
> The ili2900 touch screen chip same as ilitek ili9882t controller
> has a reset gpio.
>
> Signed-off-by: lvzhaoxiong <lvzhaoxiong@huaqin.corp-partner.google.com>
> ---
> Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml:22:5: [error] duplication of key "const" in mapping (key-duplicates)
dtschema/dtc warnings/errors:
make[2]: *** Deleting file 'Documentation/devicetree/bindings/input/ilitek,ili9882t.example.dts'
Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml:22:5: found duplicate key "const" with value "ilitek,ili2900" (original value: "ilitek,ili9882t")
make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/input/ilitek,ili9882t.example.dts] Error 1
make[2]: *** Waiting for unfinished jobs....
./Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml:22:5: found duplicate key "const" with value "ilitek,ili2900" (original value: "ilitek,ili9882t")
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml: ignoring, error parsing file
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2
make: *** [Makefile:240: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240509064336.9803-1-lvzhaoxiong@huaqin.corp-partner.google.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-05-09 8:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 6:43 [PATCH v1 1/2] dt-bindings: input: i2c-hid: Introduce Ilitek ili2900 Zhaoxiong Lv
2024-05-09 6:43 ` [PATCH v1 2/2] HID: i2c-hid: elan: Add ili2900 timing Zhaoxiong Lv
2024-05-09 14:34 ` Doug Anderson
2024-05-10 12:07 ` zhaoxiong lv
2024-05-09 6:48 ` [PATCH v1 1/2] dt-bindings: input: i2c-hid: Introduce Ilitek ili2900 zhaoxiong lv
2024-05-09 8:17 ` Rob Herring (Arm) [this message]
2024-05-09 8:33 ` Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2024-04-18 12:48 [PATCH v1 0/2] Add ili2900 timing lvzhaoxiong
2024-04-18 12:48 ` [PATCH v1 1/2] dt-bindings: input: i2c-hid: Introduce Ilitek ili2900 lvzhaoxiong
2024-04-18 14:17 ` Rob Herring
2024-04-18 22:55 ` Krzysztof Kozlowski
2024-04-19 0:09 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171524264306.4104969.8390645355822762827.robh@kernel.org \
--to=robh@kernel.org \
--cc=benjamin.tissoires@redhat.co \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@google.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hsinyi@google.com \
--cc=jikos@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvzhaoxiong@huaqin.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).