From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
<freedreno@lists.freedesktop.org>,
Rob Clark <robdclark@gmail.com>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
Sean Paul <sean@poorly.run>,
"Marijn Suijten" <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: <dri-devel@lists.freedesktop.org>, <seanpaul@chromium.org>,
<swboyd@chromium.org>, <quic_jesszhan@quicinc.com>,
<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Masahiro Yamada" <masahiroy@kernel.org>
Subject: Re: [PATCH] drm/msm: remove python 3.9 dependency for compiling msm
Date: Wed, 8 May 2024 09:52:31 -0700 [thread overview]
Message-ID: <0cf9d1ba-2c4f-0863-6f51-e76ee7846471@quicinc.com> (raw)
In-Reply-To: <87a5l0lmlv.fsf@intel.com>
On 5/8/2024 1:43 AM, Jani Nikula wrote:
> On Tue, 07 May 2024, Abhinav Kumar <quic_abhinavk@quicinc.com> wrote:
>> Since commit 5acf49119630 ("drm/msm: import gen_header.py script from Mesa"),
>> compilation is broken on machines having python versions older than 3.9
>> due to dependency on argparse.BooleanOptionalAction.
>
> Is it now okay to require Python for the build? Not listed in
> Documentation/process/changes.rst.
>
> BR,
> Jani.
>
The change to move gen_header.py to kernel is already part of the v6.10
pull request.
This change only fixes the version dependency.
But, I agree we should update the changes.rst (better late than never).
Dmitry, can you pls suggest which version we want to list there?
I am hoping that after this change there are no further dependencies on
python versions, so anything > EOL should be fine.
I am leaning towards v3.8
>
>
>>
>> Switch to use simple bool for the validate flag to remove the dependency.
>>
>> Fixes: 5acf49119630 ("drm/msm: import gen_header.py script from Mesa")
>> Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
>> ---
>> drivers/gpu/drm/msm/registers/gen_header.py | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/msm/registers/gen_header.py b/drivers/gpu/drm/msm/registers/gen_header.py
>> index fc3bfdc991d2..3926485bb197 100644
>> --- a/drivers/gpu/drm/msm/registers/gen_header.py
>> +++ b/drivers/gpu/drm/msm/registers/gen_header.py
>> @@ -538,7 +538,7 @@ class Parser(object):
>> self.variants.add(reg.domain)
>>
>> def do_validate(self, schemafile):
>> - if self.validate == False:
>> + if not self.validate:
>> return
>>
>> try:
>> @@ -948,7 +948,8 @@ def main():
>> parser = argparse.ArgumentParser()
>> parser.add_argument('--rnn', type=str, required=True)
>> parser.add_argument('--xml', type=str, required=True)
>> - parser.add_argument('--validate', action=argparse.BooleanOptionalAction)
>> + parser.add_argument('--validate', default=False, action='store_true')
>> + parser.add_argument('--no-validate', dest='validate', action='store_false')
>>
>> subparsers = parser.add_subparsers()
>> subparsers.required = True
>
next prev parent reply other threads:[~2024-05-08 16:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 23:04 [PATCH] drm/msm: remove python 3.9 dependency for compiling msm Abhinav Kumar
2024-05-08 8:43 ` Jani Nikula
2024-05-08 16:52 ` Abhinav Kumar [this message]
2024-05-08 22:00 ` Stephen Boyd
2024-05-09 0:28 ` Doug Anderson
2024-05-09 2:05 ` Masahiro Yamada
2024-05-09 13:07 ` Dmitry Baryshkov
2024-05-20 18:58 ` Doug Anderson
2024-05-30 16:54 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cf9d1ba-2c4f-0863-6f51-e76ee7846471@quicinc.com \
--to=quic_abhinavk@quicinc.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=masahiroy@kernel.org \
--cc=quic_jesszhan@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=seanpaul@chromium.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).