From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: "Mattias Rönnblom" <hofors@lysator.liu.se>
Cc: bugzilla@dpdk.org, dev@dpdk.org
Subject: Re: [DPDK/core Bug 1425] enable_stdatomic=true breaks C++ on GCC 11 and earlier
Date: Tue, 30 Apr 2024 13:37:14 -0700 [thread overview]
Message-ID: <20240430203714.GA7142@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <f88b14dc-373d-4917-a8fa-443f44481460@lysator.liu.se>
On Tue, Apr 30, 2024 at 10:06:08PM +0200, Mattias Rönnblom wrote:
> On 2024-04-30 01:14, Tyler Retzlaff wrote:
> >On Mon, Apr 29, 2024 at 06:21:13AM +0000, bugzilla@dpdk.org wrote:
> >>https://bugs.dpdk.org/show_bug.cgi?id=1425
> >>
> >> Bug ID: 1425
> >> Summary: enable_stdatomic=true breaks C++ on GCC 11 and
> >> earlier
> >> Product: DPDK
> >> Version: 23.11
> >> Hardware: All
> >> OS: Linux
> >> Status: UNCONFIRMED
> >> Severity: normal
> >> Priority: Normal
> >> Component: core
> >> Assignee: dev@dpdk.org
> >> Reporter: mattias.ronnblom@ericsson.com
> >> Target Milestone: ---
> >>
> >>On GCC 11 and earlier, configuring enable_stdatomic=true prevents the use of
> >>all DPDK header files that directly or indirectly include <rte_stdatomic.h>
> >>from a C++ translation unit (e.g., app).
> >>
> >><rte_stdatomic.h> includes <stdatomic.h>, which in turn is not necessarily
> >>C++-compatible.
> >
> >This is known but to add some information.
> >
>
> Is it also documented?
we don't document anything about C++ right now including minimum
compiler requirements or -std. i agree we probably should, if i find
cycles i'll see if i can provide some text.
>
> >C++ and enable_stdatomic=true for llvm and gcc are not currently
> >supported. the combination will remain unsupported for C++ compilers
> >that do not support -std=c++23 which is the first C++ standard that
> >requires interoperability with C11 stdatomic.h >
> >When enable_stdatomic=true there are bugs/incorrect usages of atomic
> >qualifier in casts that (even when using C++23) cause compilation
> >failure. These are a fixable but are low priority without -std=c++23.
> >
> >Finally, the legacy atomics remain unconverted to stdatomic. This will
> >cause enable_stdatomic=true not to build when using llvm (but not gcc)
> >because llvm strictly enforces qualification when using atomic generics.
> >
>
> OK, I see. It'll be a while until enable_stdatomic is usable outside
> Windows then, for generic builds.
>
> Am I right if I say that C++23-capable compilers/run-times are
> supposed to have a <stdatomic.h> which interoperates with C++ even
> in C++11-mode? Or need the application be compiled as C++23.
the application will need to be compiled with -std=C++23 though i think
llvm does have a stdatomic.h that may work with lower -std, gcc does
not last i checked. in general i think (as you found with _Generic) the
compiler vendors are limiting leaking of C into C++ and vice versa where
it is not explicitly intended to operate in one language or the other.
i'll be looking into this more beyond 24.07 since there is work to do
even consuming with msvc that is not upstream.
>
> >>
> >>--
> >>You are receiving this mail because:
> >>You are the assignee for the bug.
prev parent reply other threads:[~2024-04-30 20:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 6:21 [DPDK/core Bug 1425] enable_stdatomic=true breaks C++ on GCC 11 and earlier bugzilla
2024-04-29 23:14 ` Tyler Retzlaff
2024-04-30 20:06 ` Mattias Rönnblom
2024-04-30 20:37 ` Tyler Retzlaff [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240430203714.GA7142@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=roretzla@linux.microsoft.com \
--cc=bugzilla@dpdk.org \
--cc=dev@dpdk.org \
--cc=hofors@lysator.liu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).