dmaengine Archive mirror
 help / color / mirror / Atom feed
From: Sricharan Ramabadhran <quic_srichara@quicinc.com>
To: Md Sadre Alam <quic_mdalam@quicinc.com>,
	<thara.gopinath@gmail.com>, <herbert@gondor.apana.org.au>,
	<davem@davemloft.net>, <agross@kernel.org>,
	<andersson@kernel.org>, <konrad.dybcio@linaro.org>,
	<vkoul@kernel.org>, <linux-crypto@vger.kernel.org>,
	<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<dmaengine@vger.kernel.org>, <quic_varada@quicinc.com>
Subject: Re: [PATCH 03/11] crypto: qce - Convert register r/w for skcipher via BAM/DMA
Date: Thu, 22 Feb 2024 16:56:19 +0530	[thread overview]
Message-ID: <f4af8317-776f-7530-51af-9cf42eab7b01@quicinc.com> (raw)
In-Reply-To: <20231214114239.2635325-4-quic_mdalam@quicinc.com>



On 12/14/2023 5:12 PM, Md Sadre Alam wrote:
> Convert register read/write for skcipher via BAM/DMA.
> with this change all the crypto register configuration
> will be done via BAM/DMA. This change will prepare command
> descriptor for all register and write it once.
> 
> Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
> ---
>   drivers/crypto/qce/common.c   | 42 +++++++++++++++++++++--------------
>   drivers/crypto/qce/skcipher.c | 12 ++++++++++
>   2 files changed, 37 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/crypto/qce/common.c b/drivers/crypto/qce/common.c
> index 04253a8d3340..d1da6b1938f3 100644
> --- a/drivers/crypto/qce/common.c
> +++ b/drivers/crypto/qce/common.c

  Changes to common.c should have been in patch #2 ?
  Btw, if we are making cmd desc approach as default for all socs
  we should have it tested in all platforms ?

Regards,
  Sricharan

  reply	other threads:[~2024-02-22 11:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-14 11:42 [PATCH 00/11] Add cmd descriptor support Md Sadre Alam
2023-12-14 11:42 ` [PATCH 01/11] crypto: qce - Add support for crypto address read Md Sadre Alam
2024-02-21 18:02   ` Sricharan Ramabadhran
2023-12-14 11:42 ` [PATCH 02/11] crypto: qce - Add bam dma support for crypto register r/w Md Sadre Alam
2023-12-15  0:11   ` kernel test robot
2023-12-15  0:23   ` kernel test robot
2024-02-22 11:06   ` Sricharan Ramabadhran
2023-12-14 11:42 ` [PATCH 03/11] crypto: qce - Convert register r/w for skcipher via BAM/DMA Md Sadre Alam
2024-02-22 11:26   ` Sricharan Ramabadhran [this message]
2023-12-14 11:42 ` [PATCH 04/11] crypto: qce - Convert register r/w for sha " Md Sadre Alam
2023-12-14 11:42 ` [PATCH 05/11] crypto: qce - Convert register r/w for aead " Md Sadre Alam
2023-12-14 11:42 ` [PATCH 06/11] drivers: bam_dma: Add LOCK & UNLOCK flag support Md Sadre Alam
2023-12-14 11:42 ` [PATCH 07/11] crypto: qce - Add LOCK and " Md Sadre Alam
2023-12-14 11:42 ` [PATCH 08/11] crypto: qce - Add support for lock aquire,lock release api Md Sadre Alam
2023-12-14 11:42 ` [PATCH 09/11] crypto: qce - Add support for lock/unlock in skcipher Md Sadre Alam
2023-12-14 11:42 ` [PATCH 10/11] crypto: qce - Add support for lock/unlock in sha Md Sadre Alam
2023-12-14 11:42 ` [PATCH 11/11] crypto: qce - Add support for lock/unlock in aead Md Sadre Alam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4af8317-776f-7530-51af-9cf42eab7b01@quicinc.com \
    --to=quic_srichara@quicinc.com \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=davem@davemloft.net \
    --cc=dmaengine@vger.kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=konrad.dybcio@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_mdalam@quicinc.com \
    --cc=quic_varada@quicinc.com \
    --cc=thara.gopinath@gmail.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).