From: Fenghua Yu <fenghua.yu@intel.com>
To: Dave Jiang <dave.jiang@intel.com>, Vinod Koul <vkoul@kernel.org>
Cc: <dmaengine@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Lingyan Guo <lingyan.guo@intel.com>
Subject: Re: [PATCH] dmaengine: idxd: Clear Event Log head in idxd upon completion of the Enable Device command
Date: Mon, 12 Feb 2024 08:56:53 -0800 [thread overview]
Message-ID: <f1b96616-296d-85ec-3e59-54b6035fa954@intel.com> (raw)
In-Reply-To: <c643b6a3-0f41-416f-9268-3072f76939e3@intel.com>
Hi, Dave,
On 2/12/24 08:39, Dave Jiang wrote:
>
>
> On 2/10/24 6:49 PM, Fenghua Yu wrote:
>> Hi, Dave,
>>
>> On 2/9/24 12:17, Dave Jiang wrote:
>>>
>>>
>>> On 2/9/24 12:18 PM, Fenghua Yu wrote:
>>>> If Event Log is supported, upon completion of the Enable Device command,
>>>> the Event Log head in the variable idxd->evl->head should be cleared to
>>>> match the state of the EVLSTATUS register. But the variable is not reset
>>>> currently, leading mismatch of the variable and the register state.
>>>> The mismatch causes incorrect processing of Event Log entries.
>>>>
>>>> Fix the issue by clearing the variable after completion of the command.
>>>
>>> Should this be done in idxd_device_clear_state() instead?
>>
>> If clear evl->head in idxd_device_clear_state(), evl->head still mismatches head in EVLSTATUS in some cases.
>>
>> For exmample, when a few event log entries are logged and then device is disabled, head in EVLSTATUS is still a valid non-zero value. Clearing evl->head in idxd_device_clear_state() when disabling device makes evl->head and head in EVLSTATUS mismatched.
>>
>> I haven't thought a failure test case when they mismatch in these cases though.
>>
>> But while thinking evl->head more, I wonder why is it even needed?
>>
>> head of event log can always be read from EVLSTATUS instead of from its shadow evl->head. And reading head from EVLSTATUS won't degrade performance because tail is always read from EVLSTATUS whenever head is read (no matter from evl->head or from EVLSATUS).
>>
>> To avoid any mismatch issue/trouble, I think the right fix is to remove head definition in struct idxd_evl and always read head from EVLSTATUS.
>>
>> Do you think this is the right fix?
>
> I was to avoid register reads during event processing. But if you think there's no performance impact then feel free to read directly from the register.
This code reads head and tail in event processing:
h = evl->head;
evl_status.bits = ioread64(idxd->reg_base + IDXD_EVLSTATUS_OFFSET);
t = evl_status.tail;
As you can see EVLSTATUS is always read to get tail. Reading the
register to get tail cannot be avoid because that's required by hw.
Reading head from the register won't add additional cost.
That's why I would say no impact on performance without the shadow head
in idxd.
I will cook the v2 patch by removing the shadow head.
Thanks.
-Fenghua
prev parent reply other threads:[~2024-02-12 16:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 19:18 [PATCH] dmaengine: idxd: Clear Event Log head in idxd upon completion of the Enable Device command Fenghua Yu
2024-02-09 20:17 ` Dave Jiang
2024-02-11 1:49 ` Fenghua Yu
2024-02-12 16:39 ` Dave Jiang
2024-02-12 16:56 ` Fenghua Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1b96616-296d-85ec-3e59-54b6035fa954@intel.com \
--to=fenghua.yu@intel.com \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=lingyan.guo@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).