From: Herbert Xu <herbert@gondor.apana.org.au>
To: Tom Zanussi <tom.zanussi@linux.intel.com>
Cc: davem@davemloft.net, andre.glover@linux.intel.com,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
dmaengine@vger.kernel.org
Subject: Re: [PATCH 0/4] crypto: IAA stats bugfixes and simplifications
Date: Thu, 28 Mar 2024 18:44:32 +0800 [thread overview]
Message-ID: <ZgVKECpfxpxyrzfR@gondor.apana.org.au> (raw)
In-Reply-To: <20240304212011.1525003-1-tom.zanussi@linux.intel.com>
On Mon, Mar 04, 2024 at 03:20:07PM -0600, Tom Zanussi wrote:
> Hi Herbert,
>
> While doing some testing, I noticed a discrepancy in the
> decomp_bytes_in stat, which the first patch in this series (crypto:
> iaa - fix decomp_bytes_in stats) fixes.
>
> I also realized that there were some other problems unrelated to that
> but also that the stats code could be simplified in a number of ways
> and that some of it wasn't really useful. The stats code is debugging
> code and has been helpful to quickly verify whether things are
> basically working, but since it's there we should make it as accurate
> and actually useful as possible.
>
> I realize the second patch (crypto: iaa - Remove comp/decomp delay
> statistics) removes the code I just fixed up in a patch you just
> merged (crypto: iaa - Fix comp/decomp delay statistics) - let me know
> if you want me to combine those if you want to remove the latter from
> your branch...
>
> Thanks,
>
> Tom
>
>
> *** BLURB HERE ***
>
> Tom Zanussi (4):
> crypto: iaa - fix decomp_bytes_in stats
> crypto: iaa - Remove comp/decomp delay statistics
> crypto: iaa - Add global_stats file and remove individual stat files
> crypto: iaa - Change iaa statistics to atomic64_t
>
> .../driver-api/crypto/iaa/iaa-crypto.rst | 76 +++++---
> drivers/crypto/intel/iaa/iaa_crypto.h | 16 +-
> drivers/crypto/intel/iaa/iaa_crypto_main.c | 13 +-
> drivers/crypto/intel/iaa/iaa_crypto_stats.c | 183 ++++++++----------
> drivers/crypto/intel/iaa/iaa_crypto_stats.h | 8 -
> 5 files changed, 140 insertions(+), 156 deletions(-)
>
> --
> 2.34.1
All applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2024-03-28 10:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 21:20 [PATCH 0/4] crypto: IAA stats bugfixes and simplifications Tom Zanussi
2024-03-04 21:20 ` [PATCH 1/4] crypto: iaa - fix decomp_bytes_in stats Tom Zanussi
2024-03-04 21:20 ` [PATCH 2/4] crypto: iaa - Remove comp/decomp delay statistics Tom Zanussi
2024-03-04 21:20 ` [PATCH 3/4] crypto: iaa - Add global_stats file and remove individual stat files Tom Zanussi
2024-03-04 21:20 ` [PATCH 4/4] crypto: iaa - Change iaa statistics to atomic64_t Tom Zanussi
2024-03-28 10:44 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgVKECpfxpxyrzfR@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=andre.glover@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dmaengine@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).