From: Vinod Koul <vkoul@kernel.org>
To: Peter Robinson <pbrobinson@gmail.com>
Cc: linux-tegra@vger.kernel.org, Jon Hunter <jonathanh@nvidia.com>,
Thierry Reding <treding@nvidia.com>,
Sameer Pujar <spujar@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
dmaengine@vger.kernel.org
Subject: Re: [PATCH 2/2] dmaengine: tegra210-adma: Update dependency to ARCH_TEGRA
Date: Fri, 16 Feb 2024 17:55:33 +0530 [thread overview]
Message-ID: <Zc9UPX3W6zMubgOV@matsya> (raw)
In-Reply-To: <20240216100246.568473-2-pbrobinson@gmail.com>
On 16-02-24, 10:02, Peter Robinson wrote:
> Update the architecture dependency to be the generic Tegra
> because the driver works on the four latest Tegra generations
> not just Tegra210, if you build a kernel with a specific
> ARCH_TEGRA_xxx_SOC option that excludes Tegra210 you don't get
> this driver.
??
This is already in linux-next, see 33b7db45533af240fe44e809f9dc4d604cf82d07
>
> Fixes: 433de642a76c9 ("dmaengine: tegra210-adma: add support for Tegra186/Tegra194")
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> Cc: Jon Hunter <jonathanh@nvidia.com>
> Cc: Thierry Reding <treding@nvidia.com>
> Cc: Sameer Pujar <spujar@nvidia.com>
> Cc: Laxman Dewangan <ldewangan@nvidia.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: dmaengine@vger.kernel.org
> ---
>
> v2: fix spelling of option
> v3: Update T210 -> Tegra210
> use "and later" rather than all current devices
>
> drivers/dma/Kconfig | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index e928f2ca0f1e9..ae23b886a6c60 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -643,16 +643,16 @@ config TEGRA20_APB_DMA
>
> config TEGRA210_ADMA
> tristate "NVIDIA Tegra210 ADMA support"
> - depends on (ARCH_TEGRA_210_SOC || COMPILE_TEST)
> + depends on (ARCH_TEGRA || COMPILE_TEST)
> select DMA_ENGINE
> select DMA_VIRTUAL_CHANNELS
> help
> - Support for the NVIDIA Tegra210 ADMA controller driver. The
> - DMA controller has multiple DMA channels and is used to service
> - various audio clients in the Tegra210 audio processing engine
> - (APE). This DMA controller transfers data from memory to
> - peripheral and vice versa. It does not support memory to
> - memory data transfer.
> + Support for the NVIDIA Tegra210 and later ADMA
> + controller driver. The DMA controller has multiple DMA channels
> + and is used to service various audio clients in the Tegra210
> + audio processing engine (APE). This DMA controller transfers
> + data from memory to peripheral and vice versa. It does not
> + support memory to memory data transfer.
>
> config TIMB_DMA
> tristate "Timberdale FPGA DMA support"
> --
> 2.43.1
--
~Vinod
prev parent reply other threads:[~2024-02-16 12:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240216100246.568473-1-pbrobinson@gmail.com>
2024-02-16 10:02 ` [PATCH 2/2] dmaengine: tegra210-adma: Update dependency to ARCH_TEGRA Peter Robinson
2024-02-16 10:50 ` Thierry Reding
2024-02-16 12:25 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zc9UPX3W6zMubgOV@matsya \
--to=vkoul@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-tegra@vger.kernel.org \
--cc=pbrobinson@gmail.com \
--cc=spujar@nvidia.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).