From: JiaJie Ho <jiajie.ho@starfivetech.com>
To: 'Rob Herring' <robh@kernel.org>
Cc: 'Herbert Xu' <herbert@gondor.apana.org.au>,
"'David S . Miller'" <davem@davemloft.net>,
'Krzysztof Kozlowski' <krzysztof.kozlowski+dt@linaro.org>,
'Conor Dooley' <conor+dt@kernel.org>,
'Eugeniy Paltsev' <Eugeniy.Paltsev@synopsys.com>,
'Vinod Koul' <vkoul@kernel.org>,
"'linux-crypto@vger.kernel.org'" <linux-crypto@vger.kernel.org>,
"'devicetree@vger.kernel.org'" <devicetree@vger.kernel.org>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
"'dmaengine@vger.kernel.org'" <dmaengine@vger.kernel.org>
Subject: RE: [PATCH v3 1/6] dt-bindings: crypto: starfive: Add jh8100 support
Date: Thu, 29 Feb 2024 02:17:41 +0000 [thread overview]
Message-ID: <SHXPR01MB067062096D7EE6FB5F9305C58A5FA@SHXPR01MB0670.CHNPR01.prod.partner.outlook.cn> (raw)
In-Reply-To: <20240228155112.GA4059153-robh@kernel.org>
> > Add compatible string and additional interrupt for StarFive JH8100
> > crypto engine.
> >
> > Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com>
> > ---
> > .../crypto/starfive,jh7110-crypto.yaml | 30 +++++++++++++++++--
> > 1 file changed, 28 insertions(+), 2 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/crypto/starfive,jh7110-crypto.yaml
> > b/Documentation/devicetree/bindings/crypto/starfive,jh7110-crypto.yaml
> > index 71a2876bd6e4..d44d77908966 100644
> > ---
> > a/Documentation/devicetree/bindings/crypto/starfive,jh7110-crypto.yaml
> > +++ b/Documentation/devicetree/bindings/crypto/starfive,jh7110-crypto.
> > +++ yaml
> > @@ -12,7 +12,9 @@ maintainers:
> >
> > properties:
> > compatible:
> > - const: starfive,jh7110-crypto
> > + enum:
> > + - starfive,jh8100-crypto
> > + - starfive,jh7110-crypto
> >
> > reg:
> > maxItems: 1
> > @@ -28,7 +30,10 @@ properties:
> > - const: ahb
> >
> > interrupts:
> > - maxItems: 1
> > + minItems: 1
> > + items:
> > + - description: SHA2 module irq
> > + - description: SM3 module irq
> >
> > resets:
> > maxItems: 1
> > @@ -54,6 +59,27 @@ required:
> >
> > additionalProperties: false
> >
> > +allOf:
> > + - if:
> > + properties:
> > + compatible:
> > + const: starfive,jh7110-crypto
> > +
> > + then:
> > + properties:
> > + interrupts:
> > + maxItems: 1
> > +
> > + - if:
> > + properties:
> > + compatible:
> > + const: starfive,jh8100-crypto
> > +
> > + then:
> > + properties:
> > + interrupts:
> > + maxItems: 2
>
> This is already the max. Don't you want 'minItems: 2'?
I'll fix this in the next version.
Thanks for reviewing this.
Regards,
Jia Jie
next prev parent reply other threads:[~2024-02-29 2:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 16:37 [PATCH v3 0/6] crypto: starfive: Add support for JH8100 Jia Jie Ho
2024-02-27 16:37 ` [PATCH v3 1/6] dt-bindings: crypto: starfive: Add jh8100 support Jia Jie Ho
2024-02-28 11:19 ` Conor Dooley
2024-02-28 15:51 ` Rob Herring
2024-02-29 2:17 ` JiaJie Ho [this message]
2024-02-27 16:37 ` [PATCH v3 2/6] crypto: starfive: Update hash dma usage Jia Jie Ho
2024-02-27 16:37 ` [PATCH v3 3/6] crypto: starfive: Use dma for aes requests Jia Jie Ho
2024-02-27 16:37 ` [PATCH v3 4/6] dmaengine: dw-axi-dmac: Support hardware quirks Jia Jie Ho
2024-02-27 16:37 ` [PATCH v3 5/6] crypto: starfive: Add sm3 support for JH8100 Jia Jie Ho
2024-02-27 16:37 ` [PATCH v3 6/6] crypto: starfive: Add sm4 " Jia Jie Ho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SHXPR01MB067062096D7EE6FB5F9305C58A5FA@SHXPR01MB0670.CHNPR01.prod.partner.outlook.cn \
--to=jiajie.ho@starfivetech.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).