From: Joy Zou <joy.zou@nxp.com>
To: Frank Li <frank.li@nxp.com>, Krzysztof Kozlowski <krzk@kernel.org>
Cc: Peng Fan <peng.fan@nxp.com>,
"vkoul@kernel.org" <vkoul@kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH v2 2/2] dma: dt-bindings: fsl-edma: clean up unused "fsl,imx8qm-adma" compatible stringg
Date: Fri, 12 Apr 2024 01:59:31 +0000 [thread overview]
Message-ID: <AS4PR04MB9386CDE4C44F8540EF4EF1F1E1042@AS4PR04MB9386.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <Zhfj2NH7PPqzz3nM@lizhi-Precision-Tower-5810>
> -----Original Message-----
> From: Frank Li <frank.li@nxp.com>
> Sent: 2024年4月11日 21:21
> To: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Joy Zou <joy.zou@nxp.com>; Peng Fan <peng.fan@nxp.com>;
> vkoul@kernel.org; robh@kernel.org; krzk+dt@kernel.org;
> conor+dt@kernel.org; imx@lists.linux.dev; dmaengine@vger.kernel.org;
> linux-kernel@vger.kernel.org; devicetree@vger.kernel.org
> Subject: Re: [PATCH v2 2/2] dma: dt-bindings: fsl-edma: clean up unused
> "fsl,imx8qm-adma" compatible stringg
>
>
> It should be
>
> dt-bindings: fsl-dma: fsl-edma: clean up unused "fsl,imx8qm-adma"
> compatible stringg
>
>
> b7b8715b430ee dt-bindings: fsl-dma: fsl-edma: add fsl,imx95-edma5
> compatible string 6eb439dff645a dt-bindings: fsl-dma: fsl-edma: add edma3
> compatible string
> 10cafa2d45885 dt-bindings: dma: drop unneeded quotes cfa1927f8468c
> dt-bindings: dma: fsl-edma: Convert to DT schema
>
>
> On Thu, Apr 11, 2024 at 10:13:38AM +0200, Krzysztof Kozlowski wrote:
> > On 11/04/2024 09:43, Joy Zou wrote:
> > > The compatible string "fsl,imx8qm-adma" is unused.
> >
> > Why? Commit must stand on its own.
>
> Joy:
> You can copy patch2's comit
Thanks your comments!
Will add more description for the drop reason.
> >
> > >
> > > Signed-off-by: Joy Zou <joy.zou@nxp.com>
> > > ---
> >
> > Please use subject prefixes matching the subsystem. You can get them
> > for example with `git log --oneline -- DIRECTORY_OR_FILE` on the
> > directory your patch is touching.
> >
> > > Documentation/devicetree/bindings/dma/fsl,edma.yaml | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> > > b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> > > index 825f4715499e..64fa27d0cd9b 100644
> > > --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> > > +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> > > @@ -21,7 +21,6 @@ properties:
> > > - enum:
> > > - fsl,vf610-edma
> > > - fsl,imx7ulp-edma
> > > - - fsl,imx8qm-adma
> >
> >
> > I see more usages. One more trivial patch which is incorrect.
> >
>
> Please clean up AllOf also.
>
> allOf:
> - $ref: dma-controller.yaml#
> - if:
> properties:
> compatible:
> contains:
> enum:
> - fsl,imx8qm-adma
> ^^^^
> - fsl,imx8qm-edma
>
Yeah, will clean up also.
BR
Joy Zou
> > Did you implement the internal review?
>
> Patch2 was internal reviewed. Patch1 is new. I know you are busy. Could you
> please give me 1 days to review nxp's patches. You see patch always ahead
> me if author and you are in similar time zone.
>
> I knew they are quite busy on heavy development work and all kinds
> customer supports.
>
> Frank
>
> > Best regards,
> > Krzysztof
> >
prev parent reply other threads:[~2024-04-12 1:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 7:43 [PATCH v2 0/2] clean up unused "fsl,imx8qm-adma" compatible string Joy Zou
2024-04-11 7:43 ` [PATCH v2 1/2] dmaengine: fsl-edma: Remove " Joy Zou
2024-04-11 14:29 ` Frank Li
2024-04-11 7:43 ` [PATCH v2 2/2] dma: dt-bindings: fsl-edma: clean up " Joy Zou
2024-04-11 8:13 ` Krzysztof Kozlowski
2024-04-11 13:21 ` [PATCH v2 2/2] dma: dt-bindings: fsl-edma: clean up unused "fsl,imx8qm-adma" compatible stringg Frank Li
2024-04-12 1:59 ` Joy Zou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS4PR04MB9386CDE4C44F8540EF4EF1F1E1042@AS4PR04MB9386.eurprd04.prod.outlook.com \
--to=joy.zou@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=frank.li@nxp.com \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).