From: Joy Zou <joy.zou@nxp.com>
To: Frank Li <frank.li@nxp.com>
Cc: Peng Fan <peng.fan@nxp.com>,
"vkoul@kernel.org" <vkoul@kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH v3 2/2] dma: dt-bindings: fsl-edma: clean up unused "fsl,imx8qm-adma" compatible string
Date: Fri, 12 Apr 2024 06:11:58 +0000 [thread overview]
Message-ID: <AS4PR04MB938611B9AF281AE6CD72B08CE1042@AS4PR04MB9386.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <ZhilSv5xh0hJ2vdX@lizhi-Precision-Tower-5810>
> -----Original Message-----
> From: Frank Li <frank.li@nxp.com>
> Sent: 2024年4月12日 11:07
> To: Joy Zou <joy.zou@nxp.com>
> Cc: Peng Fan <peng.fan@nxp.com>; vkoul@kernel.org; robh@kernel.org;
> krzk+dt@kernel.org; conor+dt@kernel.org; imx@lists.linux.dev;
> dmaengine@vger.kernel.org; linux-kernel@vger.kernel.org;
> devicetree@vger.kernel.org
> Subject: Re: [PATCH v3 2/2] dma: dt-bindings: fsl-edma: clean up unused
> "fsl,imx8qm-adma" compatible string
>
> On Fri, Apr 12, 2024 at 11:04:36AM +0800, Joy Zou wrote:
> > The eDMA hardware issue only exist imx8QM A0. A0 never mass
> production.
> > The compatible string "fsl,imx8qm-adma" is unused. So remove the
> > workaround safely.
>
>
> You missed change subject:
>
> dt-bindings: fsl-edma: clean up unused "fsl,imx8qm-adma" compatible string
>
> dt-bindings should be first patch, then driver code.
>
> I suggest use the same words, "clean up" or "Remove". keep consistent for
> both patches
Thanks your comments!
Yeah, sorry for forgetting to change it. Will change in next version.
BR
Joy Zou
>
> Frank
>
prev parent reply other threads:[~2024-04-12 6:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 3:04 [PATCH v3 0/2] clean up unused "fsl,imx8qm-adma" compatible string Joy Zou
2024-04-12 3:04 ` [PATCH v3 1/2] dmaengine: fsl-edma: Remove " Joy Zou
2024-04-12 3:04 ` [PATCH v3 2/2] dma: dt-bindings: fsl-edma: clean up " Joy Zou
2024-04-12 3:06 ` Frank Li
2024-04-12 6:11 ` Joy Zou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS4PR04MB938611B9AF281AE6CD72B08CE1042@AS4PR04MB9386.eurprd04.prod.outlook.com \
--to=joy.zou@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=frank.li@nxp.com \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).