From: Dave Jiang <dave.jiang@intel.com>
To: n.shubin@yadro.com, Vinod Koul <vkoul@kernel.org>,
Dan Williams <dan.j.williams@intel.com>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
Nikita Shubin <nikita.shubin@maquefel.me>
Subject: Re: [PATCH] dmaengine: ioatdma: Fix missing kmem_cache_destroy()
Date: Tue, 14 May 2024 08:38:16 -0700 [thread overview]
Message-ID: <85cd8e12-261f-4fa0-aa83-75c7f692d8f3@intel.com> (raw)
In-Reply-To: <20240514-ioatdma_fixes-v1-1-2776a0913254@yadro.com>
On 5/14/24 3:52 AM, Nikita Shubin via B4 Relay wrote:
> From: Nikita Shubin <n.shubin@yadro.com>
>
> Fix missing kmem_cache_destroy() for ioat_sed_cache in
> ioat_exit_module().
>
> Noticed via:
>
> ```
> modprobe ioatdma
> rmmod ioatdma
> modprobe ioatdma
> debugfs: Directory 'ioat_sed_ent' with parent 'slab' already present!
> ```
>
> Fixes: c0f28ce66ecf ("dmaengine: ioatdma: move all the init routines")
> Signed-off-by: Nikita Shubin <n.shubin@yadro.com>
Thanks!
Acked-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/dma/ioat/init.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c
> index 9c364e92cb82..61329c279040 100644
> --- a/drivers/dma/ioat/init.c
> +++ b/drivers/dma/ioat/init.c
> @@ -1445,6 +1445,7 @@ module_init(ioat_init_module);
> static void __exit ioat_exit_module(void)
> {
> pci_unregister_driver(&ioat_pci_driver);
> + kmem_cache_destroy(ioat_sed_cache);
> kmem_cache_destroy(ioat_cache);
> }
> module_exit(ioat_exit_module);
>
> ---
> base-commit: a38297e3fb012ddfa7ce0321a7e5a8daeb1872b6
> change-id: 20240514-ioatdma_fixes-7460f4fd7d51
>
> Best regards,
prev parent reply other threads:[~2024-05-14 15:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 10:52 [PATCH] dmaengine: ioatdma: Fix missing kmem_cache_destroy() Nikita Shubin via B4 Relay
2024-05-14 15:38 ` Dave Jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85cd8e12-261f-4fa0-aa83-75c7f692d8f3@intel.com \
--to=dave.jiang@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=n.shubin@yadro.com \
--cc=nikita.shubin@maquefel.me \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).